From 9e3c61b09007a094586badb21fadbe2ae65e69ce Mon Sep 17 00:00:00 2001 From: Ruben Nogueira <40404708+rubnogueira@users.noreply.github.com> Date: Tue, 19 May 2026 18:51:40 +0100 Subject: [PATCH] fix(libexpat): remove dead `version` target referencing missing version.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit deps/libexpat/libexpat.gyp declared a top-level `version` executable target whose only source was `version.c` — a file that does not exist in the deps tree. Our binding only depends on the `:expat` static_library target, so on Linux/macOS `make` builds the dependency graph and silently skips the unused `version` target. MSBuild on Windows, however, builds every .vcxproj that gyp generates from the .gyp file. The vcxproj for the `version` target references a missing source file, and MSBuild bails out with exit code 2 before our actual binding ever gets a chance to compile. Removing the dead target unblocks the Windows build without affecting anything else (verified locally that darwin-arm64 still builds clean). Co-Authored-By: Claude Opus 4.7 (1M context) --- deps/libexpat/libexpat.gyp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/deps/libexpat/libexpat.gyp b/deps/libexpat/libexpat.gyp index d74e868..d044598 100644 --- a/deps/libexpat/libexpat.gyp +++ b/deps/libexpat/libexpat.gyp @@ -81,12 +81,5 @@ ], }, }, - - { - 'target_name': 'version', - 'type': 'executable', - 'dependencies': [ 'expat' ], - 'sources': [ 'version.c' ] - }, ] }