Implement AbstractUpdater.

Signed-off-by: Arris Ray <arris.ray+github@gmail.com>

Author: arris-ray

src/Prometheus/Storage/RedisTxn/Updater/AbstractUpdater.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace Prometheus\Storage\RedisTxn\Updater;
+
+use Prometheus\Storage\RedisTxn\RedisScript\RedisScriptHelper;
+use Redis;
+
+abstract class AbstractUpdater implements UpdaterInterface
+{
+    /**
+     * @var RedisScriptHelper
+     */
+    private $helper;
+
+    /**
+     * @var Redis
+     */
+    private $redis;
+
+    /**
+     * @param Redis $redis
+     */
+    public function __construct(Redis $redis)
+    {
+        $this->helper = new RedisScriptHelper();
+        $this->redis = $redis;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getHelper(): RedisScriptHelper
+    {
+        return $this->helper;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getRedis(): Redis
+    {
+        return $this->redis;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function update(array $data)
+    {
+        return $this->getRedisScript($data)->eval($this->getRedis());
+    }
+}

src/Prometheus/Storage/RedisTxn/Updater/CounterUpdater.php

@@ -4,10 +4,8 @@
 
 use Prometheus\Storage\RedisTxn\Metric\MetadataBuilder;
 use Prometheus\Storage\RedisTxn\RedisScript\RedisScript;
-use Prometheus\Storage\RedisTxn\RedisScript\RedisScriptHelper;
-use Redis;
 
-class CounterUpdater implements UpdaterInterface
+class CounterUpdater extends AbstractUpdater
 {
     /**
      * @var string
@@ -46,41 +44,6 @@ class CounterUpdater implements UpdaterInterface
 return didUpdate
 LUA;
 
-    /**
-     * @var RedisScriptHelper
-     */
-    private $helper;
-
-    /**
-     * @var Redis
-     */
-    private $redis;
-
-    /**
-     * @param Redis $redis
-     */
-    public function __construct(Redis $redis)
-    {
-        $this->helper = new RedisScriptHelper();
-        $this->redis = $redis;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getHelper(): RedisScriptHelper
-    {
-        return $this->helper;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getRedis(): Redis
-    {
-        return $this->redis;
-    }
-
     /**
      * @inheritDoc
      */
@@ -115,12 +78,4 @@ public function getRedisScript(array $data): RedisScript
             ->withNumKeys(3)
             ->build();
     }
-
-    /**
-     * @inheritDoc
-     */
-    public function update(array $data)
-    {
-        return $this->getRedisScript($data)->eval($this->redis);
-    }
 }

src/Prometheus/Storage/RedisTxn/Updater/GaugeUpdater.php

@@ -4,10 +4,8 @@
 
 use Prometheus\Storage\RedisTxn\Metric\MetadataBuilder;
 use Prometheus\Storage\RedisTxn\RedisScript\RedisScript;
-use Prometheus\Storage\RedisTxn\RedisScript\RedisScriptHelper;
-use Redis;
 
-class GaugeUpdater implements UpdaterInterface
+class GaugeUpdater extends AbstractUpdater
 {
     /**
      * @var string
@@ -52,42 +50,6 @@ class GaugeUpdater implements UpdaterInterface
 return didUpdate
 LUA;
 
-    /**
-     * @var RedisScriptHelper
-     */
-    private $helper;
-
-    /**
-     * @var Redis
-     */
-    private $redis;
-
-    /**
-     * @param Redis $redis
-     */
-    public function __construct(Redis $redis)
-    {
-        $this->helper = new RedisScriptHelper();
-        $this->redis = $redis;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getHelper(): RedisScriptHelper
-    {
-        $this->helper = $this->helper ?? new RedisScriptHelper();
-        return $this->helper;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getRedis(): Redis
-    {
-        return $this->redis;
-    }
-
     /**
      * @inheritDoc
      */
@@ -122,12 +84,4 @@ public function getRedisScript(array $data): RedisScript
             ->withNumKeys(3)
             ->build();
     }
-
-    /**
-     * @inheritDoc
-     */
-    public function update(array $data)
-    {
-        return $this->getRedisScript($data)->eval($this->redis);
-    }
 }

src/Prometheus/Storage/RedisTxn/Updater/SummaryUpdater.php

@@ -4,10 +4,8 @@
 
 use Prometheus\Storage\RedisTxn\Metric\MetadataBuilder;
 use Prometheus\Storage\RedisTxn\RedisScript\RedisScript;
-use Prometheus\Storage\RedisTxn\RedisScript\RedisScriptHelper;
-use Redis;
 
-class SummaryUpdater implements UpdaterInterface
+class SummaryUpdater extends AbstractUpdater
 {
     /**
      * @var string
@@ -34,39 +32,6 @@ class SummaryUpdater implements UpdaterInterface
 redis.call('hset', metaHashKey, ttlFieldName, ttlFieldValue)
 LUA;
 
-    /**
-     * @var RedisScriptHelper
-     */
-    private $helper;
-
-    /**
-     * @var Redis
-     */
-    private $redis;
-
-    /**
-     * @param Redis $redis
-     */
-    public function __construct(Redis $redis)
-    {
-        $this->helper = new RedisScriptHelper();
-        $this->redis = $redis;
-    }
-
-    public function getHelper(): RedisScriptHelper
-    {
-        $this->helper = $this->helper ?? new RedisScriptHelper();
-        return $this->helper;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getRedis(): Redis
-    {
-        return $this->redis;
-    }
-
     /**
      * @inheritDoc
      */
@@ -112,12 +77,4 @@ public function getRedisScript(array $data): RedisScript
             ->withNumKeys(3)
             ->build();
     }
-
-    /**
-     * @inheritDoc
-     */
-    public function update(array $data)
-    {
-        return $this->getRedisScript($data)->eval($this->redis);
-    }
 }