Skip to content

SUM-SEC-17 [P2][17/20][Low] App logs handler must enforce ORM model Access Control List (ACL) #81

Description

@CHINMAYVIVEK

ID: SUM-SEC-17
Wave: P2
Severity: Low
Labels: security, acl, admin, P2, low
Branch: fix/SUM-SEC-17-app-logs-orm-acl
Languages: Go

Summary

App logs UI uses raw SQL after a menu/group check only. If menu groups change, the handler can bypass CheckModelAccess for app.log.

Acceptance criteria

  • Call CheckModelAccess(ctx, uid, "app.log", "read") (or equivalent) in handler
  • Test denied when ACL missing even if route reached

Files to check / change

  • sumeru/core/server/web/settings_app_logs.go (~L80–92)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions