Update script_test.rb

Author: mplesha

.github/tests/test/script_test.rb

@@ -67,29 +67,22 @@ def test_codeowners_not_present_develop
 
   def test_deny_merge_main
     classic_rules = @obj.rules_required_pull_request_reviews('main')
-    rulesets_rules = @obj.get_branch_ruleset('main')
-    if rulesets_rules.class == Array
-      rulesets_rules = rulesets.find { |rule| rule['type'] == 'pull_request' }
-    end
+    rulesets = @obj.get_branch_ruleset('main')
+    rulesets_rules = rulesets.nil? || rulesets.find { |rule| rule['type'] == 'pull_request' }
     assert_not_nil(classic_rules || rulesets_rules, 'We should not allow merge to main branch without PR')
   end
 
   def test_deny_merge_develop
     classic_rules = @obj.rules_required_pull_request_reviews('develop')
-    rulesets_rules = @obj.get_branch_ruleset('develop')
-    if rulesets_rules.class == Array
-      rulesets_rules = rulesets_rules.find { |rule| rule['type'] == 'pull_request' }
-    end
-    assert_not_nil(classic_rules || rulesets, 'We should not allow merge to develop branch without PR ')
+    rulesets = @obj.get_branch_ruleset('develop')
+    rulesets_rules = rulesets.nil? || rulesets.find { |rule| rule['type'] == 'pull_request' }
+    assert_not_nil(classic_rules || rulesets_rules, 'We should not allow merge to develop branch without PR ')
   end
 
   def test_2_approvals_develop
     classic_required_approving_review_count = @obj.rules_required_pull_request_reviews('develop').nil? || @obj.rules_required_pull_request_reviews('develop')["required_approving_review_count"]
     pull_request_rulesets_rules = @obj.get_branch_ruleset('develop')
-    if pull_request_rulesets_rules.class == Array
-      pull_request_rulesets_rules = pull_request_rulesets_rules.find { |rule| rule['type'] == 'pull_request' }
-    end
-    rulesets_required_approving_review_count = pull_request_rulesets_rules['parameters']['required_approving_review_count']
+    rulesets_required_approving_review_count = pull_request_rulesets_rules.nil? || pull_request_rulesets_rules.find { |rule| rule['type'] == 'pull_request' }['parameters']['required_approving_review_count']
     expected = 2
     required_approving_review_count = classic_required_approving_review_count == expected || rulesets_required_approving_review_count == expected
     assert_true(required_approving_review_count, 'We should have 2 approvals before merge to develop branch')
@@ -98,10 +91,7 @@ def test_2_approvals_develop
   def test_without_approval_main
     classic_required_approving_review_count = @obj.rules_required_pull_request_reviews('main').nil? || @obj.rules_required_pull_request_reviews('main')["required_approving_review_count"]
     pull_request_rulesets_rules = @obj.get_branch_ruleset('main')
-    if pull_request_rulesets_rules.class == Array
-      pull_request_rulesets_rules = pull_request_rulesets_rules.find { |rule| rule['type'] == 'pull_request' }
-    end
-    rulesets_required_approving_review_count = pull_request_rulesets_rules['parameters']['required_approving_review_count']
+    rulesets_required_approving_review_count = pull_request_rulesets_rules.nil? || pull_request_rulesets_rules.find { |rule| rule['type'] == 'pull_request' }['parameters']['required_approving_review_count']
     expected = 0
     required_approving_review_count = classic_required_approving_review_count == expected || rulesets_required_approving_review_count == expected
     assert_true(required_approving_review_count, 'We shouldn\'t have any approvals before merge to main branch')
@@ -111,10 +101,7 @@ def test_approve_from_user
     user_name = 'online-marathon'
     classic_require_code_owner_review = @obj.rules_required_pull_request_reviews('develop').nil? || @obj.rules_required_pull_request_reviews('develop')["require_code_owner_reviews"]
     pull_request_rulesets_rules = @obj.get_branch_ruleset('develop')
-    if pull_request_rulesets_rules.class == Array
-      pull_request_rulesets_rules = pull_request_rulsets_rules.find { |rule| rule['type'] == 'pull_request' }
-    end
-    rulesets_require_code_owner_review = pull_request_rulesets_rules['parameters']['require_code_owner_review']
+    rulesets_require_code_owner_review = pull_request_rulesets_rules.nil? || pull_request_rulesets_rules('develop').find { |rule| rule['type'] == 'pull_request' }['parameters']['require_code_owner_review']
     assert_not_nil(classic_require_code_owner_review || rulesets_require_code_owner_review, "We should not allow merge to main branch without approve from #{user_name}")
   end