Refine online help feature

This change gives a namespace to the 'showonlinehelp' message type, making
it 'powerShell/showOnlineHelp'.  Also moves registration for the command
into the feature file.

Author: daviwil

README.md

@@ -13,6 +13,7 @@ that VS Code provides.
 - Go to Definition of cmdlets and variables
 - Find References of cmdlets and variables
 - Document and workspace symbol discovery
+- Launch online help for the symbol under the cursor using `Ctrl+F1`
 - Local script debugging and basic interactive console support!
 
 ## Example Scripts

package.json

@@ -43,11 +43,11 @@
 			"key": "ctrl+f1",
 			"when": "editorTextFocus"
 		}],
-                "commands": [{
-                        "command": "PowerShell.OnlineHelp",
-                        "title": "Get online help for command",
-                        "category": "PowerShell"
-                }],        	
+		"commands": [{
+			"command": "PowerShell.OnlineHelp",
+			"title": "Get online help for command",
+			"category": "PowerShell"
+		}],
 		"languages": [{
 			"id": "PowerShell",
 			"extensions": [ ".ps1", ".psm1", ".psd1", ".pssc", ".psrc" ],

src/features/ShowOnlineHelp.ts

@@ -1,5 +1,21 @@
+import vscode = require('vscode');
+import { LanguageClient } from 'vscode-languageclient';
 import { RequestType, NotificationType, ResponseError } from 'vscode-jsonrpc';
 
 export namespace ShowOnlineHelpRequest {
-	export const type: RequestType<string, void, void> = { get method() { return 'showonlinehelp'; } };
+	export const type: RequestType<string, void, void> = { get method() { return 'powerShell/showOnlineHelp'; } };
+}
+
+export function registerShowHelpCommand(client: LanguageClient): void {
+    var disposable = vscode.commands.registerCommand('PowerShell.OnlineHelp', () => {
+
+        const editor = vscode.window.activeTextEditor;
+
+        var selection = editor.selection;
+        var doc = editor.document;
+        var cwr = doc.getWordRangeAtPosition(selection.active)
+        var text = doc.getText(cwr);
+
+        client.sendRequest(ShowOnlineHelpRequest.type, text);
+    });
 }

src/main.ts

@@ -10,7 +10,7 @@ import settingsManager = require('./settings');
 import { LanguageClient, LanguageClientOptions, Executable } from 'vscode-languageclient';
 
 import { RequestType, NotificationType, ResponseError } from 'vscode-jsonrpc';
-import powerShellMessage = require('./features/ShowOnlineHelp');
+import { registerShowHelpCommand } from './features/ShowOnlineHelp';
 
 export function activate(context: vscode.ExtensionContext): void {
 
@@ -57,7 +57,6 @@ export function activate(context: vscode.ExtensionContext): void {
 				{ open: '\'', close: '\'', notIn: ['string', 'comment'] }
 			]			
 		}
-		
 	});
 
 	let args = [];
@@ -94,17 +93,8 @@ export function activate(context: vscode.ExtensionContext): void {
 
     client.start();
 
-    var disposable = vscode.commands.registerCommand('PowerShell.OnlineHelp', () => {
-		
-        const editor = vscode.window.activeTextEditor;
-
-        var selection = editor.selection;
-        var doc = editor.document;
-        var cwr = doc.getWordRangeAtPosition(selection.active)
-        var text = doc.getText(cwr);        
-        
-        client.sendRequest(powerShellMessage.ShowOnlineHelpRequest.type, text);
-    });
+	// Register other features
+	registerShowHelpCommand(client);
 }
 
 function resolveLanguageServerPath(settings: settingsManager.ISettings) : string {