Make it core-clr compatible and unix-friendly (#329)

* Make C# part CoreCLR-friendly

* Update csproj files

* xUnit tests pass on mac OS

* Switch build.psd1 to dotnet cli

* Remove old .nuget folder

* Replace powershell aliases by full names for cross-plat compatability

* Fix FullLoop.Tests.ps1

* Fix PlatyPs.Tests.ps1

* Fix appveyor and build.ps1

* Explicitly query IsLinux and IsMacOS in tests

* Update build docs

* add .travis.yml

* Fix casing in tests and build.ps1

* don't overwrite IsLinux and IsOsMac

* Silent Write-Progress on coreclr

* Make platyPS target net451 on windows

Author: vors

.gitignore

@@ -193,6 +193,7 @@ ModelManifest.xml
 # Out project specific stuff
 generatedMarkdown.txt
 out/
+publish/
 
 # For developing in VSCode
 .vscode/launch.json

.nuget/NuGet.Config

@@ -0,0 +1,24 @@
+# that gives us dotnet cli installed on the box
+language: csharp
+
+dist: trusty
+sudo: required
+
+mono: none
+dotnet: 2.0.0
+
+# instruction from https://github.com/PowerShell/PowerShell/blob/master/docs/installation/linux.md#ubuntu-1404
+
+install:
+  - curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add -
+  - curl https://packages.microsoft.com/config/ubuntu/14.04/prod.list | sudo tee /etc/apt/sources.list.d/microsoft.list
+  - sudo apt-get update
+  - sudo apt-get install -y powershell
+
+script:
+  - pwsh ./build.ps1
+  - dotnet test ./test/Markdown.MAML.Test
+  - sudo pwsh -C 'Install-Module Pester -Force'
+  # updated help is needed for tests, run as a Job to avoid Write-Progress output
+  - sudo pwsh -C '(update-help &) | Wait-Job'
+  - pwsh -C 'Invoke-Pester -EnableExit'

.nuget/NuGet.exe

@@ -10,22 +10,14 @@ There are two parts:
 
 - `Markdown.MAML.dll`, a .NET library written in C#.
   It does the heavy lifting, like parsing Markdown, transforming it into XML, and so on.
-  You can open `.\Markdown.MAML.sln` in Visual Studio 2015.
+  You can open `.\Markdown.MAML.sln` in Visual Studio on any platform.
 - A PowerShell module in `.\src\platyPS`.
   This module provides the user CLI.
 
-## First-time setup
-
-Restore NuGet packages.
-You can do this from Visual Studio, or from the command line.
-
-```
-.\.nuget\NuGet.exe restore
-```
-
 ## Build
 
 To build the whole project, use the `build.ps1` helper script.
+It depends on the [dotnet cli](https://docs.microsoft.com/en-us/dotnet/core/tools/) build tool.
 
 ```
 .\build.ps1
@@ -44,12 +36,9 @@ If you know a better workflow, please suggest it in the Issues.
 Each part of the project has a test set:
 
 - The C# part has xUnit tests.
-  You can run them with xUnit from Visual Studio.
+  You can run them from Visual Studio or from command line with `dotnet test ./test/Markdown.MAML.Test`.
 - The PowerShell part has [Pester](https://github.com/pester/Pester) tests.
-  You can run them using:
-  ```
-  Invoke-Pester
-  ```
+  You can run them with `Invoke-Pester`.
 
 **Note**: Pester tests always force-import the module from the output location of `.\build.ps1`.
 

.nuget/NuGet.targets

@@ -9,19 +9,19 @@ install:
 init:
     - git config --global core.autocrlf true
 
-before_build:
-    - nuget restore
-
 build_script:
     - ps: |
         $ErrorActionPreference = 'Stop'
         Update-Help # we need up-to-date help content for tests
         .\build.ps1 -Configuration Release
 
+test_script:
+    - dotnet test .\test\Markdown.MAML.Test
+
 after_test:
     - ps: |
         # We run Pester tests in after_test step
-        # we don't want to use test_script so Xunit tests just run
+        # we don't want to use test_script
         # appveyor doesn't run after_test, if tests failed.
         #
         # Pester tests produce artifacts in .\out directory

.travis.yml

@@ -6,102 +6,65 @@
 param(
     [ValidateSet('Debug', 'Release')]
     $Configuration = "Debug",
-    [switch]$SkipDocs
+    [switch]$SkipDocs,
+    [string]$DotnetCli
 )
 
-# Attempts to find the (verified to exist) path to msbuild.exe; returns an empty string if
-# not found.
-function Find-MsBuildPath()
+function Find-DotnetCli()
 {
-    [string] $msbuildPath = ''
-
-    $msbuildCmd = Get-Command -Name msbuild -ErrorAction Ignore
-
-    if ($msbuildCmd) {
-        $msbuildPath = $msbuildCmd.Path
-    } else {
-        Write-Warning 'Searching for msbuild'
-
-        # For more info on vswhere.exe:
-        #    https://blogs.msdn.microsoft.com/heaths/2017/02/25/vswhere-available/
-        #    https://github.com/Microsoft/vswhere/wiki/Find-MSBuild
-        $vswherePath = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe"
-        if (Test-Path $vswherePath) {
-
-            $vsInstallPath = & $vswherePath -latest `
-                                            -requires Microsoft.VisualStudio.Component.Roslyn.Compiler, Microsoft.Component.MSBuild `
-                                            -property installationPath
-
-            if (($LASTEXITCODE -eq 0) -and $vsInstallPath) {
-                $msbuildPath = Join-Path $vsInstallPath 'MSBuild\15.0\Bin\MSBuild.exe'
-            }
-        }
-
-        if ($msbuildPath -and (-not (Test-Path $msbuildPath))) {
-            $msbuildPath = ''
-        }
-    }
-
-    return $msbuildPath
+    [string] $DotnetCli = ''
+    $dotnetCmd = Get-Command dotnet
+    return $dotnetCmd.Path
 }
 
 
-# build .dll
-[string] $msbuildPath = Find-MsBuildPath
-
-if (-not $msbuildPath) {
-    throw "I don't know where msbuild is."
+if (-not $DotnetCli) {
+    $DotnetCli = Find-DotnetCli
 }
 
-if (-not (Get-ChildItem "$PSScriptRoot\packages\*" -ErrorAction Ignore)) {
-    # No packages... better restore or things won't go well.
-
-    $nugetCmd = 'nuget'
-    if (-not (Get-Command -Name $nugetCmd -ErrorAction Ignore)) {
-        $nugetCmd = "$PSScriptRoot\.nuget\NuGet.exe"
-    }
-
-    Write-Host -Foreground Cyan 'Attempting nuget package restore'
-
-    try
-    {
-        Push-Location $PSScriptRoot
+if (-not $DotnetCli) {
+    throw "dotnet cli is not found in PATH, install it from https://docs.microsoft.com/en-us/dotnet/core/tools"
+} else {
+    Write-Host "Using dotnet from $DotnetCli"
+}
 
-        & $nugetCmd restore
-    }
-    finally
-    {
-        Pop-Location
-    }
+if (Get-Variable -Name IsCoreClr -ValueOnly -ErrorAction SilentlyContinue) {
+    $framework = 'netstandard1.6'
+} else {
+    $framework = 'net451'
 }
 
-& $msbuildPath Markdown.MAML.sln /p:Configuration=$Configuration
-$assemblyPaths = ((Resolve-Path "src\Markdown.MAML\bin\$Configuration\Markdown.MAML.dll").Path, (Resolve-Path "src\Markdown.MAML\bin\$Configuration\YamlDotNet.dll").Path)
+& $DotnetCli publish ./src/Markdown.MAML -f $framework --output=$pwd/publish /p:Configuration=$Configuration
+
+$assemblyPaths = (
+    (Resolve-Path "publish/Markdown.MAML.dll").Path,
+    (Resolve-Path "publish/YamlDotNet.dll").Path
+)
 
 # copy artifacts
-mkdir out -ErrorAction SilentlyContinue > $null
-cp -Rec -Force src\platyPS out
+New-Item -Type Directory out -ErrorAction SilentlyContinue > $null
+Copy-Item -Rec -Force src\platyPS out
 foreach($assemblyPath in $assemblyPaths)
 {
 	$assemblyFileName = [System.IO.Path]::GetFileName($assemblyPath)
 	$outputPath = "out\platyPS\$assemblyFileName"
 	if ((-not (Test-Path $outputPath)) -or
-		(Test-Path $outputPath -OlderThan (ls $assemblyPath).LastWriteTime))
+		(Test-Path $outputPath -OlderThan (Get-ChildItem $assemblyPath).LastWriteTime))
 	{
-		cp $assemblyPath out\platyPS
+		Copy-Item $assemblyPath out\platyPS
 	} else {
 		Write-Host -Foreground Yellow "Skip $assemblyFileName copying"
 	}
 }
 
 # copy schema file and docs
-cp .\platyPS.schema.md out\platyPS
-mkdir out\platyPS\docs -ErrorAction SilentlyContinue > $null
-cp .\docs\* out\platyPS\docs\
+Copy-Item .\platyPS.schema.md out\platyPS
+New-Item -Type Directory out\platyPS\docs -ErrorAction SilentlyContinue > $null
+Copy-Item .\docs\* out\platyPS\docs\
 
 # copy template files
-mkdir out\platyPS\templates -ErrorAction SilentlyContinue > $null
-cp .\templates\* out\platyps\templates\
+New-Item -Type Directory out\platyPS\templates -ErrorAction SilentlyContinue > $null
+Copy-Item .\templates\* out\platyPS\templates\
 
 # put the right module version
 if ($env:APPVEYOR_REPO_TAG_NAME)