Fix compilation issue in Rules

Author: Kapil Borle

Rules/AvoidUsingPlainTextForPassword.cs

@@ -47,7 +47,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             // Iterates all ParamAsts and check if their names are on the list.
             foreach (ParameterAst paramAst in paramAsts)
             {
-                TypeInfo paramType = (TypeInfo) paramAst.StaticType;
+                Type paramType = paramAst.StaticType;
                 bool hasPwd = false;
                 String paramName = paramAst.Name.VariablePath.ToString();
 

Rules/UseToExportFieldsInManifest.cs

@@ -16,13 +16,13 @@
 using System.Management.Automation.Language;
 using System.Management.Automation;
 using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
-using System.ComponentModel.Composition;
 #if !CORECLR
 using System.ComponentModel.Composition;
 #endif
 using System.Text.RegularExpressions;
 using System.Diagnostics;
 using System.Text;
+using System.Globalization;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {

Tests/Rules/UseSingularNounsReservedVerbs.tests.ps1

@@ -31,27 +31,27 @@ if (-not (Test-PSEditionCoreCLR))
             $nounViolations[0].Extent.Text | Should be "Verb-Files"
             }
         }
-    }
 
-    Context "When function names have nouns from whitelist" {
+        Context "When function names have nouns from whitelist" {
 
-        It "ignores function name ending with Data" {
-            $nounViolationScript = @'
+            It "ignores function name ending with Data" {
+                $nounViolationScript = @'
 Function Add-SomeData
 {
     Write-Output "Adding some data"
 }
 '@
-            Invoke-ScriptAnalyzer -ScriptDefinition $nounViolationScript `
-                -IncludeRule "PSUseSingularNouns" `
-                -OutVariable violations
-            $violations.Count | Should Be 0
+                Invoke-ScriptAnalyzer -ScriptDefinition $nounViolationScript `
+                    -IncludeRule "PSUseSingularNouns" `
+                    -OutVariable violations
+                $violations.Count | Should Be 0
+            }
         }
-    }
 
-    Context "When there are no violations" {
-        It "returns no violations" {
-            $nounNoViolations.Count | Should Be 0
+        Context "When there are no violations" {
+            It "returns no violations" {
+                $nounNoViolations.Count | Should Be 0
+            }
         }
     }
 }