Optimise LINQ queries (#2160)

* Initial plan

* Optimize LINQ operations for better performance

Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>

* Update Rules/AvoidMultipleTypeAttributes.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Rules/AvoidMultipleTypeAttributes.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

Engine/Generic/RuleSuppression.cs

@@ -340,7 +340,7 @@ public static List<RuleSuppression> GetSuppressions(IEnumerable<AttributeAst> at
 
                     if (targetAsts != null)
                     {
-                        if (targetAsts.Count() == 0)
+                        if (!targetAsts.Any())
                         {
                             if (String.IsNullOrWhiteSpace(scopeAst.Extent.File))
                             {

Engine/ScriptAnalyzer.cs

@@ -267,9 +267,9 @@ internal bool ParseProfile(object profileObject, PathIntrinsics path, IOutputWri
                 return false;
             }
 
-            this.severity = (severityList.Count() == 0) ? null : severityList.ToArray();
-            this.includeRule = (includeRuleList.Count() == 0) ? null : includeRuleList.ToArray();
-            this.excludeRule = (excludeRuleList.Count() == 0) ? null : excludeRuleList.ToArray();
+            this.severity = (severityList.Count == 0) ? null : severityList.ToArray();
+            this.includeRule = (includeRuleList.Count == 0) ? null : includeRuleList.ToArray();
+            this.excludeRule = (excludeRuleList.Count == 0) ? null : excludeRuleList.ToArray();
             if (settings != null
                 && settings.ContainsKey("Rules"))
             {
@@ -609,7 +609,7 @@ private bool ParseProfileString(string profile, PathIntrinsics path, IOutputWrit
                 IEnumerable<Ast> hashTableAsts = profileAst.FindAll(item => item is HashtableAst, false);
 
                 // no hashtable, raise warning
-                if (hashTableAsts.Count() == 0)
+                if (!hashTableAsts.Any())
                 {
                     writer.WriteError(new ErrorRecord(new ArgumentException(string.Format(CultureInfo.CurrentCulture, Strings.InvalidProfile, profile)),
                         Strings.ConfigurationFileHasNoHashTable, ErrorCategory.ResourceUnavailable, profile));

Engine/Settings.cs

@@ -453,7 +453,7 @@ private void parseSettingsFile(string settingsFilePath)
             IEnumerable<Ast> hashTableAsts = profileAst.FindAll(item => item is HashtableAst, false);
 
             // no hashtable, raise warning
-            if (hashTableAsts.Count() == 0)
+            if (!hashTableAsts.Any())
             {
                 throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, Strings.InvalidProfile, settingsFilePath));
             }

Rules/AvoidMultipleTypeAttributes.cs

@@ -37,7 +37,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             // Iterates all ParamAsts and check the number of its types.
             foreach (ParameterAst paramAst in paramAsts)
             {
-                if (paramAst.Attributes.Where(typeAst => typeAst is TypeConstraintAst).Count() > 1)
+                if (paramAst.Attributes.OfType<TypeConstraintAst>().Skip(1).Any())
                 {
                     yield return new DiagnosticRecord(
                         String.Format(CultureInfo.CurrentCulture, Strings.AvoidMultipleTypeAttributesError, paramAst.Name),