Resolve Copilot suggestions and resolved Method not found: ScriptBlockAst.get_UsingStatements() error

Author: iRon7

Rules/AvoidUsingArrayList.cs

@@ -44,7 +44,9 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
             // Otherwise also check for the bare ArrayList name.
             Regex arrayListName = null;
             if (ast is ScriptBlockAst sbAst) {
-                foreach (UsingStatementAst usingAst in sbAst.UsingStatements.Cast<UsingStatementAst>())
+                // sbAst.UsingStatements causes an error: Method not found: ScriptBlockAst.get_UsingStatements()
+                IEnumerable<Ast> usingStatements = usingStatements = sbAst.FindAll(testAst => testAst is UsingStatementAst, false);
+                foreach (UsingStatementAst usingAst in usingStatements.Cast<UsingStatementAst>())
                 {
                     if (
                         usingAst.UsingStatementKind == UsingStatementKind.Namespace &&
@@ -82,12 +84,13 @@ parentAst.Member is StringConstantExpressionAst memberAst &&
 
             foreach (Ast typeAst in typeAsts)
             {
+                IScriptExtent Extent = typeAst is ConvertExpressionAst? typeAst.Extent : typeAst.Parent.Extent;
                 yield return new DiagnosticRecord(
                     string.Format(
                         CultureInfo.CurrentCulture,
                         Strings.AvoidUsingArrayListError,
-                        typeAst.Parent.Extent.Text),
-                    typeAst.Parent.Extent,
+                        Extent.Text),
+                    Extent,
                     GetName(),
                     DiagnosticSeverity.Warning,
                     fileName
@@ -108,9 +111,9 @@ testAst is CommandAst cmdAst &&
 
                 // Check for -TypeName parameter
                 if (
-                    bindingResult.BoundParameters.ContainsKey("TypeName") &&
-                    bindingResult.BoundParameters["TypeName"].ConstantValue != null &&
-                    arrayListName.IsMatch(bindingResult.BoundParameters["TypeName"].ConstantValue as string)
+                    bindingResult.BoundParameters.TryGetValue("TypeName",  out ParameterBindingResult typeNameBinding) &&
+                    typeNameBinding.ConstantValue is string typeName &&
+                    arrayListName.IsMatch(typeName)
                 )
                 {
                     yield return new DiagnosticRecord(

docs/Rules/AvoidUsingArrayList.md

@@ -10,23 +10,23 @@ title: AvoidUsingArrayList
 
 ## Description
 
-Per dotnet best practices, the
-[`ArrayList` class](https://learn.microsoft.com/dotnet/api/system.collections.arraylist)
-is not recommended for new development, the same recommendation applies to PowerShell:
+Per .NET best practices, the [`ArrayList` class][1] is not recommended for new development,
+the same recommendation applies to PowerShell:
 
 Avoid the ArrayList class for new development.
-The `ArrayList` class is a non-generic collection that can hold objects of any type. This is inline with the fact
-that PowerShell is a weakly typed language. However, the `ArrayList` class does not provide any explicit type
-safety and performance benefits of generic collections. Instead of using an `ArrayList`, consider using either a
-[`System.Collections.Generic.List[Object]`](https://learn.microsoft.com/dotnet/api/system.collections.generic.list-1)
-class or a fixed PowerShell array.
-Besides, the `ArrayList.Add` method returns the index of the added element which often unintentionally pollutes the
-PowerShell pipeline and therefore might cause unexpected issues.
+The `ArrayList` class is a non-generic collection that can hold objects of any type.
+This is in line with the fact that PowerShell is a weakly typed language. However, the
+`ArrayList` class does not provide any explicit type safety and performance benefits
+of generic collections. Instead of using an `ArrayList`, consider using either a
+[`System.Collections.Generic.List[Object]`][2] class or a fixed PowerShell array.
+Besides, the `ArrayList.Add` method returns the index of the added element which often
+unintentionally pollutes the PowerShell pipeline and therefore might cause unexpected issues.
 
 ## How to Fix
 
-In cases where only the `Add` method is used, you might just replace the `ArrayList` class with a generic
-`List[Object]` class but you could also consider using the idiomatic PowerShell pipeline syntax instead.
+In cases where only the `Add` method is used, you might just replace the `ArrayList` class
+with a generic `List[Object]` class but you could also consider using the idiomatic PowerShell
+pipeline syntax instead.
 
 ## Example
 
@@ -49,4 +49,13 @@ $List = [System.Collections.Generic.List[Object]]::new()
 ```powershell
 # Creating a fixed array by using the PowerShell pipeline
 $List = 1..3 | ForEach-Object { $_ }
-```
+```
+
+### Parameters
+
+- `Enable`: **bool** (Default value is `$false`)
+
+  Enable or disable the rule during ScriptAnalyzer invocation.
+
+[1]: https://learn.microsoft.com/dotnet/api/system.collections.arraylist "ArrayList Class"
+[2]: https://learn.microsoft.com/dotnet/api/system.collections.generic.list-1 "List<T> Class"