-
Notifications
You must be signed in to change notification settings - Fork 34
Closed
Description
Problem
The migration to pyproject.toml in #3277 deleted setup.py and replaced changelog_entry.yaml with changelog.d/ towncrier fragments. However, gcp/bump_country_package.py — the script called by policyengine-us and policyengine-uk CI to automatically open version-bump PRs — was not updated. It still:
- Reads/writes
setup.py(line 29-43), which no longer exists. This causes aFileNotFoundErrorat runtime. - Writes
changelog_entry.yaml(lines 53-56), which is the deprecated changelog format. The repo now useschangelog.d/fragments. - Has an indentation bug on line 40 where
setup_py.replace(...)is outside theif match:block, which would cause anAttributeErrorif the regex didn't match.
As a result, no automated country-package bump PRs can be created until this is fixed.
Expected fix
- Read/write
pyproject.tomlinstead ofsetup.py - Create a
changelog.d/{branch_name}.changed.mdfragment instead ofchangelog_entry.yaml - Fix the indentation bug so the replace is inside the
if match:block
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels