refactor(tests): simplificar mensagens de exceção para validação de configuração no JsonBufferPool

Author: CAFernandes

src/Json/Pool/JsonBufferPool.php

@@ -191,20 +191,15 @@ public static function getStatistics(): array
         // Sort pools by capacity for better readability
         ksort($poolsByCapacity);
 
-        // Sort pool_sizes by extracting numeric capacity for consistent ordering
-        uksort(
-            $poolSizes,
-            function ($a, $b) {
-            // Extract numeric capacity from formatted strings like "1.0KB (1024 bytes)"
-                preg_match('/\((\d+) bytes\)/', $a, $matchesA);
-                preg_match('/\((\d+) bytes\)/', $b, $matchesB);
-
-                $capacityA = isset($matchesA[1]) ? (int)$matchesA[1] : 0;
-                $capacityB = isset($matchesB[1]) ? (int)$matchesB[1] : 0;
-
-                return $capacityA <=> $capacityB;
+        // Sort pool_sizes based on numeric capacities from poolsByCapacity
+        $sortedPoolSizes = [];
+        foreach (array_keys($poolsByCapacity) as $capacity) {
+            $readableKey = $poolsByCapacity[$capacity]['capacity_formatted'];
+            if (isset($poolSizes[$readableKey])) {
+                $sortedPoolSizes[$readableKey] = $poolSizes[$readableKey];
             }
-        );
+        }
+        $poolSizes = $sortedPoolSizes;
 
         return [
             'reuse_rate' => round($reuseRate, 2),
@@ -281,11 +276,12 @@ private static function validateConfiguration(array $config): void
     {
         // Validate 'max_pool_size'
         if (isset($config['max_pool_size'])) {
+            // First check type
             if (!is_int($config['max_pool_size'])) {
-                throw new \InvalidArgumentException(
-                    "'max_pool_size' must be an integer, got: " . gettype($config['max_pool_size'])
-                );
+                throw new \InvalidArgumentException("'max_pool_size' must be an integer");
             }
+
+            // Then check range
             if ($config['max_pool_size'] <= 0) {
                 throw new \InvalidArgumentException("'max_pool_size' must be a positive integer");
             }
@@ -298,11 +294,12 @@ private static function validateConfiguration(array $config): void
 
         // Validate 'default_capacity'
         if (isset($config['default_capacity'])) {
+            // First check type
             if (!is_int($config['default_capacity'])) {
-                throw new \InvalidArgumentException(
-                    "'default_capacity' must be an integer, got: " . gettype($config['default_capacity'])
-                );
+                throw new \InvalidArgumentException("'default_capacity' must be an integer");
             }
+
+            // Then check range
             if ($config['default_capacity'] <= 0) {
                 throw new \InvalidArgumentException("'default_capacity' must be a positive integer");
             }
@@ -315,10 +312,9 @@ private static function validateConfiguration(array $config): void
 
         // Validate 'size_categories'
         if (isset($config['size_categories'])) {
+            // First check type
             if (!is_array($config['size_categories'])) {
-                throw new \InvalidArgumentException(
-                    "'size_categories' must be an array, got: " . gettype($config['size_categories'])
-                );
+                throw new \InvalidArgumentException("'size_categories' must be an array");
             }
 
             if (empty($config['size_categories'])) {
@@ -330,11 +326,14 @@ private static function validateConfiguration(array $config): void
                     throw new \InvalidArgumentException("Size category names must be non-empty strings");
                 }
 
+                // First check type for each capacity
                 if (!is_int($capacity)) {
                     throw new \InvalidArgumentException(
-                        "Size category '{$name}' must have an integer capacity, got: " . gettype($capacity)
+                        "Size category '{$name}' must have an integer capacity"
                     );
                 }
+
+                // Then check range
                 if ($capacity <= 0) {
                     throw new \InvalidArgumentException(
                         "Size category '{$name}' must have a positive integer capacity"

tests/Json/Pool/JsonBufferPoolConfigValidationTest.php

@@ -69,7 +69,7 @@ public function testMaxPoolSizeZeroInvalid(): void
     public function testMaxPoolSizeTypeValidation(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage("'max_pool_size' must be an integer, got: string");
+        $this->expectExceptionMessage("'max_pool_size' must be an integer");
         JsonBufferPool::configure(['max_pool_size' => '100']);
     }
 
@@ -93,7 +93,7 @@ public function testDefaultCapacityValidation(): void
     public function testDefaultCapacityTypeValidation(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage("'default_capacity' must be an integer, got: double");
+        $this->expectExceptionMessage("'default_capacity' must be an integer");
         JsonBufferPool::configure(['default_capacity' => 4096.5]);
     }
 
@@ -110,7 +110,7 @@ public function testDefaultCapacityUpperLimit(): void
     public function testSizeCategoriesTypeValidation(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage("'size_categories' must be an array, got: string");
+        $this->expectExceptionMessage("'size_categories' must be an array");
         JsonBufferPool::configure(['size_categories' => 'invalid']);
     }
 
@@ -150,7 +150,7 @@ public function testSizeCategoriesEmptyNameInvalid(): void
     public function testSizeCategoriesCapacityValidation(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage("Size category 'small' must have an integer capacity, got: string");
+        $this->expectExceptionMessage("Size category 'small' must have an integer capacity");
         JsonBufferPool::configure(
             [
                 'size_categories' => [