Skip to content

Commit 6b08e38

Browse files
committed
Address Codex review: pin rust-toolchain from master, fix fail-on-finding default
dtolnay/rust-toolchain's convenience branches (stable/beta/nightly) get rewritten over time, so a commit pinned there can become unreachable; the upstream guidance is to pin a `master` commit and pass the channel via an explicit `toolchain:` input instead. docs/suppression-and-fp-policy.md had the Action's fail-on-finding default backwards: action.yml sets it to "true" (fails on a finding by default), not "false" -- the CLI (own-check.sh) is the one that defaults to off. Corrected and clarified the CLI-vs-Action distinction.
1 parent bd935b1 commit 6b08e38

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ jobs:
5959
working-directory: rust
6060
steps:
6161
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
62-
- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable, 2026-07-09
62+
- uses: dtolnay/rust-toolchain@fa04a1451ff1842e2626ccb99004d0195b455a88 # master, 2026-07-10
6363
with:
64+
toolchain: stable
6465
components: rustfmt, clippy
6566
- name: cargo fmt --check
6667
run: cargo fmt --check

docs/suppression-and-fp-policy.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ fire on unprovable input.
4444
| Lever | Status | Scope |
4545
|---|---|---|
4646
| `--severity warning` | **works today** (P-013) | Global: downgrades every error-tier finding for that run to advisory. Per-run, not per-finding — an escape hatch for "show me everything, but don't fail the build yet," not a way to silence one specific site. |
47-
| `--fail-on-finding` (off) | **works today** (P-013, the GitHub Action's default input) | Global: findings still print/annotate, but the process/step exit code stays 0. |
47+
| `--fail-on-finding` set to off | **works today** (P-013) | Global: findings still print/annotate, but the process/step exit code stays 0. The CLI (`own-check.sh`) is off by default — you must pass the flag to make findings fail the shell. The GitHub Action inverts that for safety: its `fail-on-finding` input defaults to `"true"` (fails the step on a finding), so to get the "annotate but don't fail" behavior in CI you must explicitly set `fail-on-finding: "false"`. |
4848
| `[OwnIgnore("reason")]` | **designed, not implemented** (P-004) | Inline, per-site suppression attribute — the intended fine-grained escape hatch for a specific subscription/field the checker can't see enough context to clear. Referenced across P-001/P-004/P-010/P-014/P-017 as the standing design; there is no code behind it yet. If you need this today, the honest answer is: you don't have it — file the case so it informs the implementation. |
4949
| Project-wide config (`.ownrc`/`own.toml`) | **draft, not implemented** (P-015) | Per-check-category enable/disable + severity + per-path overrides (e.g. relax a category under `tests/`). Stub status — format (TOML vs INI vs JSON) and enforcement point are still open questions in the proposal. |
5050
| `corpus/oracle-fp-baseline.txt` | **exists, but not a user-facing suppression tool** | An allowlist the *oracle comparator* (`scripts/oracle_compare.py`, a dev/maintainer tool) uses to keep already-triaged false positives out of the `own-only` bucket on re-runs. It doesn't change what `own-check`/the Action reports — it only keeps the oracle's own triage queue from re-showing confirmed noise. |

0 commit comments

Comments
 (0)