get 100% test coverage for useScript

Author: Philipp Molitor

src/hooks/__tests__/useScript.test.tsx

@@ -151,6 +151,24 @@ describe('useScript()', () => {
     expect(element).toBeInTheDocument();
   });
 
+  it('adds the <script> tag again when setting a source again', async () => {
+    const { result } = renderHook(() => useScript());
+
+    const element = document.querySelector('script') as HTMLScriptElement;
+
+    expect(element).not.toBeInTheDocument();
+
+    act(() => {
+      result.current[1](scriptUrl);
+    });
+
+    const newElement = document.querySelector(
+      `script[src="${scriptUrl}"]`
+    ) as HTMLScriptElement;
+
+    expect(newElement).toBeInTheDocument();
+  });
+
   it('removes the <script> tag when setting the source to undefined', async () => {
     const { result } = renderHook(() => useScript(scriptUrl));
 

src/hooks/useScript.ts

@@ -25,11 +25,8 @@ export const useScript = (src?: string): UseScriptValue => {
 
     if (!source) {
       setScriptState('unloaded');
-      return;
-    }
-
-    // if script is not in DOM yet, add it
-    if (source && !script) {
+    } else if (source && !script) {
+      // if script is not in DOM yet, add it
       script = document.createElement('script');
       script.src = source;
       script.async = true;
@@ -50,8 +47,7 @@ export const useScript = (src?: string): UseScriptValue => {
       document.body.appendChild(script);
     }
 
-    // eslint-disable-next-line consistent-return
-    return () => {
+    return (): void => {
       if (script) script.remove();
     };
   }, [source]);