Skip to content

Commit 20810b9

Browse files
RedMan13RedMan13
committed
third and final editor pass
3. give translation keys to all inline text
1 parent f5af1df commit 20810b9

File tree

6 files changed

+69
-29
lines changed

6 files changed

+69
-29
lines changed

‎src/components/library-item/library-item.jsx‎

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,11 @@ class LibraryItemComponent extends React.PureComponent {
258258
{this.props.twDeveloper ? (
259259
<div className={styles.smallBottomMargin}>
260260
<div>
261-
Originally for TurboWarp by
261+
<FormattedMessage
262+
defaultMessage="Originally for TurboWarp by"
263+
description="Text for crediting that an extension was originally made for turbowarp, and who has made it."
264+
id="pm.libraryItem.turbowarpDeveloperCredits"
265+
/>
262266
</div>
263267
<div
264268
className={styles.featuredExtensionMetadataDetail}
@@ -270,7 +274,11 @@ class LibraryItemComponent extends React.PureComponent {
270274
{this.props.extDeveloper ? (
271275
<div className={styles.smallBottomMargin}>
272276
<div>
273-
Created by
277+
<FormattedMessage
278+
defaultMessage="created by"
279+
description="Text for crediting an extensions creator."
280+
id="pm.libraryItem.extensionCredits"
281+
/>
274282
</div>
275283
<div
276284
className={styles.featuredExtensionMetadataDetail}
@@ -282,7 +290,11 @@ class LibraryItemComponent extends React.PureComponent {
282290
{this.props.eventSubmittor ? (
283291
<div className={styles.smallBottomMargin}>
284292
<div>
285-
Event Submission by
293+
<FormattedMessage
294+
defaultMessage="event submission by"
295+
description="Text for crediting who made a submission for an event."
296+
id="pm.libraryItem.eventSubmissionCredits"
297+
/>
286298
</div>
287299
<div
288300
className={styles.featuredExtensionMetadataDetail}
@@ -294,7 +306,11 @@ class LibraryItemComponent extends React.PureComponent {
294306
{this.props.credits ? (
295307
<div className={styles.smallBottomMargin}>
296308
<div>
297-
Credits
309+
<FormattedMessage
310+
defaultMessage="Credits"
311+
description="Text for put credits onto a library item."
312+
id="pm.libraryItem.generalCredits"
313+
/>
298314
</div>
299315
<div
300316
className={styles.featuredExtensionMetadataDetail}
@@ -339,7 +355,11 @@ class LibraryItemComponent extends React.PureComponent {
339355
>
340356
{this.props.isNew && (
341357
<div className={styles.libraryItemNewBadge}>
342-
NEW
358+
<FormattedMessage
359+
defaultMessage="NEW"
360+
description="Badge text for new library items"
361+
id="pm.libraryItem.newItemBadge"
362+
/>
343363
</div>
344364
)}
345365
{/* Layers of wrapping is to prevent layout thrashing on animation */}

‎src/components/library/library.jsx‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import bindAll from 'lodash.bindall';
33
import PropTypes from 'prop-types';
44
import React from 'react';
55
import localforage from 'localforage';
6-
import {defineMessages, injectIntl, intlShape} from 'react-intl';
6+
import {defineMessages, injectIntl, intlShape, FormattedMessage } from 'react-intl';
77

88
import LibraryItem from '../../containers/library-item.jsx';
99
import Modal from '../../containers/modal.jsx';
@@ -313,9 +313,6 @@ class LibraryComponent extends React.Component {
313313
id={this.props.id}
314314
onRequestClose={this.handleClose}
315315
>
316-
{/*
317-
todo: translation support?
318-
*/}
319316
{this.props.header ? (
320317
<h1
321318
className={classNames(
@@ -346,23 +343,26 @@ class LibraryComponent extends React.Component {
346343
className={classNames(styles.libraryFilterBar)}
347344
style={this.state.collapsed ? { display: "none" } : null}
348345
>
349-
{/*
350-
todo: translation?
351-
*/}
352-
<h3 className={classNames(styles.whiteTextInDarkMode)}>Filters</h3>
346+
<h3 className={classNames(styles.whiteTextInDarkMode)}>
347+
<FormattedMessage
348+
defaultMessage="Filters"
349+
description="Header text for the filter controls in the asset picker"
350+
id="pm.library.filtersHeader"
351+
/>
352+
</h3>
353353
{this.props.filterable && (
354354
<div>
355-
<Filter
356-
className={classNames(
357-
styles.filterBarItem,
358-
styles.filter
359-
)}
360-
filterQuery={this.state.filterQuery}
361-
inputClassName={styles.filterInput}
362-
placeholderText={this.props.intl.formatMessage(messages.filterPlaceholder)}
363-
onChange={this.handleFilterChange}
364-
onClear={this.handleFilterClear}
365-
/>
355+
<Filter
356+
className={classNames(
357+
styles.filterBarItem,
358+
styles.filter
359+
)}
360+
filterQuery={this.state.filterQuery}
361+
inputClassName={styles.filterInput}
362+
placeholderText={this.props.intl.formatMessage(messages.filterPlaceholder)}
363+
onChange={this.handleFilterChange}
364+
onClear={this.handleFilterClear}
365+
/>
366366
<Divider className={classNames(styles.filterBarItem, styles.divider)} />
367367
</div>
368368
)}

‎src/components/menu-bar/menu-bar.jsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,11 @@ class MenuBar extends React.Component {
856856
/>
857857
</MenuItem>
858858
<MenuItem onClick={this.handleClickDownloadLogs}>
859-
Download Logs
859+
<FormattedMessage
860+
defaultMessage="Download Logs"
861+
description="Menu bar button to download all logs stored by the browser."
862+
id="pm.menuBar.downloadLogs"
863+
/>
860864
</MenuItem>
861865
</MenuSection>
862866
</MenuBarMenu>

‎src/components/prompt/prompt.jsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const messages = defineMessages({
3939
}
4040
});
4141

42-
const customButtonStyle = (button) => {
42+
const customButtonStyle = button => {
4343
// if class is manually specified, dont try to guess the intended style
4444
if (button.class) {
4545
switch (button.class) {

‎src/components/tw-restore-point-modal/restore-point.jsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,11 @@ class RestorePoint extends React.Component {
136136
className={styles.exportButton}
137137
onClick={this.handleClickExport}
138138
>
139-
Export
139+
<FormattedMessage
140+
defaultMessage="Export"
141+
description="Button to export a restorepoint directly fromt he list of restore points"
142+
id="pm.restorePoints.exportRestorePoint"
143+
/>
140144
</button>
141145
</div>
142146
</div>

‎src/components/variables-tab/variables-tab.jsx‎

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,25 @@ class VariablesTab extends React.Component {
8888
/>
8989

9090
{filteredLocal.length > 0 && <div>
91-
<span className={styles.heading}>Variables for this sprite</span>
91+
<span className={styles.heading}>
92+
<FormattedMessage
93+
defaultMessage="For this sprite only"
94+
description="Text for the section of variables that are for only this sprite"
95+
id="pm.variablesTab.forThisSpriteOnly"
96+
/>
97+
</span>
9298
<table>
9399
{filteredLocal.map(this.renderVariable)}
94100
</table>
95101
</div>}
96102
{filteredGlobal.length > 0 && <div>
97-
<span className={styles.heading}>Variables for all sprites</span>
103+
<span className={styles.heading}>
104+
<FormattedMessage
105+
defaultMessage="Variables for all sprites"
106+
description="Text for the section of variables that are for all sprites to use"
107+
id="pm.variablesTab.forAllSprites"
108+
/>
109+
</span>
98110
<table>
99111
{filteredGlobal.map(this.renderVariable)}
100112
</table>

0 commit comments

Comments
 (0)