Skip to content

Commit e994cde

Browse files
Merge pull request #143 from JingyuanZhang/master
fix(core): update texturepacking transform about inputName
2 parents bde871f + cb4285e commit e994cde

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

packages/paddlejs-core/src/transform/splitOp.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,17 @@
33
*/
44

55
import Transformer from './transformer';
6+
67
function getTensorShapeFromVals(name, vars) {
7-
const result = vars.filter(item => item.name === name);
8-
return result.length ? result[0].shape : []
8+
const result = vars.filter(item => item.name === name);
9+
return result.length ? result[0].shape : [];
910
}
1011

1112
function buildOutputVarInfo(inputs, outputShape, axis, vars) {
1213
// calculate shape
1314
const shape = [...outputShape];
1415
let shapeSum = 0;
15-
for (let input of inputs) {
16+
for (const input of inputs) {
1617
const curShape = getTensorShapeFromVals(input, vars);
1718
shapeSum += curShape[axis];
1819
}
@@ -58,7 +59,7 @@ export default class SplitOp extends Transformer {
5859

5960
const varList = [];
6061
const opList = [];
61-
let firstOpInputs = inputs.slice(0, 4);
62+
const firstOpInputs = inputs.slice(0, 4);
6263
let prevVar;
6364

6465
for (let i = 0; i < opLen; i++) {
@@ -68,14 +69,13 @@ export default class SplitOp extends Transformer {
6869
: inputs.slice(i * 3 + 1, (i + 1) * 3 + 1);
6970

7071
const outputVar = buildOutputVarInfo(curOpInputs, outputShape, axis, vars);
71-
console.log(outputVar.name)
7272

7373
// concat prev op info
7474
i !== 0 && curOpInputs.splice(0, 0, prevVar.name);
7575
outputVar.shape[axis] += prevVar ? prevVar.shape[axis] : 0;
7676

77-
const outputs = {Out: [outputVar.name]};
78-
opList.push({attrs, inputs: {X: curOpInputs}, outputs, type: 'concat'});
77+
const outputs = { Out: [outputVar.name] };
78+
opList.push({ attrs, inputs: { X: curOpInputs }, outputs, type: 'concat' });
7979
varList.push(outputVar);
8080
prevVar = outputVar;
8181
}

packages/paddlejs-core/src/transform/texturePacking.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,14 @@ export default class TexturePacking extends Transformer {
114114
}
115115

116116
const {
117-
inputsName,
118-
outputsName
117+
inputs,
118+
outputs
119119
} = originOp;
120+
const connectInputName = inputs.Input[0];
121+
const connectOutputName = outputs.Output[0];
120122
const unpacked2packedOp = createUnpacked2packedOp({
121-
inputName: inputsName[0],
122-
outputName: `${inputsName[0]}_packed`
123+
inputName: connectInputName,
124+
outputName: `${connectInputName}_packed`
123125
});
124126
const unpacked2packedOpIdx = opsMap.length;
125127
opsMap.push(new OpExecutor(unpacked2packedOp, unpacked2packedOpIdx));
@@ -129,8 +131,8 @@ export default class TexturePacking extends Transformer {
129131

130132
// deal with packed2unpacked op
131133
const packed2unpackedOp = createPacked2unpackedOp({
132-
inputName: `${outputsName[0]}_packed`,
133-
outputName: outputsName[0]
134+
inputName: `${connectOutputName}_packed`,
135+
outputName: connectOutputName
134136
});
135137
const packed2unpackedOpIdx = opsMap.length + 1;
136138
opsMap.push(new OpExecutor(packed2unpackedOp, packed2unpackedOpIdx));

0 commit comments

Comments
 (0)