keep FIXME comment

BSnelling · BSnelling · commit ef86844fa7d0 · 2026-06-22T14:20:43.000+01:00
diff --git a/petab/v2/lint.py b/petab/v2/lint.py
@@ -1010,6 +1010,9 @@ def get_valid_parameters_for_parameter_table(
     )
 
     # Add petab ids from mapping table if they are used for aliasing
+    # FIXME only add mapping.petab_id to allowed parameter IDs list if it
+    #       aliases an invalid PEtab ID? See
+    #       https://github.com/PEtab-dev/libpetab-python/pull/482#discussion_r3420762034
     for mapping in problem.mappings:
         if mapping.petab_id not in invalid:
             parameter_ids[mapping.petab_id] = None

Original file line number	Diff line number	Diff line change
`@@ -1010,6 +1010,9 @@ def get_valid_parameters_for_parameter_table(`
`1010`	`1010`	`)`
`1011`	`1011`
`1012`	`1012`	`# Add petab ids from mapping table if they are used for aliasing`
	`1013`	`+ # FIXME only add mapping.petab_id to allowed parameter IDs list if it`
	`1014`	`+ # aliases an invalid PEtab ID? See`
	`1015`	`+ # https://github.com/PEtab-dev/libpetab-python/pull/482#discussion_r3420762034`
`1013`	`1016`	`for mapping in problem.mappings:`
`1014`	`1017`	`if mapping.petab_id not in invalid:`
`1015`	`1018`	`parameter_ids[mapping.petab_id] = None`