Remove explicit version from composer.json #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer/packagist will parse the git tag and use this as version. Defining the same here requires careful management, which is not currently being done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare https://github.com/PCAPredict/magento2/tags with https://packagist.org/packages/pcapredict/tag and note that v2.1.0 exists in the former but not the latter.
Packagist.org will parse the git tag and use this as version. As git tag
v2.1.0claims to also be version2.0.9(see https://github.com/PCAPredict/magento2/blob/v2.1.0/composer.json#L22), this version is not recognised by packagist. Removing the version string fromcomposer.jsonwill avoid this problem going forward.Update: versions
2.0.9and2.0.9.1are also unavailable for the same reason as stated above.Fixes: #33
Fixes: #36
Replaces: #37