Skip to content
This repository was archived by the owner on Jul 20, 2020. It is now read-only.
This repository was archived by the owner on Jul 20, 2020. It is now read-only.

Hooked items are converted to fish #33

@Marcono1234

Description

@Marcono1234

The bug

Based on the fix of MC-101001 you can now hook item entities and reel them in. The problem is that PGMListener.nerfFishing(PlayerFishEvent) converts any item entity even if it is hooked and not catched and therefore existed in the world before. This allows for example to "destroy" wool in the enemy's wool room.

The method should probably only convert the item if the state is PlayerFishEvent.State.CAUGHT_FISH.

However, to make sure a team cannot reel in the enemies wool maybe add a listener for a ProjectileHitEvent and then either prevent pulling items completely or prevent it for certain items like wool.

How to reproduce

This can be currently seen on play.stratus.network (but not on the mapdev server) since the treasure fishing loot is disabled there.

  1. Get a fishing rod (this is for example possible in "Persisto")
  2. Throw an item on the ground
  3. Cast the fishing rod at the item
  4. Try to reel in the item

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions