From 1d33b3abb59583a5392f3c42473377cad9f7f150 Mon Sep 17 00:00:00 2001
From: Mathis Brossier <mathis.brossier@gmail.com>
Date: Tue, 7 Oct 2025 14:39:01 +0200
Subject: [PATCH] setProperty returns a promise, like getProperty

---
 declaration/openspace-api-js.d.ts |  2 +-
 script/openspace-api-static.txt   |  2 +-
 src/api.js                        | 36 +++++++++++++++++++------------
 3 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/declaration/openspace-api-js.d.ts b/declaration/openspace-api-js.d.ts
index f775a6e..8b68b9f 100644
--- a/declaration/openspace-api-js.d.ts
+++ b/declaration/openspace-api-js.d.ts
@@ -77,7 +77,7 @@ declare module 'openspace-api-js' {
      * @param property The URI of the property to set.
      * @param value - The value to set the property to.
      */
-    setProperty(property: string, value: unknown): void;
+    setProperty(property: string, value: unknown): Promise<void>;
 
     /**
      * Get a property
diff --git a/script/openspace-api-static.txt b/script/openspace-api-static.txt
index 755d00c..915a729 100644
--- a/script/openspace-api-static.txt
+++ b/script/openspace-api-static.txt
@@ -77,7 +77,7 @@ declare module 'openspace-api-js' {
      * @param property The URI of the property to set.
      * @param value - The value to set the property to.
      */
-    setProperty(property: string, value: unknown): void;
+    setProperty(property: string, value: unknown): Promise<void>;
 
     /**
      * Get a property
diff --git a/src/api.js b/src/api.js
index 15541da..d72662a 100644
--- a/src/api.js
+++ b/src/api.js
@@ -65,7 +65,7 @@ class OpenSpaceApi {
    */
   startTopic(type, payload) {
     if (typeof type !== 'string') {
-      throw("Topic type must be a string")
+      throw "Topic type must be a string";
     }
 
     const topic = this._nextTopicId++;
@@ -132,17 +132,25 @@ class OpenSpaceApi {
    * @param {string} property - The URI of the property to set.
    * @param {*} value - The value to set the property to.
    */
-  setProperty(property, value) {
+  async setProperty(property, value) {
     if (typeof property !== 'string') {
-      throw("Property must be a valid uri string")
+      throw "Property must be a valid uri string";
     }
     const topic = this.startTopic('set', {
-       property,
-       value
-     });
-     topic.cancel();
+      property,
+      value,
+    });
+    try {
+      const response = await topic.iterator().next();
+      topic.cancel();
+      return response.value;
+    } catch (e) {
+      throw "Error setting property. \n" + e;
+    }
   }
 
+
+
   /**
    * Get a property
    * @param {string} property - The URI of the property to set.
@@ -150,7 +158,7 @@ class OpenSpaceApi {
    */
   async getProperty(property) {
     if (typeof property !== 'string') {
-      throw("Property must be a valid uri string")
+      throw "Property must be a valid uri string";
     }
     const topic = this.startTopic('get', {
       property,
@@ -193,7 +201,7 @@ class OpenSpaceApi {
    */
   subscribeToProperty(property) {
     if (typeof property !== 'string') {
-      throw("Property must be a valid uri string")
+      throw "Property must be a valid uri string";
     }
     const topic = this.startTopic('subscribe', {
       event: 'start_subscription',
@@ -221,7 +229,7 @@ class OpenSpaceApi {
    */
   async executeLuaScript(script, getReturnValue = true, shouldBeSynchronized = true) {
     if (typeof script !== 'string') {
-      throw("Script must be a string")
+      throw "Script must be a string";
     }
     const topic = this.startTopic('luascript', {
       script,
@@ -250,7 +258,7 @@ class OpenSpaceApi {
    */
   async executeLuaFunction(fun, args, getReturnValue = true) {
     if (typeof fun !== 'string') {
-      throw("Function must be a string")
+      throw "Function must be a string";
     }
     const topic = this.startTopic('luascript', {
       function: fun,
@@ -264,7 +272,7 @@ class OpenSpaceApi {
         topic.cancel();
         return response.value;
       } catch (e) {
-        throw "Error executing lua function: \n" + e
+        throw "Error executing lua function: \n" + e;
       }
     } else {
       topic.cancel();
@@ -287,7 +295,7 @@ class OpenSpaceApi {
         try {
           return await this.executeLuaFunction(functionName, args);
         } catch (e) {
-          throw "Lua execution error: \n" + e
+          throw "Lua execution error: \n" + e;
         }
       }
     };
@@ -301,7 +309,7 @@ class OpenSpaceApi {
           }
           return null;
         } catch (e) {
-          throw "Lua execution error: \n" + e
+          throw "Lua execution error: \n" + e;
         }
       }
     };