From 7d588c6c0944ab7c9a2f751d16f81a2acf0a2f85 Mon Sep 17 00:00:00 2001 From: Fabian Pfeuffer Date: Mon, 18 Mar 2024 09:38:38 +0100 Subject: [PATCH 1/4] Improve omit_static_information field description Signed-off-by: Fabian Pfeuffer --- osi_sensorviewconfiguration.proto | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/osi_sensorviewconfiguration.proto b/osi_sensorviewconfiguration.proto index 4601d1bc6..1764cbb1b 100644 --- a/osi_sensorviewconfiguration.proto +++ b/osi_sensorviewconfiguration.proto @@ -201,10 +201,15 @@ message SensorViewConfiguration // Omit Static Information // // This flag specifies whether \c GroundTruth information that - // was already provided using a GroundTruthInit parameter + // was already provided using a + // OMSP GroundTruthInit parameter // at initialization time shall be omitted from the \c SensorView // ground truth information. // + // Setting the \c #omit_static_information field allows a clear split between the dynamic + // simulation data, which is contained by ground truth messages with the \c #omit_static_information + // flag, and the static simulation data, which is contained in the OSMP GroundTruthInit. + // optional bool omit_static_information = 11; // Generic Sensor View Configuration(s). From ffc2e8cb651f612b93e22a3d8dd4b0b452fea726 Mon Sep 17 00:00:00 2001 From: Fabian Pfeuffer Date: Thu, 21 Mar 2024 09:40:19 +0100 Subject: [PATCH 2/4] Fixed minor spelling mistake Signed-off-by: Fabian Pfeuffer --- osi_sensorviewconfiguration.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osi_sensorviewconfiguration.proto b/osi_sensorviewconfiguration.proto index 1764cbb1b..df6e3f0f7 100644 --- a/osi_sensorviewconfiguration.proto +++ b/osi_sensorviewconfiguration.proto @@ -202,7 +202,7 @@ message SensorViewConfiguration // // This flag specifies whether \c GroundTruth information that // was already provided using a - // OMSP GroundTruthInit parameter + // OSMP GroundTruthInit parameter // at initialization time shall be omitted from the \c SensorView // ground truth information. // From ce85f1124539a7040f4489e8ad89513403583dd8 Mon Sep 17 00:00:00 2001 From: Thomas Sedlmayer Date: Fri, 22 Mar 2024 13:47:03 +0100 Subject: [PATCH 3/4] Mark OSMP as example for ground truth init Signed-off-by: Thomas Sedlmayer --- osi_sensorviewconfiguration.proto | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/osi_sensorviewconfiguration.proto b/osi_sensorviewconfiguration.proto index df6e3f0f7..fe5b46869 100644 --- a/osi_sensorviewconfiguration.proto +++ b/osi_sensorviewconfiguration.proto @@ -201,14 +201,14 @@ message SensorViewConfiguration // Omit Static Information // // This flag specifies whether \c GroundTruth information that - // was already provided using a - // OSMP GroundTruthInit parameter + // was already provided using a GroundTruthInit parameter (e.g. OSMP GroundTruthInit) // at initialization time shall be omitted from the \c SensorView // ground truth information. // - // Setting the \c #omit_static_information field allows a clear split between the dynamic - // simulation data, which is contained by ground truth messages with the \c #omit_static_information - // flag, and the static simulation data, which is contained in the OSMP GroundTruthInit. + // Setting the \c #omit_static_information field allows a clear split + // between the dynamic simulation data, which is contained by ground truth + // messages with the \c #omit_static_information flag, and the static + // simulation data, which is contained in the (OSMP) GroundTruthInit. // optional bool omit_static_information = 11; From 8f999532dc6e7d99d5401b1c3a183b9273f6bfdc Mon Sep 17 00:00:00 2001 From: "Pierre R. Mai" Date: Fri, 22 Mar 2024 16:31:43 +0100 Subject: [PATCH 4/4] Grammar fix from review Signed-off-by: Pierre R. Mai --- osi_sensorviewconfiguration.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osi_sensorviewconfiguration.proto b/osi_sensorviewconfiguration.proto index fe5b46869..48bfd8f8c 100644 --- a/osi_sensorviewconfiguration.proto +++ b/osi_sensorviewconfiguration.proto @@ -206,7 +206,7 @@ message SensorViewConfiguration // ground truth information. // // Setting the \c #omit_static_information field allows a clear split - // between the dynamic simulation data, which is contained by ground truth + // between the dynamic simulation data, which is contained in ground truth // messages with the \c #omit_static_information flag, and the static // simulation data, which is contained in the (OSMP) GroundTruthInit. //