Skip to content

Commit 885b23e

Browse files
committed
Add missing base to DetectedTrafficSign
1 parent 4a3bfd6 commit 885b23e

File tree

2 files changed

+31
-4
lines changed

2 files changed

+31
-4
lines changed

osi_detectedlandmark.proto

Lines changed: 31 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,29 @@ message DetectedTrafficSign
3939
//
4040
repeated CandidateMainSign candidate = 1;
4141

42+
// The base parameters of the traffic sign.
43+
//
44+
// The orientation of the bounding box \c #base
45+
// ( \c BaseStationary::orientation ) is defined as follows:
46+
// The z-axis of the given \c BaseStationary::orientation is the vector
47+
// from the bottom to the top of the traffic sign's 2D image plate.
48+
// (Normally it is equal to the ground truth z-axis.)
49+
// The x-axis of the given \c BaseStationary::orientation is view
50+
// normal of the traffic sign's image.
51+
// This x-axis points from the traffic sign's image in the direction from
52+
// where a 'viewer' could see the traffic sign image.
53+
//
54+
optional BaseStationary base = 2;
55+
4256
// The root mean squared error of the base parameters of the detected
4357
// traffic sign. \c TrafficSign::MainSign::base has to be identical for
4458
// all \c #candidate traffic signs.
4559
//
46-
optional BaseStationary base_rmse = 2;
60+
optional BaseStationary base_rmse = 3;
4761

4862
// The estimated geometry of the traffic sign.
4963
//
50-
optional Geometry geometry = 3;
64+
optional Geometry geometry = 4;
5165

5266
//
5367
// \brief A candidate for a detected main sign as estimated by the
@@ -148,12 +162,26 @@ message DetectedTrafficSign
148162
//
149163
repeated CandidateSupplementarySign candidate = 1;
150164

165+
// The base parameters of the supplementary traffic sign.
166+
//
167+
// The orientation of the bounding box \c SupplementarySign::base
168+
// ( \c BaseStationary::orientation ) is defined as follows:
169+
// The z-axis of the given \c BaseStationary::orientation is the vector
170+
// from the bottom to the top of the supplementary traffic sign's 2D image
171+
// plate. (Normally it is equal to the ground truth z-axis.)
172+
// The x-axis of the given \c BaseStationary::orientation is view
173+
// normal of the supplementary traffic sign's image.
174+
// This x-axis points from the supplementary traffic sign's image in the
175+
// direction from where a 'viewer' could see the supplementary traffic sign image.
176+
//
177+
optional BaseStationary base = 2;
178+
151179
// The root mean squared error of the base parameters of the detected
152180
// supplementary traffic sign. \c #candidate
153181
// \c TrafficSign::SupplementarySign::base has to be identical for all
154182
// \c #candidate supplementary traffic signs.
155183
//
156-
optional BaseStationary base_rmse = 2;
184+
optional BaseStationary base_rmse = 3;
157185

158186
//
159187
// \brief A candidate for a detected supplementary sign as estimated by

osi_landmark.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,6 @@ message TrafficSign
831831
//
832832
optional BaseStationary base = 1;
833833

834-
835834
// The classification of the supplementary traffic sign.
836835
//
837836
optional Classification classification = 2;

0 commit comments

Comments
 (0)