Skip to content

Commit 542a5af

Browse files
Typos in Documentation
Typos removed. Add plural s for repeated message fields Add \c in documentation.
1 parent 3e4930f commit 542a5af

File tree

5 files changed

+53
-35
lines changed

5 files changed

+53
-35
lines changed

osi_common.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ message MountingPosition
194194
//
195195
// Azimuth and elevation are defined as the rotations that would have to be
196196
// applied to the local frame (e.g sensor frame definition in
197-
// \c DetectionHeader) to make its x-axis point towards the referenced point
197+
// \c SensorDetectionHeader) to make its x-axis point towards the referenced point
198198
// or to align it with the referenced vector. The rotations are to be performed
199199
// \b azimuth \b first (around the z-axis) and \b elevation \b second (around
200200
// the new y-axis) to follow the definition of \c Orientation3D. For the

osi_datarecording.proto

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,33 +7,36 @@ import "osi_sensordata.proto";
77
package osi;
88

99
//
10-
// \brief (Time) Series of SensorData messages that may be used for data recording or internal buffering by some sensor models.
10+
// \brief (Time) Series of SensorData messages that may be used for data
11+
// recording or internal buffering by some sensor models.
1112
//
1213
message SensorDataSeries
1314
{
1415
// List of sensor data messages for subsequent timesteps.
1516
//
16-
repeated SensorData sensor_data = 1;
17+
repeated SensorData sensor_data_list = 1;
1718
}
1819

1920
//
20-
// \brief List of SensorData interface copies, one for each sensor in the vehicle.
21-
//
21+
// \brief List of SensorData interface copies, one for each sensor in the
22+
// vehicle.
23+
//
2224
// Can be used to bundle output of multiple sensors in one transmission.
2325
//
2426
message SensorDataList
2527
{
2628
// List of sensor data for multiple sensors at a specific timestep.
2729
//
28-
repeated SensorData sensor = 1;
30+
repeated SensorData sensors = 1;
2931
}
3032

3133
//
32-
// \brief List of sensors where each element contains a time series of SensorData messages.
34+
// \brief List of sensors where each element contains a time series of
35+
// SensorData messages.
3336
//
3437
message SensorDataSeriesList
3538
{
3639
// List of sensor data for multiple sensors at subsequent timesteps.
3740
//
38-
repeated SensorDataSeries sensor = 1;
41+
repeated SensorDataSeries sensors = 1;
3942
}

osi_featuredata.proto

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ package osi;
1111
// object hypothesis and tracking.
1212
//
1313
// All information regarding the environment is given with respect to the sensor
14-
// coordinate system specified in \c DetectionHeader::mounting_position.
14+
// coordinate system specified in \c SensorDetectionHeader::mounting_position.
1515
// When simulating multiple sensors, each sensor has an individual copy of
1616
// \c FeatureData in its own reference frame. This allows an independent
1717
// treatment of the sensors.
@@ -32,7 +32,7 @@ message FeatureData
3232
//
3333
message SensorDetectionHeader
3434
{
35-
// Version number of used detection list messages ( \c DetectionHeader,
35+
// Version number of used detection list messages ( \c SensorDetectionHeader,
3636
// \c LidarDetection, \c LidarDetectionList etc.).
3737
//
3838
optional DetectionInterfaceVersion version = 1;
@@ -41,13 +41,14 @@ message SensorDetectionHeader
4141
// was processed or at which it is transmitted) in the global synchronized
4242
// time.
4343
//
44-
// \note See SensorData::timestamp and SensorData::last_measurement_time
45-
// for detailed discussions on the semantics of time-related fields.
44+
// \note See \c SensorData::timestamp and
45+
// \c SensorData::last_measurement_time for detailed discussions on the
46+
// semantics of time-related fields.
4647
optional Timestamp measurement_time = 2;
4748

4849
// Monotonous counter to identify the exact cycle.
4950
// Generally the detection function is called periodic and
50-
// \c DetectionHeader::cycle_counter corresponds to the number of periods.
51+
// \c SensorDetectionHeader::cycle_counter corresponds to the number of periods.
5152
optional uint64 cycle_counter = 3;
5253

5354

@@ -126,7 +127,7 @@ message SensorDetectionHeader
126127
}
127128

128129
//
129-
// \brief Version of detection messages ( \c DetectionHeader,
130+
// \brief Version of detection messages ( \c SensorDetectionHeader,
130131
// \c LidarDetection, \c LidarDetectionList etc.).
131132
//
132133
message DetectionInterfaceVersion

osi_sensordata.proto

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@ import "osi_hostvehicledata.proto";
1515
package osi;
1616

1717
//
18-
// \brief The virtual sensor information derived from GroundTruth and potentially processed by sensor-models.
18+
// \brief The virtual sensor information derived from \c GroundTruth and
19+
// potentially processed by sensor-models.
1920
//
20-
// The virtual sensor information is supposed to imitate the output of a real sensor. All information regarding the
21-
// environment is given with respect to the sensor coordinate system specified in \c SensorData::mounting_position.
22-
// When simulating multiple sensors, each sensor has an individual copy of the SensorData interface. This allows an
23-
// independent treatment of the sensors.
21+
// The virtual sensor information is supposed to imitate the output of a real
22+
// sensor. All information regarding the environment is given with respect to
23+
// the sensor coordinate system specified in \c SensorData::mounting_position.
24+
// When simulating multiple sensors, each sensor has an individual copy of the
25+
// \c SensorData interface. This allows an independent treatment of the sensors.
2426
//
2527
message SensorData
2628
{
@@ -43,7 +45,7 @@ message SensorData
4345
// The time that the actual measurement was performed (which will usually
4446
// correspond with the timestamp of the GroundTruth the sensor model
4547
// processed to arrive at these results) can be found in the additional
46-
// field SensorData::last_measurement_time.
48+
// field \c SensorData::last_measurement_time.
4749
//
4850
// For an ideal zero latency sensor the two timestamps would be the same
4951
// and would correspond with the timestamp from the current GroundTruth
@@ -100,9 +102,9 @@ message SensorData
100102
// The timestamp of the last real-world measurement (e.g. GT input) that
101103
// this set of sensor data takes into account. This in effect is the last
102104
// time instance of reality the measurements correspond to. See field
103-
// SensorData::timestamp for a detailed discussion. This value is also
104-
// the upper bound to the DetectedObjectHeader::measurement_time and the
105-
// feature data DetectionHeader::measurement_time fields.
105+
// \c SensorData::timestamp for a detailed discussion. This value is also
106+
// the upper bound to the \c DetectedObjectHeader::measurement_time and the
107+
// feature data \c SensorDetectionHeader::measurement_time fields.
106108
//
107109
optional Timestamp last_measurement_time = 8;
108110

osi_sensorview.proto

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ message SensorView
2121

2222
// The data timestamp of the simulation environment. Zero time is arbitrary
2323
// but must be identical for all messages. Zero time does not need to
24-
// coincide with the unix epoch. Recommended is the starting time point of
24+
// coincide with the UNIX epoch. Recommended is the starting time point of
2525
// the simulation.
2626
//
2727
// \note For sensor view data this timestamp coincides both with the
@@ -51,8 +51,8 @@ message SensorView
5151
// \brief Radar Sensor View
5252
//
5353
// Radar-Specific Sensor View Data
54-
message RadarSensorView {
55-
54+
message RadarSensorView
55+
{
5656
// Radar Input Configuration valid at the time the data was created
5757
//
5858
optional RadarSensorInputConfiguration radar_sensor_input_configuration = 1;
@@ -62,45 +62,51 @@ message RadarSensorView {
6262
// This field includes one entry for each ray, in left-to-right,
6363
// top-to-bottom order (think scan lines in a TV).
6464
//
65-
repeated Reflection reflection = 2;
65+
repeated Reflection reflections = 2;
6666

6767
//
6868
// \brief The radar reflection.
6969
//
70-
message Reflection {
70+
message Reflection
71+
{
7172
// Relative signal level of the reflection
7273
//
7374
// This takes the combined_antenna_diagram (losses in TX and RX)
7475
// as well as the signal losses due to scattering and absorption
7576
// into account, and will, when multiplied by TX power yield the
7677
// actual RX power.
78+
//
7779
// Unit: [dB]
7880
optional double signal_strength = 1;
7981

8082
// Time of flight
8183
//
8284
// This is the time of flight of the reflection, which is directly
83-
// proportional to the distance travelled.
85+
// proportional to the distance traveled.
86+
//
8487
// Unit: [s]
8588
optional double time_of_flight = 2;
8689

8790
// Doppler shift
8891
//
8992
// Shift in frequency based on the specified TX frequency
93+
//
9094
// Unit: [Hz]
9195
optional double doppler_shift = 3;
9296

9397
// TX horizontal angle (azimuth)
9498
//
9599
// Horizontal angle of incidence of the source of the reflection
96100
// at the TX antenna.
101+
//
97102
// Unit: [rad]
98103
optional double source_horizontal_angle = 4;
99104

100105
// TX vertical angle (elevation)
101106
//
102107
// Vertical angle of incidence of the source of the reflection
103108
// at the TX antenna.
109+
//
104110
// Unit: [rad]
105111
optional double source_vertical_angle = 5;
106112
}
@@ -110,8 +116,8 @@ message RadarSensorView {
110116
// \brief Lidar Sensor View
111117
//
112118
// Lidar-Specific Sensor View Data
113-
message LidarSensorView {
114-
119+
message LidarSensorView
120+
{
115121
// Lidar Input Configuration valid at the time the data was created
116122
//
117123
optional LidarSensorInputConfiguration lidar_sensor_input_configuration = 1;
@@ -126,26 +132,30 @@ message LidarSensorView {
126132
//
127133
// \brief The lidar reflection.
128134
//
129-
message Reflection {
135+
message Reflection
136+
{
130137
// Relative signal level of the reflection
131138
//
132139
// This takes the combined_antenna_diagram (losses in TX and RX)
133140
// as well as the signal losses due to scattering and absorption
134141
// into account, and will, when multiplied by TX power yield the
135142
// actual RX power.
143+
//
136144
// Unit: [dB]
137145
optional double signal_strength = 1;
138146

139147
// Time of flight
140148
//
141149
// This is the time of flight of the reflection, which is directly
142-
// proportional to the distance travelled.
150+
// proportional to the distance traveled.
151+
//
143152
// Unit: [s]
144153
optional double time_of_flight = 2;
145154

146155
// Doppler shift
147156
//
148157
// Shift in frequency based on the specified TX frequency
158+
//
149159
// Unit: [Hz]
150160
optional double doppler_shift = 3;
151161
}
@@ -155,7 +165,8 @@ message LidarSensorView {
155165
// \brief Camera Sensor View
156166
//
157167
// Camera-Specific Sensor View Data
158-
message CameraSensorView {
168+
message CameraSensorView
169+
{
159170

160171
// Camera Input Configuration valid at the time the data was created
161172
//
@@ -173,7 +184,8 @@ message CameraSensorView {
173184
// \brief Ultrasonic Sensor View
174185
//
175186
// Ultrasonic-Specific Sensor View Data
176-
message UltrasonicSensorView {
187+
message UltrasonicSensorView
188+
{
177189

178190
// Ultrasonic Input Configuration valid at the time the data was created
179191
//

0 commit comments

Comments
 (0)