Skip to content

Commit 3f4a7b5

Browse files
committed
Linguistic review
1 parent 3c7304e commit 3f4a7b5

File tree

2 files changed

+37
-37
lines changed

2 files changed

+37
-37
lines changed

osi_common.proto

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@ package osi3;
1515
//
1616
message Vector3d
1717
{
18-
// The x coordinate.
18+
// The x-coordinate.
1919
//
2020
// Unit: m, m/s, or m/s^2
2121
//
2222
optional double x = 1;
2323

24-
// The y coordinate.
24+
// The y-coordinate.
2525
//
2626
// Unit: m, m/s, or m/s^2
2727
//
2828
optional double y = 2;
2929

30-
// The z coordinate.
30+
// The z-coordinate.
3131
//
3232
// Unit: m, m/s, or m/s^2
3333
//
@@ -43,13 +43,13 @@ message Vector3d
4343
//
4444
message Vector2d
4545
{
46-
// The x coordinate.
46+
// The x-coordinate.
4747
//
4848
// Unit: m, m/s, or m/s^2
4949
//
5050
optional double x = 1;
5151

52-
// The y coordinate.
52+
// The y-coordinate.
5353
//
5454
// Unit: m, m/s, or m/s^2
5555
//
@@ -586,17 +586,17 @@ message WavelengthData
586586
//
587587
message Pedalry
588588
{
589-
// Position of the acceleration-pedal.
589+
// Position of the acceleration pedal.
590590
// Range: 0-1 (Unpressed - fully pressed)
591591
//
592592
optional double pedal_position_acceleration = 1;
593593

594-
// Position of the brake-pedal.
594+
// Position of the brake pedal.
595595
// Range: 0-1 (Unpressed - fully pressed)
596596
//
597597
optional double pedal_position_brake = 2;
598598

599-
// Position of the clutch-pedal.
599+
// Position of the clutch pedal.
600600
// Range: 0-1 (Unpressed - fully pressed)
601601
//
602602
optional double pedal_position_clutch = 3;
@@ -608,35 +608,35 @@ message Pedalry
608608
message VehicleSteeringWheel
609609
{
610610
// Angle of the steering wheel.
611-
// Zero means the steering wheel is in its center position, a positive value
612-
// means the steering wheel is turned to the left and a negative value
611+
// Zero means the steering wheel is in its center position. A positive value
612+
// means the steering wheel is turned to the left. A negative value
613613
// means the steering wheel is turned to the right of the center position.
614614
//
615615
// Unit: rad
616616
//
617617
optional double angle = 1;
618618

619619
// Angular speed of the steering wheel.
620-
// Zero means the steering wheel stays in its position, a positive value
621-
// means the steering wheel is turned to the left and a negative value
620+
// Zero means the steering wheel stays in its position. A positive value
621+
// means the steering wheel is turned to the left. A negative value
622622
// means the steering wheel is turned to the right.
623623
//
624624
// Unit: rad/s
625625
//
626626
optional double angular_speed = 2;
627627

628628
// Torque of the steering wheel to the hand.
629-
// Zero means there is no force from the steering wheel to the driver`s hands.
630-
// A positive value means the steering wheel would turn to the left without driver`s forces
631-
// and a negative value means the steering wheel would turn to the right without driver`s forces.
629+
// Zero means there is no force from the steering wheel to the hand of the driver.
630+
// A positive value means that the steering wheel would turn to the left without driver intervention.
631+
// A negative value means that the steering wheel would turn to the right without driver intervention.
632632
//
633633
// Unit: N*m
634634
//
635635
optional double torque = 3;
636636
}
637637

638638
//
639-
// \brief The geodetic position of an object, i.e. center of the bounding box.
639+
// \brief The geodetic position of an object, that is, the center of the 3D bounding box.
640640
//
641641
message GeodeticPosition
642642
{

osi_hostvehicledata.proto

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import "osi_common.proto";
77

88
package osi3;
99

10-
// \brief Host vehicle data is about the perception of the vehicle about it's own, internal states.
10+
// \brief Host vehicle data is about the perception of the vehicle about its own internal states.
1111
// It can be understood as an interface container for restbussimulation signals.
1212
// If there is a duplication with values from the rest of SensorView or SensorData, than these shall be taken.
1313
//
@@ -40,7 +40,7 @@ message HostVehicleData
4040
optional BaseMoving location = 1;
4141

4242
// Deprecated: Will be removed in next major release. Moved to VehiclePositionAndKinematics.
43-
// Current estimated location error based on GPS- and related navigation
43+
// Current estimated location error based on GPS and related navigation
4444
// sensors.
4545
//
4646
// \note Note that dimension and base_polygon need not be set.
@@ -92,13 +92,13 @@ message HostVehicleData
9292
optional Pedalry pedalry = 1;
9393

9494
// The actual gear of the transmission.
95-
// E.g. a gear lever can be in "D" and transmission in "4", but not the
95+
// For example, a gear lever can be on "D" and the transmission on "4", but not the
9696
// other way around.
9797
//
9898
// The sign of this field is linked to the gear's mode as following:
9999
// - zero: neutral position
100100
// - positive: driving forward mode
101-
// - negative: reverse mode (generally -1, but few vehicles have several
101+
// - negative: reverse mode (generally -1, but few vehicles have more than 1
102102
// reverse mode gears)
103103
//
104104
optional int32 gear_transmission = 2;
@@ -116,13 +116,13 @@ message HostVehicleData
116116
//
117117
optional Type type = 1;
118118

119-
// Rounds per minute of the motor.
119+
// Revolutions per minute of the motor.
120120
//
121121
// Unit: 1/min
122122
//
123123
optional double rpm = 2;
124124

125-
// Torque from the motor.
125+
// Torque of the motor.
126126
//
127127
// Unit: N*m
128128
//
@@ -172,17 +172,17 @@ message HostVehicleData
172172
message WheelData
173173
{
174174
// The axle which contains this wheel. A value of 0 represents the
175-
// front-most axle of the vehicle with higher numbers incrementing
176-
// towards the rear-most axle.
175+
// foremost axle of the vehicle, with higher numbers ascending
176+
// towards the rearmost axle.
177177
//
178178
optional uint32 axle = 1;
179179

180-
// The index of the wheel on the axle, counting in the direction
181-
// of positive-y, that is, right-to-left.
180+
// The index of the wheel on the axle, counted in positive y- direction,
181+
// that is, right-to-left.
182182
//
183183
// For example, on a standard 2-axle, 4-wheel car, the rear-right
184184
// wheel would be (axle=1, index=0).
185-
// This concept works also for twin tires.
185+
// This concept also works for twin tires.
186186
//
187187
optional uint32 index = 2;
188188

@@ -192,7 +192,7 @@ message HostVehicleData
192192
// Unit: rad/s.
193193
//
194194
// The sign convention is defined using the right-hand rule.
195-
// It is applied on the y-axis of the vehicle's reference system (center of bounding box).
195+
// It is applied on the y-axis of the vehicle's reference system, that is, the center of bounding box.
196196
// Counterclockwise is positive and clockwise is negative.
197197
//
198198
// \image html OSI_RotationRate.svg
@@ -207,36 +207,36 @@ message HostVehicleData
207207
// Unit: %
208208
//
209209
// The sign convention is defined using the right-hand rule.
210-
// It is applied on the y-axis of the vehicle's reference system (center of bounding box).
210+
// It is applied on the y-axis of the vehicle's reference system, that is, the center of bounding box.
211211
// Counterclockwise is positive and clockwise is negative.
212212
//
213213
optional double slip = 4;
214214
}
215215
}
216216

217217
//
218-
// \brief Current calculated and estimated location that can be based on GNSS- and related navigation sensors,
219-
// but this message does not contain the single sensor values of the sensorics.
218+
// \brief Current calculated and estimated location that can be based on GNSS and related navigation sensors.
219+
// This message does not contain the individual sensor values of the sensor technology.
220220
//
221-
// This message contains the most accurate information the vehicle knows about its positioning
222-
// available on the board net.
221+
// This message contains the most accurate information the vehicle knows about its position
222+
// available in the on-board network.
223223
// Because of this the values can differ from the "true" values calculated out of
224224
// GroundTruth::proj_string, GroundTruth::MovingObject::BaseMoving::position, GroundTruth::host_vehicle_id.
225225
//
226226
message VehicleLocalization
227227
{
228-
// Most accurate position information of the vehicle available on the board net.
229-
// The reference point for position, i.e. the center (x,y,z) of the bounding box
228+
// Most accurate position information of the vehicle available in the on-board network.
229+
// The reference point for position, that is, the center (x,y,z) of the bounding box
230230
// in context to the global coordinate system.
231231
//
232232
optional Vector3d position = 1;
233233

234-
// Most accurate orientation information of the vehicle available on the board net
234+
// Most accurate orientation information of the vehicle available in the on-board network
235235
// in context to the global coordinate system.
236236
//
237237
optional Orientation3d orientation = 2;
238238

239-
// Most accurate geodetic information of the vehicle available on the board net.
239+
// Most accurate geodetic information of the vehicle available in the on-board network.
240240
//
241241
optional GeodeticPosition geodetic_position = 3;
242242
}

0 commit comments

Comments
 (0)