Merge pull request #1969 from jan-cerny/mem_leak

Plug a memory leak

Author: evgenyz

src/DS/rds.c

@@ -888,7 +888,10 @@ int ds_rds_create(const char* sds_file, const char* xccdf_result_file, const cha
 				result = -1;
 				oscap_source_free(oval_source);
 			} else {
-				oscap_htable_add(oval_result_sources, *oval_result_files, oval_source);
+				if (!oscap_htable_add(oval_result_sources, *oval_result_files, oval_source)) {
+					result = -1;
+					oscap_source_free(oval_source);
+				}
 			}
 			oval_result_files++;
 		}

src/DS/sds.c

@@ -509,7 +509,9 @@ int ds_sds_dump_component_ref_as(const xmlNodePtr component_ref, struct ds_sds_s
 	// make a copy of xlink_href because ds_sds_dump_component_by_href modifies its second argument
 	char *xlink_href_copy = oscap_strdup(xlink_href);
 	int ret = ds_sds_dump_component_by_href(session, xlink_href, target_filename_dirname, relative_filepath, cref_id, &component_id);
-	oscap_htable_add(ds_sds_session_get_component_uris(session), cref_id, xlink_href_copy);
+	if (!oscap_htable_add(ds_sds_session_get_component_uris(session), cref_id, xlink_href_copy)) {
+		free(xlink_href_copy);
+	}
 
 	xmlFree(xlink_href);
 	xmlFree(cref_id);

src/OVAL/oval_generator.c

@@ -171,7 +171,10 @@ void oval_generator_update_timestamp(struct oval_generator *generator)
 
 void oval_generator_add_platform_schema_version(struct oval_generator *generator, const char *platform, const char *schema_version)
 {
-	oscap_htable_add(generator->platform_schema_versions, platform, oscap_strdup(schema_version));
+	char *schema_version_dup = oscap_strdup(schema_version);
+	if (!oscap_htable_add(generator->platform_schema_versions, platform, schema_version_dup)) {
+		free(schema_version_dup);
+	}
 }