fix embeddings types in tests

Author: mattapperson

tests/e2e/embeddings.test.ts

@@ -25,30 +25,29 @@ describe('Embeddings E2E Tests', () => {
       expect(response).toBeDefined();
 
       // Check if response is an object (not a string)
-      if (typeof response === 'object') {
-        expect(response.data).toBeDefined();
-        expect(Array.isArray(response.data)).toBe(true);
-        expect(response.data.length).toBeGreaterThan(0);
-
-        const firstEmbedding = response.data[0];
-        expect(firstEmbedding).toBeDefined();
-        expect(firstEmbedding?.embedding).toBeDefined();
-
-        // Handle both array and base64 string embeddings
-        if (Array.isArray(firstEmbedding?.embedding)) {
-          expect(firstEmbedding.embedding.length).toBeGreaterThan(0);
-          // Verify embedding values are numbers
-          const firstValue = firstEmbedding.embedding[0];
-          expect(typeof firstValue).toBe('number');
-        } else {
-          expect(typeof firstEmbedding?.embedding).toBe('string');
-        }
+      expect(response.data).toBeDefined();
+      expect(Array.isArray(response.data)).toBe(true);
+      expect(response.data.length).toBeGreaterThan(0);
+
+      const firstEmbedding = response.data[0];
+      expect(firstEmbedding).toBeDefined();
+      expect(firstEmbedding?.embedding).toBeDefined();
+
+      // Handle both array and base64 string embeddings
+      if (Array.isArray(firstEmbedding?.embedding)) {
+        expect(firstEmbedding.embedding.length).toBeGreaterThan(0);
+        // Verify embedding values are numbers
+        const firstValue = firstEmbedding.embedding[0];
+        expect(typeof firstValue).toBe('number');
+      } else {
+        expect(typeof firstEmbedding?.embedding).toBe('string');
+      }
 
-        // Verify usage information if available
-        if (response.usage) {
-          expect(response.usage.totalTokens).toBeGreaterThan(0);
-        }
+      // Verify usage information if available
+      if (response.usage) {
+        expect(response.usage.totalTokens).toBeGreaterThan(0);
       }
+      
     });
 
     it('should generate embeddings for multiple text inputs', async () => {
@@ -65,25 +64,24 @@ describe('Embeddings E2E Tests', () => {
 
       expect(response).toBeDefined();
 
-      if (typeof response === 'object') {
-        expect(response.data).toBeDefined();
-        expect(Array.isArray(response.data)).toBe(true);
-        expect(response.data.length).toBe(inputs.length);
+      expect(response.data).toBeDefined();
+      expect(Array.isArray(response.data)).toBe(true);
+      expect(response.data.length).toBe(inputs.length);
 
-        // Verify each embedding
-        response.data.forEach((embedding, index) => {
-          expect(embedding).toBeDefined();
-          expect(embedding?.embedding).toBeDefined();
+      // Verify each embedding
+      response.data.forEach((embedding, index) => {
+        expect(embedding).toBeDefined();
+        expect(embedding?.embedding).toBeDefined();
 
-          if (Array.isArray(embedding?.embedding)) {
-            expect(embedding.embedding.length).toBeGreaterThan(0);
-          } else {
-            expect(typeof embedding?.embedding).toBe('string');
-          }
+        if (Array.isArray(embedding?.embedding)) {
+          expect(embedding.embedding.length).toBeGreaterThan(0);
+        } else {
+          expect(typeof embedding?.embedding).toBe('string');
+        }
 
-          expect(embedding?.index).toBe(index);
-        });
-      }
+        expect(embedding?.index).toBe(index);
+      });
+      
     });
 
     it('should generate consistent embedding dimensions', async () => {
@@ -97,20 +95,18 @@ describe('Embeddings E2E Tests', () => {
 
       expect(response).toBeDefined();
 
-      if (typeof response === 'object') {
-        expect(response.data.length).toBe(2);
+      expect(response.data.length).toBe(2);
 
-        const firstEmbedding = response.data[0]?.embedding;
-        const secondEmbedding = response.data[1]?.embedding;
+      const firstEmbedding = response.data[0]?.embedding;
+      const secondEmbedding = response.data[1]?.embedding;
 
-        // Only check dimensions if both are arrays
-        if (Array.isArray(firstEmbedding) && Array.isArray(secondEmbedding)) {
-          const firstDimension = firstEmbedding.length;
-          const secondDimension = secondEmbedding.length;
+      // Only check dimensions if both are arrays
+      if (Array.isArray(firstEmbedding) && Array.isArray(secondEmbedding)) {
+        const firstDimension = firstEmbedding.length;
+        const secondDimension = secondEmbedding.length;
 
-          expect(firstDimension).toBe(secondDimension);
-          expect(firstDimension).toBeGreaterThan(0);
-        }
+        expect(firstDimension).toBe(secondDimension);
+        expect(firstDimension).toBeGreaterThan(0);
       }
     });
 
@@ -122,14 +118,12 @@ describe('Embeddings E2E Tests', () => {
 
       expect(response).toBeDefined();
 
-      if (typeof response === 'object') {
-        expect(response.data).toBeDefined();
-        expect(Array.isArray(response.data)).toBe(true);
+      expect(response.data).toBeDefined();
+      expect(Array.isArray(response.data)).toBe(true);
 
-        if (response.data.length > 0) {
-          const embedding = response.data[0];
-          expect(embedding?.embedding).toBeDefined();
-        }
+      if (response.data.length > 0) {
+        const embedding = response.data[0];
+        expect(embedding?.embedding).toBeDefined();
       }
     });
 
@@ -142,18 +136,17 @@ describe('Embeddings E2E Tests', () => {
 
       expect(response).toBeDefined();
 
-      if (typeof response === 'object') {
-        expect(response.model).toBeDefined();
-        expect(typeof response.model).toBe('string');
+      expect(response.model).toBeDefined();
+      expect(typeof response.model).toBe('string');
 
-        if (response.usage) {
-          expect(response.usage.promptTokens).toBeDefined();
-          expect(response.usage.totalTokens).toBeDefined();
-          expect(typeof response.usage.promptTokens).toBe('number');
-          expect(typeof response.usage.totalTokens).toBe('number');
-          expect(response.usage.totalTokens).toBeGreaterThan(0);
-        }
+      if (response.usage) {
+        expect(response.usage.promptTokens).toBeDefined();
+        expect(response.usage.totalTokens).toBeDefined();
+        expect(typeof response.usage.promptTokens).toBe('number');
+        expect(typeof response.usage.totalTokens).toBe('number');
+        expect(response.usage.totalTokens).toBeGreaterThan(0);
       }
+    
     });
   });
 });