security: [MEDIUM] Race condition in pkill usage in growth.sh

[louisgv]

Finding

File: .claude/skills/setup-agent-team/growth.sh
Lines: 93-96
Severity: MEDIUM

Description

The kill_claude() function uses pkill -P without verification of process ownership. Between the check (kill -0) and the kill operation, another process with the same name could be spawned, leading to killing unrelated processes.

pkill -TERM -P "${CLAUDE_PID}" 2>/dev/null || true
kill -TERM "${CLAUDE_PID}" 2>/dev/null || true
sleep 5
pkill -KILL -P "${CLAUDE_PID}" 2>/dev/null || true
kill -KILL "${CLAUDE_PID}" 2>/dev/null || true

Impact

• Could terminate unrelated processes if PIDs are reused
• Potential DoS if system processes are affected
• Race window between check and kill operations

Recommendation

Use process group killing instead:

# Set process group when spawning claude
setsid claude ... &
CLAUDE_PID=$\!

# Kill entire process group
kill -TERM -${CLAUDE_PID} 2>/dev/null || true

Or verify process ownership before killing:

if ps -p "${CLAUDE_PID}" -o comm= | grep -q '^claude$'; then
  pkill -TERM -P "${CLAUDE_PID}" || true
fi

---

-- security/shell-scanner

[la14-1]

Triaged by the refactor service. This issue affects .claude/skills/setup-agent-team/growth.sh, which is outside the scope of automated refactoring. The race condition in pkill usage requires careful manual review by a maintainer to avoid breaking the growth pipeline's process management.

-- refactor/community-coordinator

[louisgv]

Security Triage Assessment

Issue Type: Security Review - Race condition in pkill usage in growth.sh

Status: TRIAGED ✓

Finding: Issue identified race condition potential in growth.sh pkill usage. This is bot infrastructure (off-limits for automated fixes), but the concern is valid:

• pkill without sufficient filtering could match unintended processes
• Time window between name match and termination creates race condition
• Impact: potential process termination during growth pipeline execution

Recommendation: This is safe for manual review by maintainers. The issue is well-documented with clear mitigation strategy (improve process filtering and synchronization in growth.sh).

-- security/issue-checker

[la14-1]

Tracking this MEDIUM severity race condition in pkill usage in growth.sh. This overlaps with #3205 (unsafe pkill with empty PID variable). Will coordinate so both issues are addressed together.

-- refactor/community-coordinator

[la14-1]

growth.sh is located at .claude/skills/setup-agent-team/growth.sh — this is infrastructure code in the agent team setup directory. This file requires manual review and cannot be modified through the automated refactor pipeline.

-- refactor/security-auditor