Prevent wallpaper from being copied if transparency is not enabled

Only copies the wallpaper in either one of those instances:

1) the user starts the program with the Fluent theme AND transparency enabled;
2) the user enables the Fluent theme having transparency enabled;
3) the user enables transparency having the Fluent theme enabled.

This prevents the wallpaper from being copied unnecessarily for users with transparency disabled, avoiding potential issues and allowing users to disable it in case of any problems (i.e. they can manually set acrylic=0 in settings.ini). It also has the added bonus of updating the wallpaper without needing to restart the program.

Author: Bentroen

Minecraft Note Block Studio.yyp

@@ -3,6 +3,8 @@ function change_theme() {
 
 	window_set_color(window_background)
 
-
+	if (theme == 3 && acrylic && !wpaperexist) {
+		wallpaper_init()
+	}
 
 }

scripts/change_theme/change_theme.gml

@@ -48,23 +48,13 @@ function control_create() {
 	mouseover = 0
 	display_width = display_get_width()
 	display_height = display_get_height()
+	
+	// Wallpaper
 	wpaper = 0
+	wpaperexist = 0
 	wpaperside = 0
-	ExecuteShell("\"" + data_directory + "wallpaper.bat", true, true)
-	wpaperexist = file_exists(data_directory + "Wallpaper.jpg")
-	if (wpaperexist) {
-		wpaper = sprite_add(data_directory + "Wallpaper.jpg", 1, 0, 0, 0, 0)
-		if (display_width / display_height < sprite_get_width(wpaper) / sprite_get_height(wpaper)) wpaperside = 1
-		wpaperwidth = (sprite_get_width(wpaper) / sprite_get_height(wpaper)) * 720
-		tempsurf = surface_create(wpaperwidth, 720)
-		surface_set_target(tempsurf)
-		draw_sprite_ext(wpaper, 0, 0, 0, 720 / sprite_get_height(wpaper), 720 / sprite_get_height(wpaper), 0, -1, 1)
-		surface_reset_target()
-		sprite_delete(wpaper)
-		wpaper = sprite_create_from_surface(tempsurf, 0, 0, wpaperwidth, 720, 0, 1, 0, 0)
-		surface_free(tempsurf)
-		wpaperblur = sprite_create_blur_alt(wpaper, 0.25, sprite_get_width(wpaper), sprite_get_height(wpaper), 300, 8, 16)
-	}
+	wpaperwidth = 0
+	wpaperblur = 0
 
 	// Audio
 	channels = 256
@@ -493,6 +483,9 @@ function control_create() {
 	if (file_exists_lib(update_file)) {
 		files_delete_lib(update_file)
 	}
+	
+	// Init wallpaper
+	change_theme()
 
 	// Auto-recovery
 	// DISABLED DUE TO https://github.com/HielkeMinecraft/OpenNoteBlockStudio/issues/196

scripts/control_create/control_create.gml

@@ -318,12 +318,12 @@ function draw_window_preferences() {
 		if (!isplayer) if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 20 + 20 + 25, blackout, "Blackout mode", "Makes the workspace background solid black, so you can\nremove in your video editor when recording the screen.", false, true)) blackout = !blackout
 		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 25, windowsound, "Navigation sound", "Whether to play sound effects when navigating the interface.\n(Only applies to the Fluent theme.)", (theme != 3), true)) windowsound = !windowsound
 		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 25, fdark, "Dark mode", "Whether to use darker colors on the interface.\n(Only applies to the Fluent theme.)", (theme != 3), true)) fdark = !fdark
-		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 20 + 25, acrylic, "Transparency effects", "Whether to show transparency effects on the interface.\n(Only applies to the Fluent theme.)", (theme != 3), true)) acrylic = !acrylic
+		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 20 + 25, acrylic, "Transparency effects", "Whether to show transparency effects on the interface.\n(Only applies to the Fluent theme.)", (theme != 3), true)) {acrylic = !acrylic change_theme()}
 		} else {
 		if (!isplayer) if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 20 + 20 + 25, blackout, "全黑模式", "使背景变为纯黑色，可以用于剪辑时扣掉。", false, true)) blackout = !blackout
 		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 25, windowsound, "界面音效", "是否在浏览时播放音效。\n（仅限Fluent主题）", (theme != 3), true)) windowsound = !windowsound
 		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 25, fdark, "暗色模式", "是否在界面上使用暗色调。\n（仅限Fluent主题）", (theme != 3), true)) fdark = !fdark
-		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 20 + 25, acrylic, "透明效果", "是否在界面上显示透明效果。\n（仅限Fluent主题）", (theme != 3), true)) acrylic = !acrylic
+		if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 74 + 16 + 20 + 20 + 20 + 25, acrylic, "透明效果", "是否在界面上显示透明效果。\n（仅限Fluent主题）", (theme != 3), true)) {acrylic = !acrylic change_theme()}
 		}
 
 		// Accent color picker

scripts/draw_window_preferences/draw_window_preferences.gml

@@ -282,10 +282,10 @@ function menu_click(argument0) {
 			break
 		}
 		case "theme": {
-			if (sel = 0) theme = 0
-			else if (sel = 2) theme = 1
-			else if (sel = 1) theme = 2
-			else if (sel = 3) theme = 3
+			if (sel = 0) {theme = 0 change_theme()}
+			else if (sel = 2) {theme = 1 change_theme()}
+			else if (sel = 1) {theme = 2 change_theme()}
+			else if (sel = 3) {theme = 3 change_theme()}
 			break
 		}
 		case "filep": {

scripts/menu_click/menu_click.gml

@@ -0,0 +1,18 @@
+function wallpaper_init() {
+	var tempsurf, wpaperwidth;
+	ExecuteShell("\"" + data_directory + "wallpaper.bat", true, true)
+	wpaperexist = file_exists(data_directory + "Wallpaper.jpg")
+	if (wpaperexist) {
+		wpaper = sprite_add(data_directory + "Wallpaper.jpg", 1, 0, 0, 0, 0)
+		if (display_width / display_height < sprite_get_width(wpaper) / sprite_get_height(wpaper)) wpaperside = 1
+		wpaperwidth = (sprite_get_width(wpaper) / sprite_get_height(wpaper)) * 720
+		tempsurf = surface_create(wpaperwidth, 720)
+		surface_set_target(tempsurf)
+		draw_sprite_ext(wpaper, 0, 0, 0, 720 / sprite_get_height(wpaper), 720 / sprite_get_height(wpaper), 0, -1, 1)
+		surface_reset_target()
+		sprite_delete(wpaper)
+		wpaper = sprite_create_from_surface(tempsurf, 0, 0, wpaperwidth, 720, 0, 1, 0, 0)
+		surface_free(tempsurf)
+		wpaperblur = sprite_create_blur_alt(wpaper, 0.25, sprite_get_width(wpaper), sprite_get_height(wpaper), 300, 8, 16)
+	}
+}