diff --git a/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ClickUtils.java b/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ClickUtils.java
index 7e4c7533f4..5ab8562498 100644
--- a/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ClickUtils.java
+++ b/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ClickUtils.java
@@ -65,7 +65,7 @@
import org.apache.click.Stateful;
import org.openidentityplatform.openam.click.control.AbstractControl;
import org.openidentityplatform.openam.click.control.AbstractLink;
-import org.apache.click.control.ActionLink;
+import org.openidentityplatform.openam.click.control.ActionLink;
import org.openidentityplatform.openam.click.control.Container;
import org.openidentityplatform.openam.click.control.Field;
import org.openidentityplatform.openam.click.control.Form;
@@ -534,11 +534,11 @@ public static void autoPostRedirect(HttpServletRequest request,
}
} catch (IOException ex) {
- org.apache.click.util.ClickUtils.getLogService().error(ex.getMessage(), ex);
+ getLogService().error(ex.getMessage(), ex);
} finally {
- org.apache.click.util.ClickUtils.close(gos);
- org.apache.click.util.ClickUtils.close(os);
+ close(gos);
+ close(os);
}
}
@@ -1151,7 +1151,7 @@ public static InputStream getClickConfig(ServletContext servletContext) {
servletContext.getResourceAsStream(DEFAULT_APP_CONFIG);
if (inputStream == null) {
- inputStream = org.apache.click.util.ClickUtils.getResourceAsStream("/click.xml", org.apache.click.util.ClickUtils.class);
+ inputStream = getResourceAsStream("/click.xml", ClickUtils.class);
if (inputStream == null) {
String msg =
"could not find click app configuration file: "
@@ -1187,7 +1187,7 @@ public static ConfigService getConfigService(ServletContext servletContext) {
+ " editing your web.xml and setting the load-on-startup to 0:\n\n"
+ "
class" attribute selector will be returned. For example:
* a[class=red]. Please note: if the link class attribute is
* not set, the class attribute will be set to its name, prefixed with
@@ -1570,7 +1570,7 @@ public static void deployFile(ServletContext servletContext,
if (!destinationFile.exists()) {
InputStream inputStream =
- getResourceAsStream(resource, org.apache.click.util.ClickUtils.class);
+ getResourceAsStream(resource, ClickUtils.class);
if (inputStream != null) {
FileOutputStream fos = null;
@@ -1676,7 +1676,7 @@ public static void deployFileList(ServletContext servletContext,
String descriptorFile = packageName + "/" + controlName + ".files";
logService.debug("Use deployment descriptor file:" + descriptorFile);
- InputStream is = getResourceAsStream(descriptorFile, org.apache.click.util.ClickUtils.class);
+ InputStream is = getResourceAsStream(descriptorFile, ClickUtils.class);
List fileList = IOUtils.readLines(is);
if (fileList == null || fileList.isEmpty()) {
logService.info("there are no files to deploy for control " + controlClass.getName());
@@ -2194,8 +2194,8 @@ public static LogService getLogService() {
/**
* Return the list of Fields for the given Form, including any Fields
- * contained in FieldSets. The list of returned fields will exclude any
- * Button, FieldSet or Label fields.
+ * contained in child containers. The list of returned fields will exclude
+ * any Button or Label fields.
*
* @param form the form to obtain the fields from
* @return the list of contained form fields
@@ -3072,7 +3072,7 @@ private static void bind(Container container, Context context) {
for (int i = 0; i < container.getControls().size(); i++) {
Control control = container.getControls().get(i);
if (control instanceof Container) {
- // Include fields but skip fieldSets
+ // Include fields that are containers
if (control instanceof Field) {
Field field = (Field) control;
bindField(field, context);
diff --git a/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ContainerUtils.java b/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ContainerUtils.java
index b499b14c72..35db144085 100644
--- a/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ContainerUtils.java
+++ b/openam-core/src/main/java/org/openidentityplatform/openam/click/util/ContainerUtils.java
@@ -37,14 +37,12 @@
import org.openidentityplatform.openam.click.Control;
import org.openidentityplatform.openam.click.Page;
-import org.apache.click.control.Button;
+import org.openidentityplatform.openam.click.control.Button;
import org.openidentityplatform.openam.click.control.Container;
import org.openidentityplatform.openam.click.control.Field;
-import org.apache.click.control.FieldSet;
import org.openidentityplatform.openam.click.control.Form;
-import org.apache.click.control.Label;
-import org.apache.click.service.LogService;
-import org.apache.click.util.ClickUtils;
+import org.openidentityplatform.openam.click.control.Label;
+import org.openidentityplatform.openam.click.service.LogService;
import org.apache.click.util.HtmlStringBuffer;
import org.apache.click.util.PropertyUtils;
import org.apache.commons.lang.ClassUtils;
@@ -114,7 +112,7 @@ public static void copyContainerToObject(Container container,
}
if (fieldList.isEmpty()) {
- LogService logService = org.apache.click.util.ClickUtils.getLogService();
+ LogService logService = ClickUtils.getLogService();
if (logService.isDebugEnabled()) {
String containerClassName =
ClassUtils.getShortClassName(container.getClass());
@@ -137,7 +135,7 @@ public static void copyContainerToObject(Container container,
return;
}
- LogService logService = org.apache.click.util.ClickUtils.getLogService();
+ LogService logService = ClickUtils.getLogService();
SetButton and FieldSet fields.
+ * will exclude any Button fields.
*
* @param container the container to obtain the fields from
* @return the list of contained fields
@@ -452,7 +450,7 @@ public static ListButton, FieldSet and Label
+ * will exclude any Button and Label
* fields.
*
* @param container the container to obtain the fields from
@@ -472,7 +470,7 @@ public static ListButton, FieldSet and Label fields.
+ * Button and Label fields.
*
* @param container the container to obtain the fields from
* @return the list of contained fields
@@ -902,7 +900,7 @@ private static Method findGetter(Object object, String property,
String path) {
// Find the getter for property
- String getterName = org.apache.click.util.ClickUtils.toGetterName(property);
+ String getterName = ClickUtils.toGetterName(property);
Method method = null;
Class> sourceClass = object.getClass();
@@ -913,7 +911,7 @@ private static Method findGetter(Object object, String property,
}
if (method == null) {
- String isGetterName = org.apache.click.util.ClickUtils.toIsGetterName(property);
+ String isGetterName = ClickUtils.toIsGetterName(property);
try {
method = sourceClass.getMethod(isGetterName, (Class[]) null);
} catch (Exception e) {
@@ -973,7 +971,7 @@ private static Method findSetter(Object source,
Method method = null;
// Find the setter for property
- String setterName = org.apache.click.util.ClickUtils.toSetterName(property);
+ String setterName = ClickUtils.toSetterName(property);
Class> sourceClass = source.getClass();
Class>[] classArgs = { targetClass };
@@ -1050,7 +1048,7 @@ private static void logBasicDescription(org.apache.click.util.HtmlStringBuffer b
*/
private static void copyFieldsToMap(ListButton, FieldSet and Label
+ * will exclude any Button and Label
* fields.
*
* @param container the container to obtain the fields from
@@ -1181,8 +1179,8 @@ private static void addInputFields(final Container container, final ListButton, FieldSet
- * and Label fields.
+ * of returned fields will exclude any Button and
+ * Label fields.
*
* @param container the container to obtain the hidden fields from
* @param fields the list of contained fields
@@ -1211,8 +1209,8 @@ private static void addHiddenFields(final Container container, final ListButton and FieldSet
+ * of returned fields will exclude any Button
* fields.
*
* @param container the container to obtain the fields from
@@ -1248,8 +1246,8 @@ private static void addFieldsAndLabels(final Container container, final List