Replies: 1 comment 6 replies
-
|
indeed the feature was designed only for simple name/value inputs; extending it in the way you mention would probably work |
Beta Was this translation helpful? Give feedback.
-
|
I believe it is hidden already: https://github.com/OpenIDC/mod_auth_openidc/blob/master/src/mod_auth_openidc.c#L514 |
Beta Was this translation helpful? Give feedback.
-
|
The order matters. Try loading this html-page for example |
Beta Was this translation helpful? Give feedback.
-
|
ok, would you be able to test this? |
Beta Was this translation helpful? Give feedback.
-
|
No. I was just trying to check if we should enable OIDCPreservePost. I don't have access to anything like a working test-environment. |
Beta Was this translation helpful? Give feedback.
-
|
I verified this successfully, thanks for chiming in! 2b40e41 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi!
I'm trying to preserve POST data. The form has a textarea field.
The submitted form data is
"test
test
test
test"
During the redirection dance I see
mod_auth_openidc_preserve_post_params => {"test":"test%0D%0Atest%0D%0Atest%0D%0Atest%0D%0A"}
which looks good to me. (%0D%0A = CR LF)
After authentication with the idp the browser goes back to the redirect_uri, and then finally the browser does a POST again to the original location. In that request I see "testtesttesttest" - which has the newlines removed.
The Javascript used to replay the POST seems to be dropping that data.
https://github.com/zmartzone/mod_auth_openidc/blob/master/src/mod_auth_openidc.c#L494
behaves differently and is only valid for input elements, not textarea's. For example:
data="test%0D%0Atest%0D%0Atest%0D%0Atest%0D%0A"
input = document.createElement("input");
input.value = decodeURIComponent(data)
input.value
=> 'testtesttesttest'
area = document.createElement("textarea")
area.value = decodeURIComponent(data)
area.value
=> 'test\ntest\ntest\ntest\n'
I believe the element type also needs to be stored in the json data.
Thank you
Beta Was this translation helpful? Give feedback.
All reactions