Fix

Author: LimitlessGreen

.github/workflows/Windows.yml

@@ -133,15 +133,35 @@ jobs:
     - name: Install NSIS
       run: choco install nsis --x86 --force -y
 
-    - name: Setup ccache
-      uses: hendrikmuhs/ccache-action@v1.2
+    - name: Cache ccache
+      uses: actions/cache@v4
       with:
-        key: ${{ runner.os }}-mingw64-ccache
-        restore-keys: ${{ runner.os }}-mingw64-ccache
-        max-size: 2G
-        verbose: 2
-        create-symlink: true
-        job-summary: "🔧 ccache Statistics"
+        path: D:/a/_temp/ccache
+        key: ${{ runner.os }}-mingw64-ccache-${{ hashFiles('src/**/*.cpp', 'src/**/*.c', 'src/**/*.h') }}
+        restore-keys: |
+          ${{ runner.os }}-mingw64-ccache-
+
+    - name: Setup ccache
+      shell: msys2 {0}
+      run: |
+        echo "=== ccache Setup ==="
+        ccache --version
+        
+        # Ensure cache directory exists and use Windows-compatible path
+        export CCACHE_DIR="/d/a/_temp/ccache"
+        mkdir -p "$CCACHE_DIR"
+        
+        ccache --zero-stats
+        ccache --set-config=max_size=2G
+        ccache --set-config=cache_dir="$CCACHE_DIR"
+        ccache --set-config=compression=true
+        
+        echo "CCACHE_DIR=$CCACHE_DIR" >> $GITHUB_ENV
+        
+        echo "=== ccache Configuration ==="
+        ccache --show-config
+        echo "Cache directory: $CCACHE_DIR"
+        ls -la "$CCACHE_DIR" || echo "Cache directory not accessible"
 
 
     - name: Cache FetchContent dependencies
@@ -191,7 +211,7 @@ jobs:
         echo "QT_ROOT_DIR_MSYS: '$QT_ROOT_DIR_MSYS'"
         echo "Qt6_DIR: '$Qt6_DIR'"
         
-        # ccache is automatically configured by the hendrikmuhs/ccache-action
+        # ccache is configured manually for MSYS2 compatibility
         echo "=== ccache Setup Debug ==="
         echo "ccache available: $(which ccache || echo 'not found')"
         if command -v ccache >/dev/null 2>&1; then
@@ -276,7 +296,55 @@ jobs:
         cmake --build . --parallel $(nproc) -- VERBOSE=1
         
         echo "=== Build Complete ==="
-        echo "ccache statistics will be shown in job summary by ccache-action"
+        if command -v ccache >/dev/null 2>&1; then
+          echo "=== Final ccache Statistics ==="
+          ccache --show-stats
+        fi
+
+    - name: Generate ccache Statistics Summary
+      shell: msys2 {0}
+      run: |
+        echo "## 🔧 ccache Build Statistics" >> $GITHUB_STEP_SUMMARY
+        echo "" >> $GITHUB_STEP_SUMMARY
+        if command -v ccache >/dev/null 2>&1; then
+          # Get ccache statistics
+          STATS=$(ccache --show-stats)
+          
+          # Extract key metrics
+          CACHE_HITS=$(echo "$STATS" | grep -E "cache hit" | head -1 | awk '{print $1}')
+          CACHE_MISSES=$(echo "$STATS" | grep -E "cache miss" | head -1 | awk '{print $1}')
+          TOTAL_CALLS=$((CACHE_HITS + CACHE_MISSES))
+          
+          if [ $TOTAL_CALLS -gt 0 ]; then
+            HIT_RATE=$(awk "BEGIN {printf \"%.1f\", ($CACHE_HITS/$TOTAL_CALLS)*100}")
+          else
+            HIT_RATE="0.0"
+          fi
+          
+          # Get cache size info
+          CACHE_SIZE=$(echo "$STATS" | grep -E "cache size" | awk '{print $3 " " $4}')
+          MAX_CACHE_SIZE=$(ccache --show-config | grep max_size | cut -d'=' -f2 | tr -d ' ')
+          
+          echo "| Metric | Value |" >> $GITHUB_STEP_SUMMARY
+          echo "|--------|-------|" >> $GITHUB_STEP_SUMMARY
+          echo "| Cache Hits | $CACHE_HITS |" >> $GITHUB_STEP_SUMMARY
+          echo "| Cache Misses | $CACHE_MISSES |" >> $GITHUB_STEP_SUMMARY
+          echo "| Hit Rate | $HIT_RATE% |" >> $GITHUB_STEP_SUMMARY
+          echo "| Cache Size | $CACHE_SIZE |" >> $GITHUB_STEP_SUMMARY
+          echo "| Max Cache Size | $MAX_CACHE_SIZE |" >> $GITHUB_STEP_SUMMARY
+          echo "" >> $GITHUB_STEP_SUMMARY
+          
+          # Add performance indicator
+          if (( $(echo "$HIT_RATE > 50" | bc -l) )); then
+            echo "🚀 **Excellent cache performance!**" >> $GITHUB_STEP_SUMMARY
+          elif (( $(echo "$HIT_RATE > 20" | bc -l) )); then
+            echo "✅ **Good cache performance**" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "🔄 **Building cache for future runs**" >> $GITHUB_STEP_SUMMARY
+          fi
+        else
+          echo "❌ ccache not available" >> $GITHUB_STEP_SUMMARY
+        fi
 
     - name: Create Standalone Deployment
       shell: msys2 {0}

src/CMakeLists.txt

@@ -231,6 +231,10 @@ set(BUILD_SHARED_LIBS OFF CACHE BOOL "")
 set(ARCHIVE_BUILD_STATIC_LIBS ON CACHE BOOL "")
 set(ARCHIVE_BUILD_EXAMPLES OFF CACHE BOOL "")
 set(ENABLE_ZSTD ON CACHE BOOL "")
+set(ENABLE_LZMA ON CACHE BOOL "")
+# Point libarchive to our bundled LZMA
+set(LIBLZMA_INCLUDE_DIR ${xz_SOURCE_DIR}/src/liblzma/api CACHE PATH "" FORCE)
+set(LIBLZMA_LIBRARY liblzma CACHE FILEPATH "" FORCE)
 set(POSIX_REGEX_LIB "libc" CACHE STRING "" FORCE)
 set(LIBARCHIVE_VERSION "3.8.1")
 
@@ -273,6 +277,7 @@ unset(ENABLE_CPIO)
 unset(ENABLE_CAT)
 unset(ARCHIVE_BUILD_SHARED_LIBS)
 unset(ENABLE_ZSTD)
+unset(ENABLE_LZMA)
 set(LibArchive_FOUND true CACHE BOOL "" FORCE)
 set(LibArchive_LIBRARIES archive_static CACHE FILEPATH "" FORCE)
 set(LibArchive_INCLUDE_DIR ${libarchive_SOURCE_DIR}/libarchive CACHE PATH "" FORCE)
@@ -740,7 +745,7 @@ if(WIN32)
         # Prefer static libraries on Windows
         set(CMAKE_FIND_LIBRARY_SUFFIXES ".a" ".lib" ".dll.a")
     endif()
-    target_link_libraries(${PROJECT_NAME} PRIVATE ${QT}::Core ${QT}::Quick ${QT}::Svg ${CURL_LIBRARIES} ${LibArchive_LIBRARIES} ${ZSTD_LIBRARIES} ${LIBLZMA_LIBRARIES} ${ZLIB_LINK_TARGET} ${ATOMIC_LIBRARY} ${EXTRALIBS} crypt32 secur32 bcrypt)
+    target_link_libraries(${PROJECT_NAME} PRIVATE ${QT}::Core ${QT}::Quick ${QT}::Svg ${CURL_LIBRARIES} ${LibArchive_LIBRARIES} ${ZSTD_LIBRARIES} liblzma ${ZLIB_LINK_TARGET} ${ATOMIC_LIBRARY} ${EXTRALIBS} crypt32 secur32 bcrypt)
 else()
     # On macOS/Linux, let CMake handle transitive dependencies more cleanly
     if(APPLE)
@@ -756,6 +761,16 @@ else()
             ${EXTRALIBS}
         )
     else()
-        target_link_libraries(${PROJECT_NAME} PRIVATE ${QT}::Core ${QT}::Quick ${QT}::Svg ${CURL_LIBRARIES} ${LibArchive_LIBRARIES} ${ZSTD_LIBRARIES} ${LIBLZMA_LIBRARIES} ${ZLIB_LINK_TARGET} ${ATOMIC_LIBRARY} ${EXTRALIBS})
+        # Use consistent target-based linking for Linux too
+        target_link_libraries(${PROJECT_NAME} PRIVATE 
+            ${QT}::Core ${QT}::Quick ${QT}::Svg 
+            ${CURL_LIBRARIES} 
+            ${LibArchive_LIBRARIES} 
+            ${ZSTD_LIBRARIES} 
+            liblzma 
+            ${ZLIB_LINK_TARGET} 
+            ${ATOMIC_LIBRARY} 
+            ${EXTRALIBS}
+        )
     endif()
 endif()