Skip to content

Commit 98e0e3c

Browse files
author
Tajudeen
committed
Fix brand.patch: Correct line numbers and context for VS Code 1.106.0
- extensionLinter.ts: Fix context to include line 32 - html-language-features: Revert to line 25 (was correct) - typescript-language-features: Fix to line 170 (not 172) - server.cli.ts: Fix function signature (err: unknown not err: any) - extensionsActions.ts: Fix to line 2599 with correct context - gettingStartedContent.ts: Fix to line 15 and 225
1 parent dc13155 commit 98e0e3c

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

patches/brand.patch

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ diff --git a/extensions/extension-editing/src/extensionLinter.ts b/extensions/ex
6565
index be7eea1..389e89e 100644
6666
--- a/extensions/extension-editing/src/extensionLinter.ts
6767
+++ b/extensions/extension-editing/src/extensionLinter.ts
68-
@@ -33,4 +33,4 @@ const relativeUrlRequiresHttpsRepository = l10n.t("Relative image URLs require a
68+
@@ -32,5 +32,5 @@ const dataUrlsNotValid = l10n.t("Data URLs are not a valid image source.");
69+
const relativeUrlRequiresHttpsRepository = l10n.t("Relative image URLs require a repository with HTTPS protocol to be specified in the package.json.");
6970
const relativeBadgeUrlRequiresHttpsRepository = l10n.t("Relative badge URLs require a repository with HTTPS protocol to be specified in this package.json.");
7071
-const apiProposalNotListed = l10n.t("This proposal cannot be used because for this extension the product defines a fixed set of API proposals. You can test your extension but before publishing you MUST reach out to the VS Code team.");
7172
-const bumpEngineForImplicitActivationEvents = l10n.t("This activation event can be removed for extensions targeting engine version ^1.75.0 as VS Code will generate these automatically from your package.json contribution declarations.");
@@ -249,7 +250,7 @@ index f36ecf3..9545ba2 100644
249250
- "html.customData.desc": "A list of relative file paths pointing to JSON files following the [custom data format](https://github.com/microsoft/vscode-html-languageservice/blob/master/docs/customData.md).\n\nVS Code loads custom data on startup to enhance its HTML support for the custom HTML tags, attributes and attribute values you specify in the JSON files.\n\nThe file paths are relative to workspace and only workspace folder settings are considered.",
250251
+ "html.customData.desc": "A list of relative file paths pointing to JSON files following the [custom data format](https://github.com/microsoft/vscode-html-languageservice/blob/master/docs/customData.md).\n\n!!APP_NAME!! loads custom data on startup to enhance its HTML support for the custom HTML tags, attributes and attribute values you specify in the JSON files.\n\nThe file paths are relative to workspace and only workspace folder settings are considered.",
251252
"html.format.enable.desc": "Enable/disable default HTML formatter.",
252-
@@ -26,3 +26,3 @@
253+
@@ -25,3 +25,3 @@
253254
"html.suggest.html5.desc": "Controls whether the built-in HTML language support suggests HTML5 tags, properties and values.",
254255
"html.suggest.hideEndTagSuggestions.desc": "Controls whether the built-in HTML language support suggests closing tags. When disabled, end tag completions like `</div>` will not be shown.",
255256
- "html.trace.server.desc": "Traces the communication between VS Code and the HTML language server.",
@@ -377,10 +378,10 @@ index 447359e..e40077c 100644
377378
- "typescript.updateImportsOnFileMove.enabled": "Enable/disable automatic updating of import paths when you rename or move a file in VS Code.",
378379
+ "typescript.updateImportsOnFileMove.enabled": "Enable/disable automatic updating of import paths when you rename or move a file in !!APP_NAME!!.",
379380
"typescript.updateImportsOnFileMove.enabled.prompt": "Prompt on each rename.",
380-
@@ -172,6 +172,6 @@
381-
"configuration.suggest.completeJSDocs": "Enable/disable suggestion to complete JSDoc comments.",
381+
@@ -170,6 +170,6 @@
382382
"typescript.autoClosingTags": "Enable/disable automatic closing of JSX tags.",
383383
"typescript.suggest.enabled": "Enable/disable autocomplete suggestions.",
384+
"configuration.suggest.completeJSDocs": "Enable/disable suggestion to complete JSDoc comments.",
384385
- "configuration.tsserver.useVsCodeWatcher": "Use VS Code's file watchers instead of TypeScript's. Requires using TypeScript 5.4+ in the workspace.",
385386
+ "configuration.tsserver.useVsCodeWatcher": "Use !!APP_NAME!!'s file watchers instead of TypeScript's. Requires using TypeScript 5.4+ in the workspace.",
386387
"configuration.tsserver.useVsCodeWatcher.deprecation": "Please use the `#typescript.tsserver.watchOptions#` setting instead.",
@@ -655,8 +656,8 @@ diff --git a/src/vs/server/node/server.cli.ts b/src/vs/server/node/server.cli.ts
655656
index 0535ddd..79f12dc 100644
656657
--- a/src/vs/server/node/server.cli.ts
657658
+++ b/src/vs/server/node/server.cli.ts
658-
@@ -470,3 +470,3 @@ function asExtensionIdOrVSIX(inputs: string[] | undefined) {
659-
function fatal(message: string, err: any): void {
659+
@@ -469,3 +469,3 @@ function asExtensionIdOrVSIX(inputs: string[] | undefined) {
660+
function fatal(message: string, err: unknown): void {
660661
- console.error('Unable to connect to VS Code server: ' + message);
661662
+ console.error('Unable to connect to !!APP_NAME!! server: ' + message);
662663
console.error(err);
@@ -784,8 +785,8 @@ index 572bb26..53f5740 100644
784785
- alert(localize('uninstallExtensionComplete', "Please reload Visual Studio Code to complete the uninstallation of the extension {0}.", this.extension.displayName));
785786
+ alert(localize('uninstallExtensionComplete', "Please reload !!APP_NAME!! to complete the uninstallation of the extension {0}.", this.extension.displayName));
786787
} catch (error) {
787-
@@ -2600,3 +2600,3 @@ export class ExtensionStatusAction extends ExtensionAction {
788-
} else if (this.extension.deprecationInfo.settings) {
788+
@@ -2599,4 +2599,4 @@ export class ExtensionStatusAction extends ExtensionAction {
789+
} else if (this.extension.deprecationInfo.settings) {
789790
const link = `[${localize('settings', "settings")}](${createCommandUri('workbench.action.openSettings', this.extension.deprecationInfo.settings.map(setting => `@id:${setting}`).join(' '))}})`;
790791
- this.updateStatus({ icon: warningIcon, message: new MarkdownString(localize('deprecated with alternate settings tooltip', "This extension is deprecated as this functionality is now built-in to VS Code. Configure these {0} to use this functionality.", link)) }, true);
791792
+ this.updateStatus({ icon: warningIcon, message: new MarkdownString(localize('deprecated with alternate settings tooltip', "This extension is deprecated as this functionality is now built-in to !!APP_NAME!!. Configure these {0} to use this functionality.", link)) }, true);
@@ -1033,11 +1034,11 @@ diff --git a/src/vs/workbench/contrib/welcomeGettingStarted/common/gettingStarte
10331034
index c7074a5..4fd9ae7 100644
10341035
--- a/src/vs/workbench/contrib/welcomeGettingStarted/common/gettingStartedContent.ts
10351036
+++ b/src/vs/workbench/contrib/welcomeGettingStarted/common/gettingStartedContent.ts
1036-
@@ -16,2 +16,1 @@ import { CONTEXT_ACCESSIBILITY_MODE_ENABLED } from '../../../../platform/accessi
1037+
@@ -15,2 +15,1 @@ import { CONTEXT_ACCESSIBILITY_MODE_ENABLED } from '../../../../platform/accessi
10371038
import { URI } from '../../../../base/common/uri.js';
10381039
-import product from '../../../../platform/product/common/product.js';
10391040

1040-
@@ -227,24 +227,2 @@ const Button = (title: string, href: string) => `[${title}](${href})`;
1041+
@@ -225,24 +225,2 @@ const Button = (title: string, href: string) => `[${title}](${href})`;
10411042

10421043
-const CopilotStepTitle = localize('gettingStarted.copilotSetup.title', "Use AI features with Copilot for free");
10431044
-const CopilotDescription = localize({ key: 'gettingStarted.copilotSetup.description', comment: ['{Locked="["}', '{Locked="]({0})"}'] }, "You can use [Copilot]({0}) to generate code across multiple files, fix errors, ask questions about your code, and much more using natural language.", defaultChat.documentationUrl ?? '');

0 commit comments

Comments
 (0)