Skip to content

Commit c756423

Browse files
committed
refactor/remove v7.0.0 special case by using getResourceDocsList for all versions to ensure consistent URL handling
1 parent 5d8250d commit c756423

1 file changed

Lines changed: 3 additions & 15 deletions

File tree

obp-api/src/main/scala/code/api/v7_0_0/Http4s700.scala

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -307,21 +307,9 @@ object Http4s700 {
307307
) {
308308
ApiVersionUtils.valueOf(requestedApiVersionString)
309309
}
310-
// Use aggregated docs for v7.0.0, version-specific docs for other versions
311-
allDocs = if (requestedApiVersion == ApiVersion.v7_0_0) {
312-
// For v7.0.0, update requestUrl and specifiedUrl for all aggregated docs
313-
// This mirrors the logic in ResourceDocsAPIMethods.getResourceDocsList
314-
allResourceDocs.toList.map { doc =>
315-
// Save original requestUrl before modification (it's in short form like "/banks")
316-
val originalRequestUrl = doc.requestUrl
317-
doc.copy(
318-
requestUrl = s"/${doc.implementedInApiVersion.urlPrefix}/${doc.implementedInApiVersion.vDottedApiVersion}${originalRequestUrl}",
319-
specifiedUrl = Some(s"/${doc.implementedInApiVersion.urlPrefix}/${requestedApiVersion.vDottedApiVersion}${originalRequestUrl}")
320-
)
321-
}
322-
} else {
323-
ResourceDocs140.ImplementationsResourceDocs.getResourceDocsList(requestedApiVersion).getOrElse(Nil)
324-
}
310+
// Use getResourceDocsList for all versions (including v7.0.0)
311+
// This ensures consistent handling of requestUrl and specifiedUrl
312+
allDocs = ResourceDocs140.ImplementationsResourceDocs.getResourceDocsList(requestedApiVersion).getOrElse(Nil)
325313
filteredDocs = ResourceDocsAPIMethodsUtil.filterResourceDocs(allDocs, tags, functions)
326314
} yield JSONFactory1_4_0.createResourceDocsJson(filteredDocs, isVersion4OrHigher = true, localeParam, includeTechnology = true)
327315
}

0 commit comments

Comments
 (0)