diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RubyClientCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RubyClientCodegen.java index 1db870ed1b09..bd8595749bb2 100644 --- a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RubyClientCodegen.java +++ b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/RubyClientCodegen.java @@ -295,7 +295,7 @@ public void processOpts() { // for Faraday additionalProperties.put("isHttpx", Boolean.TRUE); } else { - throw new RuntimeException("Invalid HTTP library " + getLibrary() + ". Only faraday, typhoeus and httpx are supported."); + throw new IllegalArgumentException("Invalid HTTP library " + getLibrary() + ". Only faraday, typhoeus and httpx are supported."); } // test files should not be overwritten @@ -469,11 +469,11 @@ public String toModelDocFilename(String name) { public String toApiFilename(final String name) { // replace - with _ e.g. created-at => created_at String filename = name; - if (apiNameSuffix != null && apiNameSuffix.length() > 0) { + if (apiNameSuffix != null && !apiNameSuffix.isEmpty()) { filename = filename + "_" + apiNameSuffix; } - filename = filename.replaceAll("-", "_"); + filename = filename.replace("-", "_"); // e.g. PhoneNumberApi.rb => phone_number_api.rb return underscore(filename); @@ -494,11 +494,6 @@ public String toModelTestFilename(String name) { return toModelFilename(name) + "_spec"; } - @Override - public String toApiName(String name) { - return super.toApiName(name); - } - @Override public String toEnumValue(String value, String datatype) { if ("Integer".equals(datatype) || "Float".equals(datatype)) { @@ -514,16 +509,16 @@ public String toEnumVarName(String name, String datatype) { return enumNameMapping.get(name); } - if (name.length() == 0) { + if (name.isEmpty()) { return "EMPTY"; } // number if ("Integer".equals(datatype) || "Float".equals(datatype)) { String varName = name; - varName = varName.replaceAll("-", "MINUS_"); - varName = varName.replaceAll("\\+", "PLUS_"); - varName = varName.replaceAll("\\.", "_DOT_"); + varName = varName.replace("-", "MINUS_"); + varName = varName.replace("+", "PLUS_"); + varName = varName.replace(".", "_DOT_"); return NUMERIC_ENUM_PREFIX + varName; } @@ -594,7 +589,7 @@ public String toApiImport(String name) { @Override protected void addAdditionPropertiesToCodeGenModel(CodegenModel codegenModel, Schema schema) { - final Schema additionalProperties = ModelUtils.getAdditionalProperties(schema); + final Schema additionalProperties = ModelUtils.getAdditionalProperties(schema); if (additionalProperties != null) { codegenModel.additionalPropertiesType = getSchemaType(additionalProperties); @@ -692,7 +687,7 @@ private String constructExampleCode(CodegenParameter codegenParameter, HashMap