Skip to content

Finallize Name Migration Consistancy in Code and Maintain Correct Attribution #5

@AptGetMe

Description

@AptGetMe

Hi 👋

First of all, I'm excited about the new oak video editor springboarding off olive and where the project will go!

I'm opening this issue because I think #3 was close prematurely. I think you got most of the name changes / copyright attribution correct! But I have some concerns:

  1. You got most of them, but there are still some files that don't properly attribute Olive example 1
  2. I don't think the line "modifications copyright" should be added on any file header that is not significantly changed from Olive. It's kinda like taking credit for code that was merely copied in from someone else.
  3. I think we need to put the new name of the project as the title on the source file headers while still leaving original copyright statement (KiCad) (i could be wrong on this one)
  4. I don't think there should be copyright headers on non-source files like , SVGs and Configs.

TL;DR: I'd be happy to go through the code base and do my best to help with this!

I wanted to get the green light from you first before starting any work / pull-request.
If you decide not, feel free to close this issue as a duplicate, and we'll move on!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions