[UPG] Base migration upgrade for fields rename.

Author: BT-dherreros

odoo_module_migrate/base_migration_script.py

@@ -208,10 +208,17 @@ def process_file(
         replaces.update(self._TEXT_REPLACES.get(extension, {}))
         replaces.update(renamed_models.get("replaces"))
         replaces.update(removed_models.get("replaces"))
-
         new_text = tools._replace_in_file(
             absolute_file_path, replaces, "Change file content of %s" % filename
         )
+        field_renames = renamed_fields.get("replaces")
+        # To be safe we only rename fields on files associated with the current replaces
+        if field_renames:
+            new_text = tools._replace_field_names(
+                absolute_file_path,
+                field_renames,
+                "Updated field names of %s" % filename,
+            )
 
         # Display errors if the new content contains some obsolete
         # pattern
@@ -260,17 +267,36 @@ def handle_renamed_fields(self, removed_fields):
         For now this handler is simple but the idea would be to improve it
         with deeper analysis and direct replaces if it is possible and secure.
         For that analysis model_name could be used
+        It also will add to the replaces key of the returned dictionary a key value pair
+         to be used in _replace_in_file
         """
-        res = {}
+        res = {"warnings": {}, "replaces": {}}
+        res["replaces"] = {}
         for model_name, old_field_name, new_field_name, more_info in removed_fields:
+            # if model_name in res['replaces']:
+            #     res['replaces'][model_name].update({old_field_name: new_field_name,})
+            # else:
+            model_info = res["replaces"].get(model_name)
+            if model_info:
+                model_info.update({
+                    old_field_name: new_field_name
+                })
+            else:
+                res["replaces"].update({
+                    model_name: {old_field_name: new_field_name}
+                })
             msg = "On the model %s, the field %s was renamed to %s.%s" % (
                 model_name,
                 old_field_name,
                 new_field_name,
                 " %s" % more_info if more_info else "",
             )
-            res[r"""(['"]{0}['"]|\.{0}[\s,=])""".format(old_field_name)] = msg
-        return {"warnings": res}
+            res["warnings"].update(
+                {
+                    r"""(['"]{0}['"]|\.{0}[\s,=])""".format(old_field_name): msg,
+                }
+            )
+        return res
 
     def handle_deprecated_modules(self, manifest_path, deprecated_modules):
         current_manifest_text = tools._read_content(manifest_path)

odoo_module_migrate/migration_scripts/removed_fields/migrate_130_140/mail.yaml

@@ -1 +1 @@
-- ['mail.template', 'user_signature', 'Commit https://github.com/odoo/odoo/commit/de1743ab']
+- ["mail.template", "user_signature", "Commit https://github.com/odoo/odoo/commit/de1743ab"]

odoo_module_migrate/migration_scripts/removed_fields/migrate_150_160/account.yaml

@@ -1 +1 @@
-- ['account.move.line', 'exclude_from_invoice_tab', 'Commit https://github.com/odoo/odoo/commit/d8d47f9ff8554f4b39487fd2f13c153c7d6f958d']
+- ["account.move.line", "exclude_from_invoice_tab", "Commit https://github.com/odoo/odoo/commit/d8d47f9ff8554f4b39487fd2f13c153c7d6f958d"]

odoo_module_migrate/migration_scripts/removed_fields/migrate_150_160/product.yaml

@@ -1 +1 @@
-- ['product.product', 'price', 'Commit https://github.com/odoo/odoo/commit/9e99a9df464d97a74ca320d']
+- ["product.product", "price", "Commit https://github.com/odoo/odoo/commit/9e99a9df464d97a74ca320d"]

odoo_module_migrate/migration_scripts/removed_fields/migrate_160_170/hr.yaml

@@ -1 +1 @@
-- ['hr.expense', 'reference', 'Commit https://github.com/odoo/odoo/commit/68fbdc964038ef6a1cf0d3df773db101ca81794a']
+- ["hr.expense", "reference", "Commit https://github.com/odoo/odoo/commit/68fbdc964038ef6a1cf0d3df773db101ca81794a"]

odoo_module_migrate/migration_scripts/removed_models/migrate_120_130/removed_models.yaml

@@ -0,0 +1,2 @@
+- ["account.invoice", "Commit https://github.com/odoo/odoo/commit/bc131c0cfb51c953de8ec41fb820c8c7831eefb5"]
+- ["account.invoice.line", "Commit https://github.com/odoo/odoo/commit/bc131c0cfb51c953de8ec41fb820c8c7831eefb5"]

odoo_module_migrate/migration_scripts/removed_models/migrate_140_150/removed_models.yaml

@@ -0,0 +1,2 @@
+- ["stock.inventory", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]
+- ["stock.inventory.line", "Commit https://github.com/brain-tec/odoo/commit/bdcb3d192be1e01e1141aa09c60027337009a67b"]

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/account.yaml

@@ -0,0 +1 @@
+- ["account.invoice.report", "product_qty", "quantity", "Commit https://github.com/odoo/odoo/commit/bc131c0cfb51c953de8ec41fb820c8c7831eefb5"]

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/base.yaml

@@ -0,0 +1,2 @@
+- ["image.mixin", "image_original", "image_1920", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]
+- ["mail.channel", "image", "image_128", "Commit https://github.com/odoo/odoo/commit/f0ffbea17381cb117f2eed4ea18a76e2b0f37f00"]

odoo_module_migrate/migration_scripts/renamed_fields/migrate_120_130/hr.yaml

@@ -0,0 +1 @@
+- ["hr.plan.activity.type", "name", "summary", "Commit https://github.com/odoo/odoo/commit/58a2ffa26f1a3b0f9630ce16d11b758d18e20a21"]