Delete transaction from storage if resubmit successful

Author: Matija Petrunic

src/monitorService.ts

@@ -92,6 +92,9 @@ export class TxMonitorService {
         chainId: transaction.chainId,
         gasPrice: newGasPrice
       });
+
+      this.logger.debug(`Deleting transaction ${transaction.hash} from storage`);
+      await this.wallet.walletStorage.deleteTransaction(transaction.hash);
     } catch(error) {
       this.logger.error(`Resending transaction with hash ${transaction.hash} failed, ${error.message}`);
     }

test/monitorService.test.ts

@@ -89,7 +89,10 @@ describe("Transaction monitor service", function () {
 
   });
 
-  it("Check transaction ignores other transactions after resending", function (done) {
+  it(
+    "Check transaction ignores other transactions after resending and deletes transaction if resubmit successful",
+    function (done)
+  {
     walletStorage.getTransactions = async function getTransactions() {
       return [
         {nonce: 1, gasPrice: BigNumber.from(12), submitTime: new Date().getTime() - 300000} as SavedTransactionResponse,
@@ -106,6 +109,7 @@ describe("Transaction monitor service", function () {
 
     setTimeout(() => {
       expect(stub.callCount).to.be.deep.equal(1);
+      expect(deleteTransactionSpy.callCount).to.be.deep.equal(1);
       done();
     }, 30)