-
-
Notifications
You must be signed in to change notification settings - Fork 34
feat: add wezterm integration #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ty! The implementation LGTM so far. Just a couple questions regarding wezterm:
|
Yes, you got me, I mostly just refererenced the other provider implementations, namely tmux and kitty. Now thinking about it, thats an interesting question, With the current approach, I guess there are two problems:
Now with the always trying to find it approach, it works more like what you advertised in the
Sadly, wezterm does not have a show/hide API. The only thing that is the closest to it would be trying to maximize. So the toggle would effectively become |
No worries that's totally reasonable, and it's on me for not catching this suggestion earlier in those providers!
Nice, let's go with always-find then!
Ah gotcha, thanks for explaining. Jerry-rigging minimize/maximize for show/hide would mess with additional windows right? And I suppose DIYing show/hide could confuse wezterm users anyway because they don't expect that behavior in wezterm. So let's stick with killing the window (if I understand you correctly) in |
b57bb31 to
53a9c69
Compare
|
Hey @NickvanDyke, the kill/start toggle is quite fast - this is probably the best we can I have a question about the focus behavior. With
Without
Please advise~ |
8e322c6 to
a2f9442
Compare
a2f9442 to
952eaf3
Compare
|
Ah good points! I like your described behavior w/o Separately I'll reconsider my provider abstraction with these new provider behaviors in mind. You don't have to worry about them for this PR, but I'm thinking:
|
|
It is ready for review, thanks for your time |
|
Thank you for iterating and the insightful discussion! 😀 |
Integration with wezterm leveraging
wezterm cliforpanemanagement.Wezterm does not offer a covenient
focus/hideapi, sokill/restartis the best we can do without complex custom window management logicAll options closely mimic the options provided by
wezterm cli split-pane