Get rid of the yucky GoTo* stuff

Fold it all into Link instead

Author: simonhamp

src/Facades/Menu.php

@@ -4,7 +4,6 @@
 
 use Illuminate\Support\Facades\Facade;
 use Native\Laravel\Menu\Items\Checkbox;
-use Native\Laravel\Menu\Items\GoToUrl;
 use Native\Laravel\Menu\Items\Label;
 use Native\Laravel\Menu\Items\Link;
 use Native\Laravel\Menu\Items\Radio;
@@ -14,10 +13,9 @@
 /**
  * @method static \Native\Laravel\Menu\Menu make(MenuItem ...$items)
  * @method static Checkbox checkbox(string $label, bool $checked = false, ?string $hotkey = null)
- * @method static GoToLink goToUrl(string $url, string $label = null, ?string $hotkey = null)
- * @method static GoToLink goToRoute(string $url, string $label = null, ?string $hotkey = null)
  * @method static Label label(string $label)
  * @method static Link link(string $url, string $label = null, ?string $hotkey = null)
+ * @method static Link route(string $url, string $label = null, ?string $hotkey = null)
  * @method static Radio radio(string $label, bool $checked = false, ?string $hotkey = null)
  * @method static Role app()
  * @method static Role file()

src/Menu/Items/GoToUrl.php

@@ -6,12 +6,22 @@ class Link extends MenuItem
 {
     protected string $type = 'link';
 
+    protected bool $openInBrowser = false;
+
     public function __construct(protected string $url, protected ?string $label, protected ?string $accelerator = null) {}
 
+    public function openInBrowser(bool $openInBrowser = true): self
+    {
+        $this->openInBrowser = $openInBrowser;
+
+        return $this;
+    }
+
     public function toArray(): array
     {
         return array_merge(parent::toArray(), [
             'url' => $this->url,
+            'openInBrowser' => $this->openInBrowser,
         ]);
     }
 }

src/Menu/Items/Link.php

@@ -43,16 +43,6 @@ public function label(string $label): Items\Label
         return new Items\Label($label);
     }
 
-    public function goToUrl(string $url, ?string $label = null, ?string $hotkey = null): Items\GoToUrl
-    {
-        return new Items\GoToUrl($url, $label, $hotkey);
-    }
-
-    public function goToRoute(string $route, ?string $label = null, ?string $hotkey = null): Items\GoToUrl
-    {
-        return new Items\GoToUrl(route($route), $label, $hotkey);
-    }
-
     public function checkbox(string $label, bool $checked = false, ?string $hotkey = null): Items\Checkbox
     {
         return new Items\Checkbox($label, $checked, $hotkey);
@@ -68,6 +58,11 @@ public function link(string $url, ?string $label = null, ?string $hotkey = null)
         return new Items\Link($url, $label, $hotkey);
     }
 
+    public function route(string $route, ?string $label = null, ?string $hotkey = null): Items\Link
+    {
+        return new Items\Link(route($route), $label, $hotkey);
+    }
+
     public function app(): Items\Role
     {
         return new Items\Role(RolesEnum::APP_MENU);