Skip to content

Commit 602ab8f

Browse files
committed
pytest does not like include so embed it
1 parent dd6c368 commit 602ab8f

File tree

3 files changed

+23
-28
lines changed

3 files changed

+23
-28
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
### Added
66

7+
- Typing support. [#698](https://github.com/NLeSC/python-template/pull/698)
8+
79
### Changed
810

911
### Removed

copier/questions/features_code_quality.yml

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,27 @@ SelectGitHubActions:
5555
value: AddLinkCheck_flag
5656
# validator: "{% if something != 'AnotherThing' %}BlaBla{% endif %}"
5757

58-
---
59-
# typing features
60-
!include copier/questions/features_typing.yml
61-
---
58+
AddTyping:
59+
type: bool
60+
default: "{{ 'AddTyping_flag' in SelectCodeQualityFeatures }}"
61+
when: false
62+
63+
SelectTypeChecker:
64+
when: "{{ template_profile != 'minimum' and AddTyping }}"
65+
type: str
66+
default: pyright
67+
help: Select a type checker
68+
choices:
69+
Mypy:
70+
value: mypy
71+
Pyright:
72+
value: pyright
73+
# TODO add pyrefly https://pyrefly.org/
74+
# TODO add ty https://github.com/astral-sh/ty
75+
76+
# TODO add runtime type checking (using pydantic or typeguard)
77+
78+
# TODO ask how strict to typecheck
6279

6380
# computed features
6481
AddLocalTests:

copier/questions/features_typing.yml

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)