Skip to content

Commit 155193f

Browse files
chore: switch e2e workflow runner from Ubuntu to macOS (#245)
* chore: update node version to 22.x in e2e workflow * chore: switch e2e workflow runner from Ubuntu to macOS (#244) * chore: switch e2e workflow runner from Ubuntu to macOS * chore: rename job name from 'e2etest' to 'e2e'
1 parent 315d043 commit 155193f

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

.github/workflows/dev-build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# This worklflow will perform following actions when the code is pushed to development branch:
22
# - Run end to end test.
33
# - Check Linting.
4-
# - Build the latest docker image in development which needs both e2etest and lint to pass first.
4+
# - Build the latest docker image in development which needs both e2e and lint to pass first.
55
# - Push the latest docker image to Google Artifact Registry-Dev.
66
# - Rollout the latest image in GKE.
77
#
@@ -26,7 +26,7 @@ env:
2626
REPOSITORY_NAMESPACE: nfdi4chem
2727

2828
jobs:
29-
e2etest:
29+
e2e:
3030
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/e2e.yml@main
3131

3232
lint:
@@ -36,7 +36,7 @@ jobs:
3636
name: Deploy to dev
3737
if: github.ref == 'refs/heads/development'
3838
runs-on: ubuntu-latest
39-
needs: [lint, e2etest]
39+
needs: [lint, e2e]
4040
steps:
4141
- name: Checkout
4242
uses: actions/checkout@v4

.github/workflows/dev-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- development
77

88
jobs:
9-
e2etest:
9+
e2e:
1010
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/e2e.yml@main
1111
lint:
1212
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/nodejs.yml@main

.github/workflows/e2e.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
workflow_call:
55

66
jobs:
7-
e2etest:
8-
runs-on: ubuntu-latest
7+
e2e:
8+
runs-on: macos-latest
99
strategy:
1010
matrix:
1111
project: [chromium, firefox, webkit]
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v4
1515
- uses: actions/setup-node@v4
1616
with:
17-
node-version: 22.x
17+
node-version-file: package.json
1818
- name: Install dependencies
1919
run: npm ci
2020
- name: Install Playwright
@@ -28,6 +28,7 @@ jobs:
2828
if: always()
2929
uses: actions/upload-artifact@v4
3030
with:
31-
name: test-results-${{ matrix.project }}
32-
path: test-results
33-
31+
name: playwright-${{ matrix.project }}
32+
path: |
33+
test-results
34+
playwright-report

.github/workflows/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/checkout@v4
1111
- uses: actions/setup-node@v4
1212
with:
13-
node-version: 20.x
13+
node-version-file: package.json
1414
- name: Install dependencies
1515
run: npm ci
1616
- name: Run ESLint

.github/workflows/release-please.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# This worklflow will perform following actions when the code is pushed to main branch.
33
# - Run end to end test
44
# - Test linting.
5-
# - Trigger release-please action to create release which needs e2etest & lint to pass first.
5+
# - Trigger release-please action to create release which needs e2e & lint to pass first.
66
#
77
# Maintainers:
88
# - name: Nisha Sharma
@@ -16,15 +16,15 @@ on:
1616
- main
1717

1818
jobs:
19-
e2etest:
19+
e2e:
2020
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/e2e.yml@main
2121

2222
lint:
2323
uses: NFDI4Chem/nmrium-react-wrapper/.github/workflows/nodejs.yml@main
2424

2525
release-please:
2626
runs-on: ubuntu-latest
27-
needs: ['lint', 'e2etest']
27+
needs: ['lint', 'e2e']
2828
steps:
2929
- uses: google-github-actions/release-please-action@v3
3030
with:

0 commit comments

Comments
 (0)