Skip to content

Commit 0155b04

Browse files
committed
bugfix: Fix ImportCompleteArgs parameteres and ExportCompleteArgs TimeUsed
- Change version to 2.3.6.2
1 parent 193769d commit 0155b04

File tree

12 files changed

+111
-54
lines changed

12 files changed

+111
-54
lines changed

source code/MySqlBackup(Devart-Express)/EventArgs/ExportCompleteArgs.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public ExportCompleteArgs(DateTime timeStart, DateTime timeEnd, MySqlBackup.Proc
3838
_completionType = endType;
3939
_timeStart = timeStart;
4040
_timeEnd = timeEnd;
41-
_timeUsed = timeStart - timeEnd;
41+
_timeUsed = timeEnd - timeStart;
4242
_exception = exception;
4343
}
4444
}

source code/MySqlBackup(Devart-Express)/EventArgs/ImportCompleteArgs.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public class ImportCompleteArgs
2121
/// </summary>
2222
public enum CompleteType
2323
{
24+
UnknownStatus,
2425
Completed,
2526
Cancelled,
2627
Error
@@ -44,15 +45,6 @@ public enum CompleteType
4445
/// <summary>
4546
/// Total time used in current import process.
4647
/// </summary>
47-
public TimeSpan TimeUsed
48-
{
49-
get
50-
{
51-
TimeSpan ts = new TimeSpan();
52-
ts = TimeEnd - TimeStart;
53-
return ts;
54-
}
55-
}
56-
48+
public TimeSpan TimeUsed => TimeEnd - TimeStart;
5749
}
5850
}

source code/MySqlBackup(Devart-Express)/MySqlBackup(Devart-Express).csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<ApplicationIcon>logo.ico</ApplicationIcon>
88
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
99
<PackageId>MySqlBackup.Net.DevartExpress</PackageId>
10-
<Version>2.3.6</Version>
1110
<Authors>adriancs</Authors>
1211
<Company>MySqlBackup.NET</Company>
1312
<Product>MySqlBackup.NET.DevartExpress</Product>
@@ -18,8 +17,9 @@
1817
<RepositoryUrl>https://github.com/MySqlBackupNET/MySqlBackup.Net.git</RepositoryUrl>
1918
<RepositoryType>git</RepositoryType>
2019
<PackageTags>mysqlbackup;devart;mysql</PackageTags>
21-
<FileVersion>2.3.6</FileVersion>
22-
<AssemblyVersion>2.3.6</AssemblyVersion>
20+
<Version>2.3.6.2</Version>
21+
<AssemblyVersion>2.3.6.2</AssemblyVersion>
22+
<FileVersion>2.3.6.2</FileVersion>
2323
<PackageReadmeFile>README.md</PackageReadmeFile>
2424
</PropertyGroup>
2525

source code/MySqlBackup(Devart-Express)/MySqlBackup.cs

Lines changed: 34 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public enum ProcessEndType
2727
Error
2828
}
2929

30-
public const string Version = "2.3.6";
30+
public const string Version = "2.3.6.2";
3131

3232
MySqlDatabase _database = new MySqlDatabase();
3333
MySqlServer _server = new MySqlServer();
@@ -614,12 +614,18 @@ void Export_RowsData_Insert_Ignore_Replace(string tableName, string selectSQL)
614614

615615
if (sb.Length == 0)
616616
{
617-
sb.AppendLine(insertStatementHeader);
617+
if (ExportInfo.InsertLineBreakBetweenInserts)
618+
sb.AppendLine(insertStatementHeader);
619+
else
620+
sb.Append(insertStatementHeader);
618621
sb.Append(sqlDataRow);
619622
}
620623
else if ((long)sb.Length + (long)sqlDataRow.Length < ExportInfo.MaxSqlLength)
621624
{
622-
sb.AppendLine(",");
625+
if (ExportInfo.InsertLineBreakBetweenInserts)
626+
sb.AppendLine(",");
627+
else
628+
sb.Append(",");
623629
sb.Append(sqlDataRow);
624630
}
625631
else
@@ -1388,7 +1394,30 @@ void ReportEndProcess()
13881394
ReportProgress();
13891395
if (ImportCompleted != null)
13901396
{
1391-
ImportCompleteArgs arg = new ImportCompleteArgs();
1397+
ImportCompleteArgs.CompleteType completedType;
1398+
switch(processCompletionType)
1399+
{
1400+
case ProcessEndType.Complete:
1401+
completedType = ImportCompleteArgs.CompleteType.Completed;
1402+
break;
1403+
case ProcessEndType.Error:
1404+
completedType = ImportCompleteArgs.CompleteType.Error;
1405+
break;
1406+
case ProcessEndType.Cancelled:
1407+
completedType = ImportCompleteArgs.CompleteType.Cancelled;
1408+
break;
1409+
default:
1410+
completedType = ImportCompleteArgs.CompleteType.UnknownStatus;
1411+
break;
1412+
}
1413+
1414+
ImportCompleteArgs arg = new ImportCompleteArgs()
1415+
{
1416+
LastError = _lastError,
1417+
CompletedType = completedType,
1418+
TimeStart = timeStart,
1419+
TimeEnd = timeEnd,
1420+
};
13921421
ImportCompleted(this, arg);
13931422
}
13941423
}
@@ -1446,4 +1475,4 @@ public void Dispose()
14461475
catch { }
14471476
}
14481477
}
1449-
}
1478+
}

source code/MySqlBackup(MySql.Data)/EventArgs/ExportCompleteArgs.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public ExportCompleteArgs(DateTime timeStart, DateTime timeEnd, MySqlBackup.Proc
3838
_completionType = endType;
3939
_timeStart = timeStart;
4040
_timeEnd = timeEnd;
41-
_timeUsed = timeStart - timeEnd;
41+
_timeUsed = timeEnd - timeStart;
4242
_exception = exception;
4343
}
4444
}

source code/MySqlBackup(MySql.Data)/EventArgs/ImportCompleteArgs.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public class ImportCompleteArgs
2121
/// </summary>
2222
public enum CompleteType
2323
{
24+
UnknownStatus,
2425
Completed,
2526
Cancelled,
2627
Error
@@ -44,15 +45,6 @@ public enum CompleteType
4445
/// <summary>
4546
/// Total time used in current import process.
4647
/// </summary>
47-
public TimeSpan TimeUsed
48-
{
49-
get
50-
{
51-
TimeSpan ts = new TimeSpan();
52-
ts = TimeEnd - TimeStart;
53-
return ts;
54-
}
55-
}
56-
48+
public TimeSpan TimeUsed => TimeEnd - TimeStart;
5749
}
5850
}

source code/MySqlBackup(MySql.Data)/MySqlBackup(MySql.Data).csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
<DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
77
<Nullable>disable</Nullable>
88
<PackageId>MySqlBackup.NET</PackageId>
9-
<Version>2.3.6</Version>
109
<Authors>adriancs</Authors>
1110
<Company>MySqlBackup.NET</Company>
1211
<Product>MySqlBackup.NET</Product>
@@ -16,8 +15,9 @@
1615
<PackageIcon>logo128.png</PackageIcon>
1716
<RepositoryType>git</RepositoryType>
1817
<RepositoryUrl>https://github.com/MySqlBackupNET/MySqlBackup.Net</RepositoryUrl>
19-
<AssemblyVersion>2.3.6</AssemblyVersion>
20-
<FileVersion>2.3.6</FileVersion>
18+
<Version>2.3.6.2</Version>
19+
<AssemblyVersion>2.3.6.2</AssemblyVersion>
20+
<FileVersion>2.3.6.2</FileVersion>
2121
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
2222
<AssemblyName>MySqlBackup</AssemblyName>
2323
<ApplicationIcon>logo.ico</ApplicationIcon>

source code/MySqlBackup(MySql.Data)/MySqlBackup.cs

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public enum ProcessEndType
2828
Error
2929
}
3030

31-
public const string Version = "2.3.6";
31+
public const string Version = "2.3.6.2";
3232

3333
MySqlDatabase _database = new MySqlDatabase();
3434
MySqlServer _server = new MySqlServer();
@@ -1395,7 +1395,30 @@ void ReportEndProcess()
13951395
ReportProgress();
13961396
if (ImportCompleted != null)
13971397
{
1398-
ImportCompleteArgs arg = new ImportCompleteArgs();
1398+
ImportCompleteArgs.CompleteType completedType;
1399+
switch(processCompletionType)
1400+
{
1401+
case ProcessEndType.Complete:
1402+
completedType = ImportCompleteArgs.CompleteType.Completed;
1403+
break;
1404+
case ProcessEndType.Error:
1405+
completedType = ImportCompleteArgs.CompleteType.Error;
1406+
break;
1407+
case ProcessEndType.Cancelled:
1408+
completedType = ImportCompleteArgs.CompleteType.Cancelled;
1409+
break;
1410+
default:
1411+
completedType = ImportCompleteArgs.CompleteType.UnknownStatus;
1412+
break;
1413+
}
1414+
1415+
ImportCompleteArgs arg = new ImportCompleteArgs()
1416+
{
1417+
LastError = _lastError,
1418+
CompletedType = completedType,
1419+
TimeStart = timeStart,
1420+
TimeEnd = timeEnd,
1421+
};
13991422
ImportCompleted(this, arg);
14001423
}
14011424
}

source code/MySqlBackup(MySqlConnector)/EventArgs/ExportCompleteArgs.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public ExportCompleteArgs(DateTime timeStart, DateTime timeEnd, MySqlBackup.Proc
3838
_completionType = endType;
3939
_timeStart = timeStart;
4040
_timeEnd = timeEnd;
41-
_timeUsed = timeStart - timeEnd;
41+
_timeUsed = timeEnd - timeStart;
4242
_exception = exception;
4343
}
4444
}

source code/MySqlBackup(MySqlConnector)/EventArgs/ImportCompleteArgs.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public class ImportCompleteArgs
2121
/// </summary>
2222
public enum CompleteType
2323
{
24+
UnknownStatus,
2425
Completed,
2526
Cancelled,
2627
Error
@@ -44,15 +45,6 @@ public enum CompleteType
4445
/// <summary>
4546
/// Total time used in current import process.
4647
/// </summary>
47-
public TimeSpan TimeUsed
48-
{
49-
get
50-
{
51-
TimeSpan ts = new TimeSpan();
52-
ts = TimeEnd - TimeStart;
53-
return ts;
54-
}
55-
}
56-
48+
public TimeSpan TimeUsed => TimeEnd - TimeStart;
5749
}
5850
}

0 commit comments

Comments
 (0)