Skip to content

Commit 3cab47e

Browse files
committed
[HWG] Switch from predifined profile enum to index
1 parent 840fb98 commit 3cab47e

File tree

2 files changed

+27
-46
lines changed

2 files changed

+27
-46
lines changed

samples/hwgeneration/src/main/java/com/myscript/iink/samples/hwgeneration/GenerationViewModel.kt

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import com.myscript.iink.HandwritingResult
1717
import com.myscript.iink.IHandwritingGeneratorListener
1818
import com.myscript.iink.MimeType
1919
import com.myscript.iink.PointerEvent
20-
import com.myscript.iink.PredefinedHandwritingProfileId
2120
import com.myscript.iink.graphics.Transform
2221
import com.myscript.iink.samples.hwgeneration.None.word
2322
import kotlinx.coroutines.Dispatchers
@@ -40,16 +39,16 @@ data class Message(
4039
}
4140

4241
data class GenerationProfile(
43-
val id: PredefinedHandwritingProfileId = PredefinedHandwritingProfileId.DEFAULT,
42+
val index: Int = 0,
4443
val profilePath: String? = null) {
4544

4645
companion object {
47-
fun fromId(id: PredefinedHandwritingProfileId): GenerationProfile {
46+
fun fromId(id: Int): GenerationProfile {
4847
return GenerationProfile(id, null)
4948
}
5049

5150
fun fromPath(path: String): GenerationProfile {
52-
return GenerationProfile(PredefinedHandwritingProfileId.DEFAULT, path)
51+
return GenerationProfile(-1, path)
5352
}
5453
}
5554
}
@@ -120,18 +119,18 @@ class GenerationViewModel(application: Application, private val engine: Engine)
120119
}
121120

122121
fun getProfiles(): List<GenerationProfile> {
122+
val generator = generator ?: return emptyList()
123+
123124
val userProfiles = File(getApplication<Application>().filesDir, PROFILE_FOLDER).listFiles()?.map { file ->
124125
GenerationProfile.fromPath(file.absolutePath)
125126
} ?: emptyList()
126127

127-
var predefinedProfiles = PredefinedHandwritingProfileId.entries.toList().map {
128+
var predefinedProfiles = generator.createHandwritingProfileBuilder().predefinedProfileCount.let { count ->
129+
(0 until count).toList()
130+
}.map {
128131
GenerationProfile.fromId(it)
129132
}
130133

131-
if (_language.value == HWGLanguage.CHINESE) {
132-
predefinedProfiles = predefinedProfiles.subList(0, 10)
133-
}
134-
135134
return userProfiles + predefinedProfiles
136135
}
137136

@@ -209,7 +208,7 @@ class GenerationViewModel(application: Application, private val engine: Engine)
209208
val profile = if (generationProfile.profilePath != null && File(generationProfile.profilePath).exists()) {
210209
builder.load(generationProfile.profilePath)
211210
} else {
212-
builder.createFromId(generationProfile.id)
211+
builder.getPredefinedProfileAt(generationProfile.index)
213212
}
214213

215214
val indexLock = Any()

samples/hwgeneration/src/main/java/com/myscript/iink/samples/hwgeneration/MainActivity.kt

Lines changed: 18 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import androidx.documentfile.provider.DocumentFile
3434
import androidx.lifecycle.coroutineScope
3535
import com.google.android.material.slider.Slider
3636
import com.myscript.iink.Engine
37-
import com.myscript.iink.PredefinedHandwritingProfileId
3837
import com.myscript.iink.samples.hwgeneration.databinding.ActivityMainBinding
3938
import com.myscript.iink.uireferenceimplementation.EditorView
4039
import kotlinx.coroutines.Dispatchers
@@ -440,42 +439,25 @@ class StyleAdapter(private val context: Context, private val profiles: List<Gene
440439
} else if(language == HWGLanguage.CHINESE) {
441440
profileImage.visibility = View.GONE
442441
profileText.visibility = View.VISIBLE
443-
val profileNumber = when (generationProfile.id) {
444-
PredefinedHandwritingProfileId.DEFAULT -> "1"
445-
PredefinedHandwritingProfileId.PROFILE_1 -> "2"
446-
PredefinedHandwritingProfileId.PROFILE_2 -> "3"
447-
PredefinedHandwritingProfileId.PROFILE_3 -> "4"
448-
PredefinedHandwritingProfileId.PROFILE_4 -> "5"
449-
PredefinedHandwritingProfileId.PROFILE_5 -> "6"
450-
PredefinedHandwritingProfileId.PROFILE_6 -> "7"
451-
PredefinedHandwritingProfileId.PROFILE_7 -> "8"
452-
PredefinedHandwritingProfileId.PROFILE_8 -> "9"
453-
PredefinedHandwritingProfileId.PROFILE_9 -> "10"
454-
PredefinedHandwritingProfileId.PROFILE_10 -> "11"
455-
PredefinedHandwritingProfileId.PROFILE_11 -> "12"
456-
PredefinedHandwritingProfileId.PROFILE_12 -> "13"
457-
PredefinedHandwritingProfileId.PROFILE_13 -> "14"
458-
PredefinedHandwritingProfileId.PROFILE_14 -> "15"
459-
else -> "?"
460-
}
461-
profileText.text = "Profile $profileNumber"
442+
profileText.text = "Profile ${generationProfile.index}"
462443
} else {
463-
profileImage.setImageResource(when (generationProfile.id) {
464-
PredefinedHandwritingProfileId.DEFAULT -> R.drawable.generation_0
465-
PredefinedHandwritingProfileId.PROFILE_1 -> R.drawable.generation_1
466-
PredefinedHandwritingProfileId.PROFILE_2 -> R.drawable.generation_2
467-
PredefinedHandwritingProfileId.PROFILE_3 -> R.drawable.generation_3
468-
PredefinedHandwritingProfileId.PROFILE_4 -> R.drawable.generation_4
469-
PredefinedHandwritingProfileId.PROFILE_5 -> R.drawable.generation_5
470-
PredefinedHandwritingProfileId.PROFILE_6 -> R.drawable.generation_6
471-
PredefinedHandwritingProfileId.PROFILE_7 -> R.drawable.generation_7
472-
PredefinedHandwritingProfileId.PROFILE_8 -> R.drawable.generation_8
473-
PredefinedHandwritingProfileId.PROFILE_9 -> R.drawable.generation_9
474-
PredefinedHandwritingProfileId.PROFILE_10 -> R.drawable.generation_10
475-
PredefinedHandwritingProfileId.PROFILE_11 -> R.drawable.generation_11
476-
PredefinedHandwritingProfileId.PROFILE_12 -> R.drawable.generation_12
477-
PredefinedHandwritingProfileId.PROFILE_13 -> R.drawable.generation_13
478-
PredefinedHandwritingProfileId.PROFILE_14 -> R.drawable.generation_14
444+
profileImage.setImageResource(when (generationProfile.index) {
445+
0 -> R.drawable.generation_0
446+
1 -> R.drawable.generation_1
447+
2 -> R.drawable.generation_2
448+
3 -> R.drawable.generation_3
449+
4 -> R.drawable.generation_4
450+
5 -> R.drawable.generation_5
451+
6 -> R.drawable.generation_6
452+
7 -> R.drawable.generation_7
453+
8 -> R.drawable.generation_8
454+
9 -> R.drawable.generation_9
455+
10 -> R.drawable.generation_10
456+
11 -> R.drawable.generation_11
457+
12 -> R.drawable.generation_12
458+
13 -> R.drawable.generation_13
459+
14 -> R.drawable.generation_14
460+
else -> R.drawable.generation_0
479461
})
480462
profileImage.visibility = View.VISIBLE
481463
profileText.visibility = View.GONE

0 commit comments

Comments
 (0)