From 9518f3bfdf7f419ccf8347feff523161cc0318f0 Mon Sep 17 00:00:00 2001 From: Naksen Date: Wed, 11 Mar 2026 17:14:44 +0300 Subject: [PATCH 1/2] fix: return old krb api --- app/api/main/krb5_router.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/api/main/krb5_router.py b/app/api/main/krb5_router.py index 37ed49721..5dfc8937a 100644 --- a/app/api/main/krb5_router.py +++ b/app/api/main/krb5_router.py @@ -155,13 +155,14 @@ async def setup_kdc( ) async def ktadd( kerberos_adapter: FromDishka[KerberosFastAPIAdapter], - request: KtaddRequest, + names: Annotated[LIMITED_LIST, Body()], ) -> StreamingResponse: """Create keytab from kadmin server. :param Annotated[LDAPSession, Depends ldap_session: ldap :return bytes: file """ + request = KtaddRequest(names=names) return await kerberos_adapter.ktadd(request) @@ -183,12 +184,13 @@ async def get_krb_status( @krb5_router.post( - "/principal", + "/principal/add", dependencies=[Depends(verify_auth), Depends(require_master_db)], error_map=error_map, ) async def add_principal( - request: PrincipalAddRequest, + primary: Annotated[LIMITED_STR, Body()], + instance: Annotated[LIMITED_STR, Body()], kerberos_adapter: FromDishka[KerberosFastAPIAdapter], ) -> None: """Create principal in kerberos with given name. @@ -198,6 +200,9 @@ async def add_principal( :param Annotated[LDAPSession, Depends ldap_session: ldap :raises HTTPException: on failed kamin request. """ + request = PrincipalAddRequest( + principal_name=f"{primary}/{instance}", + ) await kerberos_adapter.add_principal(request) From 346970694a8ae76a70cb846b087641e9dc1022d5 Mon Sep 17 00:00:00 2001 From: Naksen Date: Wed, 11 Mar 2026 17:26:42 +0300 Subject: [PATCH 2/2] test: return old krb api --- tests/test_api/test_main/test_kadmin.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/test_api/test_main/test_kadmin.py b/tests/test_api/test_main/test_kadmin.py index b13909357..9ed7244fb 100644 --- a/tests/test_api/test_main/test_kadmin.py +++ b/tests/test_api/test_main/test_kadmin.py @@ -214,7 +214,7 @@ async def test_ktadd( names = ["test1", "test2"] response = await http_client.post( "/kerberos/ktadd", - json={"names": names, "is_rand_key": False}, + json=names, ) kadmin.ktadd.assert_called() # type: ignore @@ -245,7 +245,7 @@ async def test_ktadd_400( names = ["test1", "test2"] response = await http_client.post( "/kerberos/ktadd", - json={"names": names, "is_rand_key": False}, + json=names, ) assert response.status_code == status.HTTP_400_BAD_REQUEST @@ -395,10 +395,10 @@ async def test_add_princ( :param LDAPSession ldap_session: ldap """ response = await http_client.post( - "/kerberos/principal", + "/kerberos/principal/add", json={ - "principal_name": "host/12345", - "password": None, + "primary": "host", + "instance": "12345", }, ) kadmin_args = kadmin.add_principal.call_args.args # type: ignore