From 09a5effb036bc701127bbea52617e288196f84a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Esteban=20Zim=C3=A1nyi?= Date: Tue, 27 Oct 2026 17:18:52 +0100 Subject: [PATCH] Map no GSL type in the generated bindings MEOS draws its random numbers from the pg_prng generators of PostgreSQL, and no catalog function takes or returns a gsl_rng. The generator maps no gsl_rng to a Go handle, and its README lists none among the handle types. Measured: against the libmeos of MobilityDB a23e01a60b, the regenerated packages equal main's, 3994 flat wrappers and 1435 methods; the functions and types packages build, the portable-parity test and the gomeos examples pass. Why: a binding maps the types MEOS declares. --- tools/README.md | 2 +- tools/codegen.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/README.md b/tools/README.md index b7984b3..1c65019 100644 --- a/tools/README.md +++ b/tools/README.md @@ -30,7 +30,7 @@ The covered shapes are: scalar inputs, wrapped opaque pointers (`Temporal`, `STBox`, `TBox`, `Span`, `SpanSet`, `Set`, `GSERIALIZED`, `TInstant`, `TSequence`, `TSequenceSet`, `Npoint`, `Nsegment`, `SkipList`, `RTree`, `Match`, `BOX3D`, `GBOX`, `AFFINE`, `PJ_CONTEXT`, -`gsl_rng`, `Interval`), C and PostgreSQL text strings, output +`Interval`), C and PostgreSQL text strings, output parameters named `result` / `value` (scalar and wrapped-pointer out-params surfaced as additional Go return values), counted-array inputs (`T **` / `const T *` paired with `int count` or `size_t size`) diff --git a/tools/codegen.py b/tools/codegen.py index 7417c8c..f8dc652 100644 --- a/tools/codegen.py +++ b/tools/codegen.py @@ -272,7 +272,6 @@ class TypeMapping: "GBOX": ("*GBox", "&GBox{_inner: $res}"), "AFFINE": ("*AFFINE", "&AFFINE{_inner: $res}"), "PJ_CONTEXT": ("*PJContext", "&PJContext{_inner: $res}"), - "gsl_rng": ("*GslRng", "&GslRng{_inner: $res}"), }