Skip to content

[JitDiff X64] [EgorBo] Remove unsafe code from DCS utilities (UniqueId, XmlB ... #1869

@MihuBot

Description

@MihuBot

Job completed in 2 minutes 25 seconds (remote runner delay: 0 seconds).
dotnet/runtime#127539

Main commit: dotnet/runtime@5391e9e
PR commit: EgorBo/runtime-1@d4e4f3a

Diffs

Found 85 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46196840
Total bytes of diff: 46197624
Total bytes of delta: 784 (0.00 % of base)
Total relative delta: 0.27
    diff is a regression.
    relative diff is a regression.


Total byte diff includes 476 bytes from reconciling methods
	Base had    8 unique methods,     1516 unique bytes
	Diff had    3 unique methods,     1992 unique bytes

Top file regressions (bytes):
         788 : System.Private.DataContractSerialization.dasm (0.08 % of base)

Top file improvements (bytes):
          -4 : System.DirectoryServices.Protocols.dasm (-0.00 % of base)

2 total files with Code Size differences (1 improved, 1 regressed), 258 unchanged.

Top method regressions (bytes):
        1840 (Infinity of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:Parse(System.ReadOnlySpan`1[char]):this (FullOpts) (0 base, 1 diff methods)
         382 (52.62 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:ToSpan(System.Span`1[char]):this (FullOpts)
         126 (24.51 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.XmlBufferReader:Equals2(int,int,System.String):bool:this (FullOpts)
          87 (Infinity of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:Encode(byte,System.Span`1[char],int) (FullOpts) (0 base, 1 diff methods)
          65 (Infinity of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:Decode(System.ReadOnlySpan`1[short],char,char):int (FullOpts) (0 base, 1 diff methods)

Top method improvements (bytes):
       -1221 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeParse(ptr,int):this (FullOpts) (1 base, 0 diff methods)
        -120 (-21.86 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:TryGetGuid(byte[],int):bool:this (FullOpts)
         -75 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt64(ptr):long:this (FullOpts) (1 base, 0 diff methods)
         -67 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt64(long,ptr):this (FullOpts) (1 base, 0 diff methods)
         -47 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeEncode(byte,ptr) (FullOpts) (1 base, 0 diff methods)
         -46 (-10.85 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(byte[],int):this (FullOpts)
         -45 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeDecode(ptr,char,char):int:this (FullOpts) (1 base, 0 diff methods)
         -31 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt32(ptr):int:this (FullOpts) (1 base, 0 diff methods)
         -28 (-16.28 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(System.String):this (FullOpts)
         -26 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt32(int,ptr):this (FullOpts) (1 base, 0 diff methods)
          -6 (-1.07 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(char[],int,int):this (FullOpts)
          -4 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:get_AuthType():int:this (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
          65 (Infinity of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:Decode(System.ReadOnlySpan`1[short],char,char):int (FullOpts) (0 base, 1 diff methods)
          87 (Infinity of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:Encode(byte,System.Span`1[char],int) (FullOpts) (0 base, 1 diff methods)
        1840 (Infinity of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:Parse(System.ReadOnlySpan`1[char]):this (FullOpts) (0 base, 1 diff methods)
         382 (52.62 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:ToSpan(System.Span`1[char]):this (FullOpts)
         126 (24.51 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.XmlBufferReader:Equals2(int,int,System.String):bool:this (FullOpts)

Top method improvements (percentages):
          -4 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:get_AuthType():int:this (FullOpts) (1 base, 0 diff methods)
         -45 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeDecode(ptr,char,char):int:this (FullOpts) (1 base, 0 diff methods)
         -47 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeEncode(byte,ptr) (FullOpts) (1 base, 0 diff methods)
         -31 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt32(ptr):int:this (FullOpts) (1 base, 0 diff methods)
         -75 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeGetInt64(ptr):long:this (FullOpts) (1 base, 0 diff methods)
       -1221 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeParse(ptr,int):this (FullOpts) (1 base, 0 diff methods)
         -26 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt32(int,ptr):this (FullOpts) (1 base, 0 diff methods)
         -67 (-100.00 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:UnsafeSetInt64(long,ptr):this (FullOpts) (1 base, 0 diff methods)
        -120 (-21.86 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:TryGetGuid(byte[],int):bool:this (FullOpts)
         -28 (-16.28 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(System.String):this (FullOpts)
         -46 (-10.85 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(byte[],int):this (FullOpts)
          -6 (-1.07 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.UniqueId:.ctor(char[],int,int):this (FullOpts)

17 total methods with Code Size differences (12 improved, 5 regressed), 286334 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions