Skip to content

[JitDiff X64] [EgorBo] Remove unsafe code from CRC vectorized helpers #1865

@MihuBot

Description

@MihuBot

Job completed in 2 minutes 7 seconds (remote runner delay: 0 seconds).
dotnet/runtime#127456

Main commit: dotnet/runtime@aba46e3
PR commit: EgorBo/runtime-1@ec95116

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46226656
Total bytes of diff: 46226760
Total bytes of delta: 104 (0.00 % of base)
Total relative delta: -0.67
    diff is a regression.
    relative diff is an improvement.


Total byte diff includes 54 bytes from reconciling methods
	Base had    2 unique methods,       44 unique bytes
	Diff had    2 unique methods,       98 unique bytes

Top file regressions (bytes):
         213 : System.IO.Hashing.dasm (0.54 % of base)

Top file improvements (bytes):
        -109 : System.DirectoryServices.Protocols.dasm (-0.07 % of base)

2 total files with Code Size differences (1 improved, 1 regressed), 258 unchanged.

Top method regressions (bytes):
          49 (Infinity of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ForwardCrc32:LoadReversed(System.ReadOnlySpan`1[byte]):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (0 base, 1 diff methods)
          49 (Infinity of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ForwardCrc64:LoadReversed(System.ReadOnlySpan`1[byte]):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (0 base, 1 diff methods)
          42 (8.25 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ForwardCrc64:UpdateVectorizedCore(ulong,System.ReadOnlySpan`1[byte],byref):ulong:this (FullOpts)
          39 (6.94 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ForwardCrc32:UpdateVectorizedCore(uint,System.ReadOnlySpan`1[byte],byref):uint:this (FullOpts)
          39 (8.63 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ReflectedCrc32:UpdateVectorizedCore(uint,System.ReadOnlySpan`1[byte],byref):uint:this (FullOpts)
          39 (9.15 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ReflectedCrc64:UpdateVectorizedCore(ulong,System.ReadOnlySpan`1[byte],byref):ulong:this (FullOpts)

Top method improvements (bytes):
        -109 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.PartialResultsRetriever:ThreadRoutine():this (FullOpts)
         -22 (-100.00 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ForwardCrc32:LoadReversed(byref,nuint):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (1 base, 0 diff methods)
         -22 (-100.00 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ForwardCrc64:LoadReversed(byref,nuint):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
          49 (Infinity of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ForwardCrc32:LoadReversed(System.ReadOnlySpan`1[byte]):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (0 base, 1 diff methods)
          49 (Infinity of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ForwardCrc64:LoadReversed(System.ReadOnlySpan`1[byte]):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (0 base, 1 diff methods)
          39 (9.15 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ReflectedCrc64:UpdateVectorizedCore(ulong,System.ReadOnlySpan`1[byte],byref):ulong:this (FullOpts)
          39 (8.63 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ReflectedCrc32:UpdateVectorizedCore(uint,System.ReadOnlySpan`1[byte],byref):uint:this (FullOpts)
          42 (8.25 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ForwardCrc64:UpdateVectorizedCore(ulong,System.ReadOnlySpan`1[byte],byref):ulong:this (FullOpts)
          39 (6.94 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ForwardCrc32:UpdateVectorizedCore(uint,System.ReadOnlySpan`1[byte],byref):uint:this (FullOpts)

Top method improvements (percentages):
        -109 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.PartialResultsRetriever:ThreadRoutine():this (FullOpts)
         -22 (-100.00 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc32ParameterSet+ForwardCrc32:LoadReversed(byref,nuint):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (1 base, 0 diff methods)
         -22 (-100.00 % of base) : System.IO.Hashing.dasm - System.IO.Hashing.Crc64ParameterSet+ForwardCrc64:LoadReversed(byref,nuint):System.Runtime.Intrinsics.Vector128`1[ulong] (FullOpts) (1 base, 0 diff methods)

9 total methods with Code Size differences (3 improved, 6 regressed), 286340 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions