Skip to content

[JitDiff X64] [EgorBo] Use safe spans in BigInteger shift helpers #1856

@MihuBot

Description

@MihuBot

Job completed in 15 minutes 44 seconds (remote runner delay: 1 minute 10 seconds).
dotnet/runtime#127409

Main commit: dotnet/runtime@19f4dfc
PR commit: EgorBo/runtime-1@46c7f78

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46196307
Total bytes of diff: 46196443
Total bytes of delta: 136 (0.00 % of base)
Total relative delta: -0.05
    diff is a regression.
    relative diff is an improvement.


Top file regressions (bytes):
         136 : System.Runtime.Numerics.dasm (0.08 % of base)

1 total files with Code Size differences (0 improved, 1 regressed), 259 unchanged.

Top method regressions (bytes):
         198 (50.25 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigIntegerCalculator:LeftShiftSelf(System.Span`1[nuint],int,byref) (FullOpts)
         109 (58.92 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:set_Timeout(System.TimeSpan):this (FullOpts) (1 base, 0 diff methods)

Top method improvements (bytes):
        -109 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.PartialResultsRetriever:ThreadRoutine():this (FullOpts)
         -62 (-14.49 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigIntegerCalculator:RightShiftSelf(System.Span`1[nuint],int,byref) (FullOpts)

Top method regressions (percentages):
         109 (58.92 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:set_Timeout(System.TimeSpan):this (FullOpts) (1 base, 0 diff methods)
         198 (50.25 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigIntegerCalculator:LeftShiftSelf(System.Span`1[nuint],int,byref) (FullOpts)

Top method improvements (percentages):
        -109 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.PartialResultsRetriever:ThreadRoutine():this (FullOpts)
         -62 (-14.49 % of base) : System.Runtime.Numerics.dasm - System.Numerics.BigIntegerCalculator:RightShiftSelf(System.Span`1[nuint],int,byref) (FullOpts)

4 total methods with Code Size differences (2 improved, 2 regressed), 286347 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions