Skip to content

[JitDiff X64] [EgorBo] Use safe span slice-advance loop in Number digit parser #1853

@MihuBot

Description

@MihuBot

Job completed in 2 minutes 47 seconds (remote runner delay: 0 seconds).
dotnet/runtime#127388

Main commit: dotnet/runtime@ad1912b
PR commit: EgorBo/runtime-1@e3b2391

Diffs

Found 83 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46170216
Total bytes of diff: 46170106
Total bytes of delta: -110 (-0.00 % of base)
Total relative delta: 0.31
    diff is an improvement.
    relative diff is a regression.


Total byte diff includes 6 bytes from reconciling methods
	Base had    3 unique methods,      431 unique bytes
	Diff had    3 unique methods,      437 unique bytes

Top file improvements (bytes):
        -110 : System.Private.CoreLib.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method regressions (bytes):
         166 (Infinity of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt64(System.ReadOnlySpan`1[byte]):ulong (FullOpts) (0 base, 1 diff methods)
         152 (Infinity of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt32(System.ReadOnlySpan`1[byte]):uint (FullOpts) (0 base, 1 diff methods)
         119 (Infinity of base) : System.Private.CoreLib.dasm - System.Number:ParseEightDigitsUnrolled(System.ReadOnlySpan`1[byte]):uint (FullOpts) (0 base, 1 diff methods)
          72 (45.86 % of base) : System.Private.CoreLib.dasm - System.Number:AccumulateDecimalDigitsIntoBigInteger(byref,uint,uint,byref) (FullOpts)

Top method improvements (bytes):
        -188 (-14.53 % of base) : System.Private.CoreLib.dasm - System.Number:NumberToFloatingPointBitsSlow[double](byref,uint,uint,uint):ulong (FullOpts)
        -185 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt64(ptr,int):ulong (FullOpts) (1 base, 0 diff methods)
        -155 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt32(ptr,int):uint (FullOpts) (1 base, 0 diff methods)
         -91 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Number:ParseEightDigitsUnrolled(ptr):uint (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
         152 (Infinity of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt32(System.ReadOnlySpan`1[byte]):uint (FullOpts) (0 base, 1 diff methods)
         166 (Infinity of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt64(System.ReadOnlySpan`1[byte]):ulong (FullOpts) (0 base, 1 diff methods)
         119 (Infinity of base) : System.Private.CoreLib.dasm - System.Number:ParseEightDigitsUnrolled(System.ReadOnlySpan`1[byte]):uint (FullOpts) (0 base, 1 diff methods)
          72 (45.86 % of base) : System.Private.CoreLib.dasm - System.Number:AccumulateDecimalDigitsIntoBigInteger(byref,uint,uint,byref) (FullOpts)

Top method improvements (percentages):
        -155 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt32(ptr,int):uint (FullOpts) (1 base, 0 diff methods)
        -185 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Number:DigitsToUInt64(ptr,int):ulong (FullOpts) (1 base, 0 diff methods)
         -91 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Number:ParseEightDigitsUnrolled(ptr):uint (FullOpts) (1 base, 0 diff methods)
        -188 (-14.53 % of base) : System.Private.CoreLib.dasm - System.Number:NumberToFloatingPointBitsSlow[double](byref,uint,uint,uint):ulong (FullOpts)

8 total methods with Code Size differences (4 improved, 4 regressed), 286234 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions