Skip to content

[JitDiff X64] [EgorBo] Optimize more bound checks around logical operators #1690

@MihuBot

Description

@MihuBot

Job completed in 4 minutes 42 seconds (remote runner delay: 0 seconds).
dotnet/runtime#122263

Main commit: dotnet/runtime@2bd10ad
PR commit: EgorBo/runtime-1@16a37b2

Diffs

Found 88 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45953580
Total bytes of diff: 45953431
Total bytes of delta: -149 (-0.00 % of base)
Total relative delta: 0.08
    diff is an improvement.
    relative diff is a regression.


Top file regressions (bytes):
          24 : System.IO.Compression.dasm (0.01 % of base)

Top file improvements (bytes):
        -127 : System.Private.CoreLib.dasm (-0.00 % of base)
         -18 : System.IO.IsolatedStorage.dasm (-0.08 % of base)
         -18 : System.Configuration.ConfigurationManager.dasm (-0.00 % of base)
         -10 : System.Text.Encoding.CodePages.dasm (-0.01 % of base)

5 total files with Code Size differences (4 improved, 1 regressed), 255 unchanged.

Top method regressions (bytes):
          33 (5.14 % of base) : System.Private.CoreLib.dasm - System.Decimal+DecCalc:VarDecFromR8(double,byref) (FullOpts)
          24 (6.05 % of base) : System.IO.Compression.dasm - System.IO.Compression.ZipHelper:DosTimeToDateTime(uint):System.DateTime (FullOpts)
          16 (27.59 % of base) : System.Private.CoreLib.dasm - System.Numerics.BitOperations:Log2SoftwareFallback(uint):int (FullOpts)

Top method improvements (bytes):
        -162 (-22.38 % of base) : System.Private.CoreLib.dasm - System.Convert:ConvertToBase64Array(ptr,ptr,int,int,bool):int (FullOpts)
         -18 (-2.14 % of base) : System.IO.IsolatedStorage.dasm - System.Security.IdentityHelper:ToBase32StringSuitableForDirName(byte[]):System.String (FullOpts)
         -18 (-2.14 % of base) : System.Configuration.ConfigurationManager.dasm - System.Security.IdentityHelper:ToBase32StringSuitableForDirName(byte[]):System.String (FullOpts)
         -14 (-3.90 % of base) : System.Private.CoreLib.dasm - System.IO.Path:Populate83FileNameFromRandomBytes(ptr,int,System.Span`1[char]) (FullOpts)
         -10 (-0.34 % of base) : System.Text.Encoding.CodePages.dasm - System.Text.ISCIIEncoding:GetChars(ptr,int,ptr,int,System.Text.DecoderNLS):int:this (FullOpts)

Top method regressions (percentages):
          16 (27.59 % of base) : System.Private.CoreLib.dasm - System.Numerics.BitOperations:Log2SoftwareFallback(uint):int (FullOpts)
          24 (6.05 % of base) : System.IO.Compression.dasm - System.IO.Compression.ZipHelper:DosTimeToDateTime(uint):System.DateTime (FullOpts)
          33 (5.14 % of base) : System.Private.CoreLib.dasm - System.Decimal+DecCalc:VarDecFromR8(double,byref) (FullOpts)

Top method improvements (percentages):
        -162 (-22.38 % of base) : System.Private.CoreLib.dasm - System.Convert:ConvertToBase64Array(ptr,ptr,int,int,bool):int (FullOpts)
         -14 (-3.90 % of base) : System.Private.CoreLib.dasm - System.IO.Path:Populate83FileNameFromRandomBytes(ptr,int,System.Span`1[char]) (FullOpts)
         -18 (-2.14 % of base) : System.IO.IsolatedStorage.dasm - System.Security.IdentityHelper:ToBase32StringSuitableForDirName(byte[]):System.String (FullOpts)
         -18 (-2.14 % of base) : System.Configuration.ConfigurationManager.dasm - System.Security.IdentityHelper:ToBase32StringSuitableForDirName(byte[]):System.String (FullOpts)
         -10 (-0.34 % of base) : System.Text.Encoding.CodePages.dasm - System.Text.ISCIIEncoding:GetChars(ptr,int,ptr,int,System.Text.DecoderNLS):int:this (FullOpts)

8 total methods with Code Size differences (5 improved, 3 regressed), 283156 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions