Skip to content

[JitDiff X64] [Copilot] Add ArrayBuilder.AddRange and use it instead of List ... #1675

@MihuBot

Description

@MihuBot

Job completed in 18 minutes (remote runner delay: 1 minute 31 seconds).

Using arguments: -NoPRLink

Diffs

Found 85 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45954941
Total bytes of diff: 45962441
Total bytes of delta: 7500 (0.02 % of base)
Total relative delta: 8.68
    diff is a regression.
    relative diff is a regression.


Total byte diff includes 5942 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had    8 unique methods,     5942 unique bytes

Top file regressions (bytes):
        7060 : System.Private.CoreLib.dasm (0.09 % of base)
         309 : System.IO.Ports.dasm (0.61 % of base)
          66 : System.IO.IsolatedStorage.dasm (0.29 % of base)
          65 : System.Diagnostics.Process.dasm (0.06 % of base)

4 total files with Code Size differences (0 improved, 4 regressed), 256 unchanged.

Top method regressions (bytes):
        1040 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.__Canon]:AddRange(System.Collections.Generic.IEnumerable`1[System.__Canon]):this (FullOpts) (0 base, 1 diff methods)
         730 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.Numerics.Vector`1[float]]:AddRange(System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):this (FullOpts) (0 base, 1 diff methods)
         704 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.Nullable`1[int]]:AddRange(System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this (FullOpts) (0 base, 1 diff methods)
         702 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[double]:AddRange(System.Collections.Generic.IEnumerable`1[double]):this (FullOpts) (0 base, 1 diff methods)
         693 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[short]:AddRange(System.Collections.Generic.IEnumerable`1[short]):this (FullOpts) (0 base, 1 diff methods)
         691 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[byte]:AddRange(System.Collections.Generic.IEnumerable`1[byte]):this (FullOpts) (0 base, 1 diff methods)
         691 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[int]:AddRange(System.Collections.Generic.IEnumerable`1[int]):this (FullOpts) (0 base, 1 diff methods)
         691 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[long]:AddRange(System.Collections.Generic.IEnumerable`1[long]):this (FullOpts) (0 base, 1 diff methods)
         158 (25.28 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_OSX():System.String[] (FullOpts)
         151 (20.63 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_FreeBSD():System.String[] (FullOpts)
         120 (101.69 % of base) : System.Private.CoreLib.dasm - System.Threading.TimerQueue+TimerQueueDebuggerTypeProxy:get_Items():System.Threading.TimerQueueTimer[]:this (FullOpts)
         108 (63.91 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFileSystemInfos():System.IO.FileSystemInfo[]:this (FullOpts)
         104 (52.53 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetDirectories():System.IO.DirectoryInfo[]:this (FullOpts)
         104 (52.53 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFiles():System.IO.FileInfo[]:this (FullOpts)
         102 (74.45 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetDirectories(System.String,System.IO.EnumerationOptions):System.IO.DirectoryInfo[]:this (FullOpts)
         102 (74.45 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFiles(System.String,System.IO.EnumerationOptions):System.IO.FileInfo[]:this (FullOpts)
         102 (91.07 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFileSystemInfos(System.String,System.IO.EnumerationOptions):System.IO.FileSystemInfo[]:this (FullOpts)
          69 (41.82 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetDirectories(System.String):System.String[] (FullOpts)
          69 (41.82 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFiles(System.String):System.String[] (FullOpts)
          69 (41.82 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFileSystemEntries(System.String):System.String[] (FullOpts)
          66 (11.60 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.Helper:GetExistingRandomDirectory(System.String):System.String (FullOpts)
          65 (21.89 % of base) : System.Diagnostics.Process.dasm - System.Diagnostics.Process:EnsureHandleCountPopulated():this (FullOpts)
          54 (50.00 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetDirectories(System.String,System.String,System.IO.EnumerationOptions):System.String[] (FullOpts)
          54 (50.00 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFiles(System.String,System.String,System.IO.EnumerationOptions):System.String[] (FullOpts)
          54 (50.00 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFileSystemEntries(System.String,System.String,System.IO.EnumerationOptions):System.String[] (FullOpts)
           7 (2.83 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.__Canon]:ToArray():System.__Canon[]:this (FullOpts)

Top method regressions (percentages):
         691 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[byte]:AddRange(System.Collections.Generic.IEnumerable`1[byte]):this (FullOpts) (0 base, 1 diff methods)
         702 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[double]:AddRange(System.Collections.Generic.IEnumerable`1[double]):this (FullOpts) (0 base, 1 diff methods)
         691 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[int]:AddRange(System.Collections.Generic.IEnumerable`1[int]):this (FullOpts) (0 base, 1 diff methods)
         691 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[long]:AddRange(System.Collections.Generic.IEnumerable`1[long]):this (FullOpts) (0 base, 1 diff methods)
         693 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[short]:AddRange(System.Collections.Generic.IEnumerable`1[short]):this (FullOpts) (0 base, 1 diff methods)
        1040 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.__Canon]:AddRange(System.Collections.Generic.IEnumerable`1[System.__Canon]):this (FullOpts) (0 base, 1 diff methods)
         704 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.Nullable`1[int]]:AddRange(System.Collections.Generic.IEnumerable`1[System.Nullable`1[int]]):this (FullOpts) (0 base, 1 diff methods)
         730 (Infinity of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.Numerics.Vector`1[float]]:AddRange(System.Collections.Generic.IEnumerable`1[System.Numerics.Vector`1[float]]):this (FullOpts) (0 base, 1 diff methods)
         120 (101.69 % of base) : System.Private.CoreLib.dasm - System.Threading.TimerQueue+TimerQueueDebuggerTypeProxy:get_Items():System.Threading.TimerQueueTimer[]:this (FullOpts)
         102 (91.07 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFileSystemInfos(System.String,System.IO.EnumerationOptions):System.IO.FileSystemInfo[]:this (FullOpts)
         102 (74.45 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetDirectories(System.String,System.IO.EnumerationOptions):System.IO.DirectoryInfo[]:this (FullOpts)
         102 (74.45 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFiles(System.String,System.IO.EnumerationOptions):System.IO.FileInfo[]:this (FullOpts)
         108 (63.91 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFileSystemInfos():System.IO.FileSystemInfo[]:this (FullOpts)
         104 (52.53 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetDirectories():System.IO.DirectoryInfo[]:this (FullOpts)
         104 (52.53 % of base) : System.Private.CoreLib.dasm - System.IO.DirectoryInfo:GetFiles():System.IO.FileInfo[]:this (FullOpts)
          54 (50.00 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetDirectories(System.String,System.String,System.IO.EnumerationOptions):System.String[] (FullOpts)
          54 (50.00 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFiles(System.String,System.String,System.IO.EnumerationOptions):System.String[] (FullOpts)
          54 (50.00 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFileSystemEntries(System.String,System.String,System.IO.EnumerationOptions):System.String[] (FullOpts)
          69 (41.82 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetDirectories(System.String):System.String[] (FullOpts)
          69 (41.82 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFiles(System.String):System.String[] (FullOpts)
          69 (41.82 % of base) : System.Private.CoreLib.dasm - System.IO.Directory:GetFileSystemEntries(System.String):System.String[] (FullOpts)
         158 (25.28 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_OSX():System.String[] (FullOpts)
          65 (21.89 % of base) : System.Diagnostics.Process.dasm - System.Diagnostics.Process:EnsureHandleCountPopulated():this (FullOpts)
         151 (20.63 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialPort:GetPortNames_FreeBSD():System.String[] (FullOpts)
          66 (11.60 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.Helper:GetExistingRandomDirectory(System.String):System.String (FullOpts)
           7 (2.83 % of base) : System.Private.CoreLib.dasm - System.Collections.Generic.ArrayBuilder`1[System.__Canon]:ToArray():System.__Canon[]:this (FullOpts)

26 total methods with Code Size differences (0 improved, 26 regressed), 283141 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions